| Message ID | 20220126092542.64659-1-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/highmem: remove unnecessary done label | expand |
On Wed, Jan 26, 2022 at 5:26 PM Miaohe Lin <linmiaohe@huawei.com> wrote: > > Remove unnecessary done label to simplify the code. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
On 26.01.22 10:25, Miaohe Lin wrote: > Remove unnecessary done label to simplify the code. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > --- > mm/highmem.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/mm/highmem.c b/mm/highmem.c > index 762679050c9a..0cc0c4da7ed9 100644 > --- a/mm/highmem.c > +++ b/mm/highmem.c > @@ -736,11 +736,11 @@ void *page_address(const struct page *page) > list_for_each_entry(pam, &pas->lh, list) { > if (pam->page == page) { > ret = pam->virtual; > - goto done; > + break; > } > } > } > -done: > + > spin_unlock_irqrestore(&pas->lock, flags); > return ret; > } > @@ -773,13 +773,12 @@ void set_page_address(struct page *page, void *virtual) > list_for_each_entry(pam, &pas->lh, list) { > if (pam->page == page) { > list_del(&pam->list); > - spin_unlock_irqrestore(&pas->lock, flags); > - goto done; > + break; > } > } > spin_unlock_irqrestore(&pas->lock, flags); > } > -done: > + > return; > } > Reviewed-by: David Hildenbrand <david@redhat.com>
On Wed, 26 Jan 2022, Miaohe Lin wrote: > Remove unnecessary done label to simplify the code. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Acked-by: David Rientjes <rientjes@google.com>
diff --git a/mm/highmem.c b/mm/highmem.c index 762679050c9a..0cc0c4da7ed9 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -736,11 +736,11 @@ void *page_address(const struct page *page) list_for_each_entry(pam, &pas->lh, list) { if (pam->page == page) { ret = pam->virtual; - goto done; + break; } } } -done: + spin_unlock_irqrestore(&pas->lock, flags); return ret; } @@ -773,13 +773,12 @@ void set_page_address(struct page *page, void *virtual) list_for_each_entry(pam, &pas->lh, list) { if (pam->page == page) { list_del(&pam->list); - spin_unlock_irqrestore(&pas->lock, flags); - goto done; + break; } } spin_unlock_irqrestore(&pas->lock, flags); } -done: + return; }
Remove unnecessary done label to simplify the code. Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/highmem.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)