[04/12] memory-failure: fetch compound_head after pgmap_pfn_valid()

Commit Message

Andrew Morton Jan. 29, 2022, 9:41 p.m. UTC

From: Joao Martins <[e-mail]>
Subject: memory-failure: fetch compound_head after pgmap_pfn_valid()

memory_failure_dev_pagemap() at the moment assumes base pages (e.g. 
dax_lock_page()).  For devmap with compound pages fetch the compound_head
in case a tail page memory failure is being handled.

Currently this is a nop, but in the advent of compound pages in
dev_pagemap it allows memory_failure_dev_pagemap() to keep working.

Without this fix memory-failure handling (i.e.  MCEs on pmem) with
device-dax configured namespaces will regress (and crash).  

Link: https://lkml.kernel.org/r/[e-mail]
Reported-by: Jane Chu <[e-mail]>
Signed-off-by: Joao Martins <[e-mail]>
Reviewed-by: Naoya Horiguchi <[e-mail]>
Reviewed-by: Dan Williams <[e-mail]>
Reviewed-by: Muchun Song <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 mm/memory-failure.c |    6 ++++++
 1 file changed, 6 insertions(+)

Patch

--- a/mm/memory-failure.c~memory-failure-fetch-compound_head-after-pgmap_pfn_valid
+++ a/mm/memory-failure.c
@@ -1596,6 +1596,12 @@  static int memory_failure_dev_pagemap(un
 	}
 
 	/*
+	 * Pages instantiated by device-dax (not filesystem-dax)
+	 * may be compound pages.
+	 */
+	page = compound_head(page);
+
+	/*
 	 * Prevent the inode from being freed while we are interrogating
 	 * the address_space, typically this would be handled by
 	 * lock_page(), but dax pages do not use the page lock. This