From patchwork Wed Feb 2 02:42:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liam R. Howlett" X-Patchwork-Id: 12732532 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D2FDC4332F for ; Wed, 2 Feb 2022 02:42:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3BF98D00B0; Tue, 1 Feb 2022 21:42:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CED658D00AF; Tue, 1 Feb 2022 21:42:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A52B78D00B0; Tue, 1 Feb 2022 21:42:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 9716A8D00AF for ; Tue, 1 Feb 2022 21:42:15 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5876682A1ACB for ; Wed, 2 Feb 2022 02:42:15 +0000 (UTC) X-FDA: 79096290630.15.2655327 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf31.hostedemail.com (Postfix) with ESMTP id DC9E520002 for ; Wed, 2 Feb 2022 02:42:14 +0000 (UTC) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2120Gv7T026579; Wed, 2 Feb 2022 02:42:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=LoBjNyQQCSfaqMQPcqQD1MBkRdMkS+I+bAbIczSM42s=; b=IIsQY/N1OIWvCp4NgKAivf4PgBnABR0usyzqmAKrcF9p4m3zEloAbz7jSKb4i3j8OvQO XWzAQNL6AaApXwmdpYugGTt1zxOCTNMByjGaOShY7MoUPjPYp4aTrt4uJ+KPYD0hi1op 85q8VKRnBcvL+v+r2c3Czn4JyRJjoyYKNv8h2NZEHwIy6W3B3TKy4WdvpG9LemaWF6jq W+RMtIeNPVmZMt3cDTA0jWlUaPhNsfENxBrRvt3dvygNxMkjC/W/HG0TcUioeZi1LYI0 hR2PgGniycoY9115oejnLZJoe36IXNzZgVTDlhh0GZQvXy07onmj5t0TGvuGXHVSVGRN fQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3dxj9vcu12-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Feb 2022 02:42:14 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 2122ZdSH126532; Wed, 2 Feb 2022 02:42:13 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2177.outbound.protection.outlook.com [104.47.56.177]) by userp3030.oracle.com with ESMTP id 3dvtq1m94n-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Feb 2022 02:42:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X4JVgm+I5337hmn2Kr3RfVMvixsBShGp5ZCYa2l8EgiMj3DHwTFZhoGxALGB+yx6YP9XgN2J8c80dde5s8XMBI4ussctD+JfR2Afs7bywSorl6DlkuBGFix3yYGjkSVfnEBHVqz0TYf5NOJa4/rJOUD0A6LGgCsJG2JYvOCgxP7hiZl8Tin+99cwK0O5mwyuZ4C/IO0YzHRJyCLAHxo7Rwd8Gm4lGkShSZO2cb7009W/FuJXCfoL+6YkwCVTsRJlkE7+zN7GiJLoiq8aVLJYtfQqc6d/CAQBpZ/AaCunKc/YblFv2IQLEp58dZvuNKe8EhkA9YUvfX15+hm78CQsyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LoBjNyQQCSfaqMQPcqQD1MBkRdMkS+I+bAbIczSM42s=; b=KJP60giJw99ZZa9cN8RBJ5K5WwY2I+VUbvM04fBMkXsCZ68JXFXtYxXOoCrDekj+RguLk7cRC5kvp86V90//Jj3TacEllWKiF6hUSXCovHn39STe4DPsTQwl4ammkNze95dqcDAAoPoDvU/+KgRmWp2tFGR30R4s0RK+jkArYXcRB1KTmsNCpiaWh8p1S/cWgKeDdqcjE0tahbPC2/9L38/W4k8jby4xP+MCyui5EVW5+pGxTSd1gZrcOPFjX7/IhKzrNS09KZnI+uuKaMxE8XfRAgBOFfEHXgvFYFtlfd5dD6iKqmwInuwSmUXu4qw31bwhXC2Av/vl6RT5XEEvYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LoBjNyQQCSfaqMQPcqQD1MBkRdMkS+I+bAbIczSM42s=; b=YrxMGHN0uHhJ/W4fpCSH9DAOKpJMs+P6DqNFz6L1Dbum3FR8CmRajacpj3mtw0lOTPonYCWbd1Upz0jt1q2ksCNR3EmqsmJiw049tksqs9Vj/AKM1b375QPz3UBD/1eD7wmxjD4zySuXmA9SR/uEvFcU56UgrojKLO46dXi7Qhg= Received: from SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) by BY5PR10MB4129.namprd10.prod.outlook.com (2603:10b6:a03:210::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Wed, 2 Feb 2022 02:42:10 +0000 Received: from SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::3857:3a25:3444:fdd3]) by SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::3857:3a25:3444:fdd3%5]) with mapi id 15.20.4930.022; Wed, 2 Feb 2022 02:42:10 +0000 From: Liam Howlett To: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: [PATCH v5 22/70] mm/khugepaged: Optimize collapse_pte_mapped_thp() by using vma_lookup() Thread-Topic: [PATCH v5 22/70] mm/khugepaged: Optimize collapse_pte_mapped_thp() by using vma_lookup() Thread-Index: AQHYF953kq1YNrY+6ke1p6yd/nldXw== Date: Wed, 2 Feb 2022 02:42:06 +0000 Message-ID: <20220202024137.2516438-23-Liam.Howlett@oracle.com> References: <20220202024137.2516438-1-Liam.Howlett@oracle.com> In-Reply-To: <20220202024137.2516438-1-Liam.Howlett@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.34.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 873a2e04-a3e1-4298-7fc3-08d9e5f59c6a x-ms-traffictypediagnostic: BY5PR10MB4129:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pNysBAziDAy2L+7do+W8yLTUoTUWDJBtA/hg//kOcot1Uaze8KHPOz0Ga7g9HgRpmweXOBCm3Vq3AqppYYpZcyU76CpmGD3e4OJ8/hArhrxvoP6fOkDhKMPPnD0Z1B+DFQab1nBxhj0Pcz/X14EuSTNbwJh4vAxQ8b/mPzqmRjjJ8fPgRZSVZFu7qtaqshICsU9icZXQTxKuYSjwSEHgsE+yWrfu6Q2DicUN5OjBI4bKbUCzUUSOiGXmwxgFbyTZVc+43kJWX8O7+gX1tFQ7RKsBnHE5K8DhxyD0ESbAON6sDZvb4UnQm5DJuC1roNy//TFYdFZ8YmSghJ7A5rjvGmm6moxLqQGQxGuzlplV6zLKjR2Rg371JkHnIWXINTxrwsqDm6G6iv40r+Yl/MkSeFoy92tHYzfQyP+CvRNv2dquTNLXa/ilCVHf33B6kGXbu68kGloXocHKZXLANi3BZAHUnih8K4OicXdbTf3ONdf7AxpomBuA/BxnCDMGVUPnk7KaGTHLePUlT1vT4FMzqodU/oaCmg0KXDSGgf8aZzTFPo/bzUfbfnKnvo4cjzolhje0TuGAVaxd3jheKNTszD7f0rviYaug/stRUqSl6RLJGXEbrtGSCeQGroo3G1ObzJ+Me6zhuZDvXOB+jW/bMP1HfDsU96KdNdaOwEi4RjpK6wibMd9YVvAn+cigbdrWSQUs5zopNTWDvOHX3XdpTQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR10MB3022.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38070700005)(6486002)(83380400001)(36756003)(1076003)(26005)(186003)(122000001)(38100700002)(110136005)(316002)(91956017)(44832011)(4744005)(5660300002)(2906002)(8676002)(8936002)(2616005)(66946007)(76116006)(64756008)(66446008)(66476007)(66556008)(6666004)(508600001)(6512007)(71200400001)(6506007)(86362001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?tqjtKl30p+k0e4yqxByfJ7A?= =?iso-8859-1?q?j+uNLlC1rIAlwj/SYLHfzlFJLwDM2M4zX4HrYQDSAp0zBHBtAeH/t2zan5vy?= =?iso-8859-1?q?kXt/2w7IdsbXiGLv5N9wL7LLZKRowmgnbY2j1L+GzO/yQLFvN2AvKXcgoHNj?= =?iso-8859-1?q?73n0sf2GQr292ge4DnInIci66837K6nLJBRk3v8XBVvG2eMw7fYx3tPhBJ/v?= =?iso-8859-1?q?Yif15WVR+KuGfT0kZ8ja0JvXdN7uxLERcEvWnvzAtM/KXfZGw7aoF+hts2tH?= =?iso-8859-1?q?sb4pI+0CqPQJfRjBLUYzjjkB9koLsE7lYK10wZkxCQfYBU3v+dAUdA1RKLYK?= =?iso-8859-1?q?xjtVkt2q2EdN+dDXdCsdbJ/sFnhHoOysH5fwEVEWXait//GlutjMXBQOnQS2?= =?iso-8859-1?q?5MOlXrtGI9o1SwfYuOTmCuG9m8LNMc1i/ta8Qb3s6YmZOsFFpLU/nbBU9hfI?= =?iso-8859-1?q?l3iyIKsa4Vw9lfYDR4Kc7QboMznwvD7gIQCvvVym6ppn2P7ezGjmvTUzzHLm?= =?iso-8859-1?q?BjrpxR/uljL79Jtw7xubELyoU5H530kZdYGvsGsDxDkg1wxwMcCqPMTtGZxn?= =?iso-8859-1?q?1GTQ1X6m53kCS91BL77AspUXbjG/YHxIjtgYQLQU3Q+9AwmrRUvOppdpUZeq?= =?iso-8859-1?q?UurwR+VazUCffZur3GDHT2K53mZ9oHr0iPKeXuArFC3t5JjGy7WLF5jOUU2U?= =?iso-8859-1?q?sZbYqWsrbWquZjUpCj/0Jp/jSiiutey9z7cUYMJ5V6O4sxjjNaqw44DW/Vwi?= =?iso-8859-1?q?HDZAZVGGixjg5wXvawC6+JAJFTF30uxYdom/AUkpQzxfCU3mMC4rOI5SwJxU?= =?iso-8859-1?q?DGO+g39vZSvEoabuUNYQoQ6Eo0pgcd/gkjraI1GroqEWJcRxjIN2cmEgWjxc?= =?iso-8859-1?q?w7VZwBks1v/L/AydWVlnG9BFSZnPoN2QH8hh+7jvwUqTyqweTV8K0vwLEAmZ?= =?iso-8859-1?q?8Q0YH1JYzt+3UwsPSAosq0uKWIacRQtyz6T+niYYoLOMmWuiQMRr0YZrGNs+?= =?iso-8859-1?q?1pmhINoJ4QymmQCJVbospdGpa2Dmf4OfDpLRX6K80Xhz/4VbXw7hUEkRFrVF?= =?iso-8859-1?q?To6LD+k/V2QGLy3c+d+GZZPBb/txDP2Ch2fejrAT3yOVFgaoMKoqamO9jUw0?= =?iso-8859-1?q?2/cbokGabItXENpun5M2LiObmezb2cA9OerDkaLIAHIHldqFdEPpUOMrIfC8?= =?iso-8859-1?q?/KpSri+Wx2OUWHoyw7lfkTkoyQC/CHU4CDIucyGSAwxpQSeX/1MxCWLC33AU?= =?iso-8859-1?q?jHCRixc3yIepA8TwYHKXBSNg+9pIiy0z5Zz47zLOyM8FrKOHv1KNl8Q+hGvC?= =?iso-8859-1?q?6z9v7Zr+1YAdFN1/WRgj5+RQkzdyMM9W+gMK/nm1mt8QWLCxYym4ZWiN2/Z2?= =?iso-8859-1?q?dpOvNPthXOeIEVOn+ooAyL17/ELjzNADwbiN35/dyVtjQGuO5OD+yXCnkXZC?= =?iso-8859-1?q?XDJ667xLFH1+BpEBOR79Nuv8ZzFPNnsPRtq1AXPfukJ42cNLbedR7mYJojtn?= =?iso-8859-1?q?4RCEz3zg0Fzj0j/4ntw+OZ49Jo3iaPILj7ohaaI8hPlZGTtQLBzjAdUmR2NT?= =?iso-8859-1?q?8m0k21CpSGtrBLJnkVr0NwR7eqspBqfHOOxLrxF3bqalV6LfQ8Sdt+rS3pFG?= =?iso-8859-1?q?1XS7fsONJ1KF50D32vy1sdAFvjVIzw7srh1nk6lLKSOuUvUjVYORJQpy91bw?= =?iso-8859-1?q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 873a2e04-a3e1-4298-7fc3-08d9e5f59c6a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 02:42:06.8299 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nxM/Q2asnLEXpu/Oa6sq8uadRfQfnomOYwb4pnqnYgefvR4dbFThpzxyR2/Z8XRZUg62vQrQBm7sc/yZ0KMfKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4129 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10245 signatures=673430 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=935 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202020010 X-Proofpoint-ORIG-GUID: e4lc4NO6xt0Vur0UjSmtZurcQXD5vbmg X-Proofpoint-GUID: e4lc4NO6xt0Vur0UjSmtZurcQXD5vbmg X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DC9E520002 X-Stat-Signature: 5q951w5g6x9sjzckwdahwgik8funf94g X-Rspam-User: nil Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b="IIsQY/N1"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=YrxMGHN0; spf=none (imf31.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-HE-Tag: 1643769734-616073 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Liam R. Howlett" vma_lookup() will walk the vma tree once and not continue to look for the next vma. Since the exact vma is checked below, this is a more optimal way of searching. Signed-off-by: Liam R. Howlett Reviewed-by: Vlastimil Babka --- mm/khugepaged.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 35f14d0a00a6..c4c4107bb767 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -1430,7 +1430,7 @@ static int khugepaged_add_pte_mapped_thp(struct mm_struct *mm, void collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr) { unsigned long haddr = addr & HPAGE_PMD_MASK; - struct vm_area_struct *vma = find_vma(mm, haddr); + struct vm_area_struct *vma = vma_lookup(mm, haddr); struct page *hpage; pte_t *start_pte, *pte; pmd_t *pmd, _pmd;