[01/10] Revert "mm/page_isolation: unset migratetype directly for non Buddy page"

Commit Message

Andrew Morton Feb. 4, 2022, 4:49 a.m. UTC

From: Chen Wandun <[e-mail]>
Subject: Revert "mm/page_isolation: unset migratetype directly for non Buddy page"

This reverts commit 721fb891ad0b3956d5c168b2931e3e5e4fb7ca40.

commit 721fb891ad0b ("mm/page_isolation: unset migratetype directly for
non Buddy page") will result memory that should in buddy disappear by
mistake.  move_freepages_block move all pages in pageblock instead of
pages indicated by input parameter, so if input pages is not in buddy but
other pages in pageblock is in buddy, it will result in page out of
control.

Link: https://lkml.kernel.org/r/[e-mail]
Fixes: 721fb891ad0b ("mm/page_isolation: unset migratetype directly for non Buddy page")
Signed-off-by: Chen Wandun <[e-mail]>
Reported-by: "kernelci.org bot" <[e-mail]>
Acked-by: David Hildenbrand <[e-mail]>
Tested-by: Dong Aisheng <[e-mail]>
Tested-by: Francesco Dolcini <[e-mail]>
Acked-by: Vlastimil Babka <[e-mail]>
Tested-by: Guenter Roeck <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 mm/page_isolation.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

--- a/mm/page_isolation.c~revert-mm-page_isolation-unset-migratetype-directly-for-non-buddy-page
+++ a/mm/page_isolation.c
@@ -115,7 +115,7 @@  static void unset_migratetype_isolate(st
 	 * onlining - just onlined memory won't immediately be considered for
 	 * allocation.
 	 */
-	if (!isolated_page && PageBuddy(page)) {
+	if (!isolated_page) {
 		nr_pages = move_freepages_block(zone, page, migratetype, NULL);
 		__mod_zone_freepage_state(zone, nr_pages, migratetype);
 	}