| Message ID | 20220302082145.12028-1-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/huge_memory: make is_transparent_hugepage() static | expand |
On Wed, Mar 2, 2022 at 4:22 PM Miaohe Lin <linmiaohe@huawei.com> wrote: > > It's only used inside the huge_memory.c now. Don't export it and make > it static. We can thus reduce the size of huge_memory.o a bit. > > Without this patch: > text data bss dec hex filename > 32319 2965 4 35288 89d8 mm/huge_memory.o > > With this patch: > text data bss dec hex filename > 32042 2957 4 35003 88bb mm/huge_memory.o > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Muchun Song <songmuchun@bytedance.com> Thanks.
On Wed, Mar 2, 2022 at 12:22 AM Miaohe Lin <linmiaohe@huawei.com> wrote: > > It's only used inside the huge_memory.c now. Don't export it and make > it static. We can thus reduce the size of huge_memory.o a bit. > > Without this patch: > text data bss dec hex filename > 32319 2965 4 35288 89d8 mm/huge_memory.o > > With this patch: > text data bss dec hex filename > 32042 2957 4 35003 88bb mm/huge_memory.o > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Yang Shi <shy828301@gmail.com> > --- > include/linux/huge_mm.h | 6 ------ > mm/huge_memory.c | 3 +-- > 2 files changed, 1 insertion(+), 8 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 0734aff8fa19..2999190adc22 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -183,7 +183,6 @@ unsigned long thp_get_unmapped_area(struct file *filp, unsigned long addr, > > void prep_transhuge_page(struct page *page); > void free_transhuge_page(struct page *page); > -bool is_transparent_hugepage(struct page *page); > > bool can_split_folio(struct folio *folio, int *pextra_pins); > int split_huge_page_to_list(struct page *page, struct list_head *list); > @@ -341,11 +340,6 @@ static inline bool transhuge_vma_enabled(struct vm_area_struct *vma, > > static inline void prep_transhuge_page(struct page *page) {} > > -static inline bool is_transparent_hugepage(struct page *page) > -{ > - return false; > -} > - > #define transparent_hugepage_flags 0UL > > #define thp_get_unmapped_area NULL > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index b49e1a11df2e..592588825c07 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -533,7 +533,7 @@ void prep_transhuge_page(struct page *page) > set_compound_page_dtor(page, TRANSHUGE_PAGE_DTOR); > } > > -bool is_transparent_hugepage(struct page *page) > +static inline bool is_transparent_hugepage(struct page *page) > { > if (!PageCompound(page)) > return false; > @@ -542,7 +542,6 @@ bool is_transparent_hugepage(struct page *page) > return is_huge_zero_page(page) || > page[1].compound_dtor == TRANSHUGE_PAGE_DTOR; > } > -EXPORT_SYMBOL_GPL(is_transparent_hugepage); > > static unsigned long __thp_get_unmapped_area(struct file *filp, > unsigned long addr, unsigned long len, > -- > 2.23.0 >
diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 0734aff8fa19..2999190adc22 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -183,7 +183,6 @@ unsigned long thp_get_unmapped_area(struct file *filp, unsigned long addr, void prep_transhuge_page(struct page *page); void free_transhuge_page(struct page *page); -bool is_transparent_hugepage(struct page *page); bool can_split_folio(struct folio *folio, int *pextra_pins); int split_huge_page_to_list(struct page *page, struct list_head *list); @@ -341,11 +340,6 @@ static inline bool transhuge_vma_enabled(struct vm_area_struct *vma, static inline void prep_transhuge_page(struct page *page) {} -static inline bool is_transparent_hugepage(struct page *page) -{ - return false; -} - #define transparent_hugepage_flags 0UL #define thp_get_unmapped_area NULL diff --git a/mm/huge_memory.c b/mm/huge_memory.c index b49e1a11df2e..592588825c07 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -533,7 +533,7 @@ void prep_transhuge_page(struct page *page) set_compound_page_dtor(page, TRANSHUGE_PAGE_DTOR); } -bool is_transparent_hugepage(struct page *page) +static inline bool is_transparent_hugepage(struct page *page) { if (!PageCompound(page)) return false; @@ -542,7 +542,6 @@ bool is_transparent_hugepage(struct page *page) return is_huge_zero_page(page) || page[1].compound_dtor == TRANSHUGE_PAGE_DTOR; } -EXPORT_SYMBOL_GPL(is_transparent_hugepage); static unsigned long __thp_get_unmapped_area(struct file *filp, unsigned long addr, unsigned long len,
It's only used inside the huge_memory.c now. Don't export it and make it static. We can thus reduce the size of huge_memory.o a bit. Without this patch: text data bss dec hex filename 32319 2965 4 35288 89d8 mm/huge_memory.o With this patch: text data bss dec hex filename 32042 2957 4 35003 88bb mm/huge_memory.o Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- include/linux/huge_mm.h | 6 ------ mm/huge_memory.c | 3 +-- 2 files changed, 1 insertion(+), 8 deletions(-)