| Message ID | 20220303075314.22502-1-xhao@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/damon/sysfs: remove repeat container_of() in damon_sysfs_kdamond_release() | expand |
Hi Xin, On Thu, 3 Mar 2022 15:53:14 +0800 Xin Hao <xhao@linux.alibaba.com> wrote: > In damon_sysfs_kdamond_release(), we have use container_of() to get > "kdamond" pointer, so there no need to get it once again. Good catch! Thank you always :) > > Signed-off-by: Xin Hao <xhao@linux.alibaba.com> Reviewed-by: SeongJae Park <sj@kernel.org> Thanks, SJ > --- > mm/damon/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index a4ad6b473b0a..687e7c7e8dea 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -2432,7 +2432,7 @@ static void damon_sysfs_kdamond_release(struct kobject *kobj) > > if (kdamond->damon_ctx) > damon_destroy_ctx(kdamond->damon_ctx); > - kfree(container_of(kobj, struct damon_sysfs_kdamond, kobj)); > + kfree(kdamond); > } > > static struct kobj_attribute damon_sysfs_kdamond_state_attr = > -- > 2.27.0
diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index a4ad6b473b0a..687e7c7e8dea 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -2432,7 +2432,7 @@ static void damon_sysfs_kdamond_release(struct kobject *kobj) if (kdamond->damon_ctx) damon_destroy_ctx(kdamond->damon_ctx); - kfree(container_of(kobj, struct damon_sysfs_kdamond, kobj)); + kfree(kdamond); } static struct kobj_attribute damon_sysfs_kdamond_state_attr =
In damon_sysfs_kdamond_release(), we have use container_of() to get "kdamond" pointer, so there no need to get it once again. Signed-off-by: Xin Hao <xhao@linux.alibaba.com> --- mm/damon/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)