diff mbox series

[1/2] mm: slab: Delete unused SLAB_DEACTIVATED flag

Message ID 20220309145052.219138-2-sxwjean@me.com (mailing list archive)
State New
Headers show
Series Cleanups for slab | expand

Commit Message

Xiongwei Song March 9, 2022, 2:50 p.m. UTC 
From: Xiongwei Song <sxwjean@gmail.com>

Since commit 9855609bde03 ("mm: memcg/slab: use a single set of
kmem_caches for all accounted allocations") deletes all SLAB_DEACTIVATED
users, therefore this flag is not needed any more, let's delete it.

Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
---
 include/linux/slab.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

David Rientjes March 9, 2022, 5:14 p.m. UTC | #1 
On Wed, 9 Mar 2022, sxwjean@me.com wrote:

> From: Xiongwei Song <sxwjean@gmail.com>
> 
> Since commit 9855609bde03 ("mm: memcg/slab: use a single set of
> kmem_caches for all accounted allocations") deletes all SLAB_DEACTIVATED
> users, therefore this flag is not needed any more, let's delete it.
> 
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>

Acked-by: David Rientjes <rientjes@google.com>
Xiongwei Song March 10, 2022, 1:18 a.m. UTC | #2 
On Thu, Mar 10, 2022 at 1:14 AM David Rientjes <rientjes@google.com> wrote:
>
> On Wed, 9 Mar 2022, sxwjean@me.com wrote:
>
> > From: Xiongwei Song <sxwjean@gmail.com>
> >
> > Since commit 9855609bde03 ("mm: memcg/slab: use a single set of
> > kmem_caches for all accounted allocations") deletes all SLAB_DEACTIVATED
> > users, therefore this flag is not needed any more, let's delete it.
> >
> > Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
>
> Acked-by: David Rientjes <rientjes@google.com>

Thank you!
Roman Gushchin March 10, 2022, 1:49 a.m. UTC | #3 
On Wed, Mar 09, 2022 at 10:50:51PM +0800, sxwjean@me.com wrote:
> From: Xiongwei Song <sxwjean@gmail.com>
> 
> Since commit 9855609bde03 ("mm: memcg/slab: use a single set of
> kmem_caches for all accounted allocations") deletes all SLAB_DEACTIVATED
> users, therefore this flag is not needed any more, let's delete it.

Indeed! Thank!

Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
diff mbox series

Patch

diff --git a/include/linux/slab.h b/include/linux/slab.h
index 37bde99b74af..b6b3eed6c7c4 100644
--- a/include/linux/slab.h
+++ b/include/linux/slab.h
@@ -117,9 +117,6 @@ 
 #define SLAB_RECLAIM_ACCOUNT	((slab_flags_t __force)0x00020000U)
 #define SLAB_TEMPORARY		SLAB_RECLAIM_ACCOUNT	/* Objects are short-lived */
 
-/* Slab deactivation flag */
-#define SLAB_DEACTIVATED	((slab_flags_t __force)0x10000000U)
-
 /*
  * ZERO_SIZE_PTR will be returned for zero sized kmalloc requests.
  *