| Message ID | 20220322121338.27428-1-liqiong@nfschina.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: remove unnecessary (void*) conversions. | expand |
On Tue, Mar 22, 2022 at 08:13:38PM +0800, liqiong wrote: > No need cast (void*) to (struct hwp_walk*). > > Signed-off-by: liqiong <liqiong@nfschina.com> Thank you for sending the patch, looks good to me. Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com> > --- > mm/memory-failure.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 97a9ed8f87a9..4ed0dcf03659 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -630,7 +630,7 @@ static int check_hwpoisoned_pmd_entry(pmd_t *pmdp, unsigned long addr, > static int hwpoison_pte_range(pmd_t *pmdp, unsigned long addr, > unsigned long end, struct mm_walk *walk) > { > - struct hwp_walk *hwp = (struct hwp_walk *)walk->private; > + struct hwp_walk *hwp = walk->private; > int ret = 0; > pte_t *ptep, *mapped_pte; > spinlock_t *ptl; > @@ -664,7 +664,7 @@ static int hwpoison_hugetlb_range(pte_t *ptep, unsigned long hmask, > unsigned long addr, unsigned long end, > struct mm_walk *walk) > { > - struct hwp_walk *hwp = (struct hwp_walk *)walk->private; > + struct hwp_walk *hwp = walk->private; > pte_t pte = huge_ptep_get(ptep); > struct hstate *h = hstate_vma(walk->vma); > > -- > 2.11.0
On Tue, Mar 22, 2022 at 8:14 PM liqiong <liqiong@nfschina.com> wrote: > > No need cast (void*) to (struct hwp_walk*). > > Signed-off-by: liqiong <liqiong@nfschina.com> Reviewed-by: Muchun Song <songmuchun@bytedance.com> Thanks.
diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 97a9ed8f87a9..4ed0dcf03659 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -630,7 +630,7 @@ static int check_hwpoisoned_pmd_entry(pmd_t *pmdp, unsigned long addr, static int hwpoison_pte_range(pmd_t *pmdp, unsigned long addr, unsigned long end, struct mm_walk *walk) { - struct hwp_walk *hwp = (struct hwp_walk *)walk->private; + struct hwp_walk *hwp = walk->private; int ret = 0; pte_t *ptep, *mapped_pte; spinlock_t *ptl; @@ -664,7 +664,7 @@ static int hwpoison_hugetlb_range(pte_t *ptep, unsigned long hmask, unsigned long addr, unsigned long end, struct mm_walk *walk) { - struct hwp_walk *hwp = (struct hwp_walk *)walk->private; + struct hwp_walk *hwp = walk->private; pte_t pte = huge_ptep_get(ptep); struct hstate *h = hstate_vma(walk->vma);
No need cast (void*) to (struct hwp_walk*). Signed-off-by: liqiong <liqiong@nfschina.com> --- mm/memory-failure.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)