From patchwork Tue Mar 22 21:40:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 12789076 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B17C433EF for ; Tue, 22 Mar 2022 21:40:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 985D06B0075; Tue, 22 Mar 2022 17:40:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9344A6B0093; Tue, 22 Mar 2022 17:40:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D35F6B0099; Tue, 22 Mar 2022 17:40:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 68AC86B0075 for ; Tue, 22 Mar 2022 17:40:16 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 205C0182751AD for ; Tue, 22 Mar 2022 21:40:16 +0000 (UTC) X-FDA: 79273340832.19.17E3F14 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id A8F1F40027 for ; Tue, 22 Mar 2022 21:40:15 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C73B60A1C; Tue, 22 Mar 2022 21:40:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76B14C340EE; Tue, 22 Mar 2022 21:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1647985214; bh=HxZoLzTj6RCg+j3ovTGgyoE0bXf5C530MJKDVUt8Zm4=; h=Date:To:From:In-Reply-To:Subject:From; b=xqVDj6fhSnn0Xf78q0BhffN8zlovUFJSZBbIjFb7NBmC01d0DNciDXPGEK2aOsSKc 0X/EI/gV63RNlxPo9Z8IokP3nMJS5FJG8yMkPETTbz+QC8Zgbg2lz/PWl9QmmkV5P/ SMv3Yd4VJ2HgYnVzt4/G8KOuTolMyhOacdgowlLI= Date: Tue, 22 Mar 2022 14:40:13 -0700 To: vdavydov.dev@gmail.com,vbabka@suse.cz,surenb@google.com,songmuchun@bytedance.com,shy828301@gmail.com,shakeelb@google.com,rppt@linux.ibm.com,roman.gushchin@linux.dev,mhocko@suse.com,hannes@cmpxchg.org,guro@fb.com,richard.weiyang@gmail.com,akpm@linux-foundation.org,patches@lists.linux.dev,linux-mm@kvack.org,mm-commits@vger.kernel.org,torvalds@linux-foundation.org,akpm@linux-foundation.org From: Andrew Morton In-Reply-To: <20220322143803.04a5e59a07e48284f196a2f9@linux-foundation.org> Subject: [patch 034/227] mm/memcg: mem_cgroup_per_node is already set to 0 on allocation Message-Id: <20220322214014.76B14C340EE@smtp.kernel.org> X-Stat-Signature: dww6scstj3hs3cnt43xp3jg3qy4ukgor Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xqVDj6fh; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A8F1F40027 X-HE-Tag: 1647985215-854392 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Wei Yang Subject: mm/memcg: mem_cgroup_per_node is already set to 0 on allocation kzalloc_node() would set data to 0, so it's not necessary to set it again. Link: https://lkml.kernel.org/r/20220201004643.8391-1-richard.weiyang@gmail.com Signed-off-by: Wei Yang Reviewed-by: Muchun Song Acked-by: Michal Hocko Reviewed-by: Roman Gushchin Reviewed-by: Mike Rapoport Reviewed-by: Shakeel Butt Cc: Roman Gushchin Cc: Johannes Weiner Cc: Suren Baghdasaryan Cc: Vladimir Davydov Cc: Vlastimil Babka Cc: Yang Shi Signed-off-by: Andrew Morton --- mm/memcontrol.c | 2 -- 1 file changed, 2 deletions(-) --- a/mm/memcontrol.c~mm-memcg-mem_cgroup_per_node-is-already-set-to-0-on-allocation +++ a/mm/memcontrol.c @@ -5105,8 +5105,6 @@ static int alloc_mem_cgroup_per_node_inf } lruvec_init(&pn->lruvec); - pn->usage_in_excess = 0; - pn->on_tree = false; pn->memcg = memcg; memcg->nodeinfo[node] = pn;