From patchwork Tue Mar 22 21:47:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 12789256 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E1B2C433F5 for ; Tue, 22 Mar 2022 21:47:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 339A06B017C; Tue, 22 Mar 2022 17:47:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EA546B017D; Tue, 22 Mar 2022 17:47:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B3A06B017E; Tue, 22 Mar 2022 17:47:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 0C66B6B017C for ; Tue, 22 Mar 2022 17:47:20 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D652120E55 for ; Tue, 22 Mar 2022 21:47:19 +0000 (UTC) X-FDA: 79273358598.12.F0C86A0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf22.hostedemail.com (Postfix) with ESMTP id 36B18C002A for ; Tue, 22 Mar 2022 21:47:19 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 16BE5B81D5F; Tue, 22 Mar 2022 21:47:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3A08C340EE; Tue, 22 Mar 2022 21:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1647985636; bh=oA4q3srNS/ASuTBwak4bUqiug5XtLMt68SKmOkdl8i4=; h=Date:To:From:In-Reply-To:Subject:From; b=Wo44jk+vm0zF9tiavGanLr5WOG8Qu0sq75BXDge9LOmIiDgXT8tzQQGWTVw8uvstG nyuJzpHjyyBh3cG6evli3VUWREJFJ5jP1FpO48H1eDH9IMYNzI7nOJudAQrQlUAf5t Uq4nbxioeSVMmu+f2bmsA0FYBZfJ7mL0sc8P4u48= Date: Tue, 22 Mar 2022 14:47:16 -0700 To: david@redhat.com,linmiaohe@huawei.com,akpm@linux-foundation.org,patches@lists.linux.dev,linux-mm@kvack.org,mm-commits@vger.kernel.org,torvalds@linux-foundation.org,akpm@linux-foundation.org From: Andrew Morton In-Reply-To: <20220322143803.04a5e59a07e48284f196a2f9@linux-foundation.org> Subject: [patch 172/227] mm/memory_hotplug: remove obsolete comment of __add_pages Message-Id: <20220322214716.C3A08C340EE@smtp.kernel.org> X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Wo44jk+v; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 36B18C002A X-Stat-Signature: 7dfatx5uay6aieea65fo4b3xwtiijaso X-HE-Tag: 1647985639-531532 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Miaohe Lin Subject: mm/memory_hotplug: remove obsolete comment of __add_pages Patch series "A few cleanup patches around memory_hotplug". This series contains a few patches to fix obsolete and misplaced comments, clean up the try_offline_node function and so on. This patch (of 4): Since commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded memory to zones until online"), there is no need to pass in the zone. [akpm@linux-foundation.org: remove the comment altogether, per David] Link: https://lkml.kernel.org/r/20220207133643.23427-1-linmiaohe@huawei.com Link: https://lkml.kernel.org/r/20220207133643.23427-2-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Cc: David Hildenbrand Signed-off-by: Andrew Morton --- mm/memory_hotplug.c | 6 ------ 1 file changed, 6 deletions(-) --- a/mm/memory_hotplug.c~mm-memory_hotplug-remove-obsolete-comment-of-__add_pages +++ a/mm/memory_hotplug.c @@ -295,12 +295,6 @@ struct page *pfn_to_online_page(unsigned } EXPORT_SYMBOL_GPL(pfn_to_online_page); -/* - * Reasonably generic function for adding memory. It is - * expected that archs that support memory hotplug will - * call this function after deciding the zone to which to - * add the new pages. - */ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages, struct mhp_params *params) {