From patchwork Tue Apr 26 15:06:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liam R. Howlett" X-Patchwork-Id: 12827392 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D847FC433F5 for ; Tue, 26 Apr 2022 15:07:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C35B16B00AF; Tue, 26 Apr 2022 11:07:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC0686B00B0; Tue, 26 Apr 2022 11:07:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 927BE6B00B2; Tue, 26 Apr 2022 11:07:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 7B0556B00AF for ; Tue, 26 Apr 2022 11:07:33 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 457C260D27 for ; Tue, 26 Apr 2022 15:07:33 +0000 (UTC) X-FDA: 79399359186.20.B305053 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf05.hostedemail.com (Postfix) with ESMTP id 13AB0100053 for ; Tue, 26 Apr 2022 15:07:25 +0000 (UTC) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23QDSuSh018608; Tue, 26 Apr 2022 15:07:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=XASC8R938XZ5zv4dXTHdr1y+ObQbBhIQ6mqRknjeR7o=; b=sFUKtZIiZLh3OTfIlS+6O2erP/2E0MlGZCiNbDxVGjv6nmkoZn8bmHSquo5aptPL9xA4 Wty56bE8mK9Zqwtwq6BaDFylls+xDLmgX78DJRIv8/tyYJ6amPr3BqPB2VsEMOhjZJZS 21p2orbekHtOfMz8aKFY3NGqahy7A2Ej6Q5YCLubGDpc2FeqQ4NNCOGudTwWqqTQ0SCr fh2i4fuyHrpF8iK+A57cXNN1ql++6DqDZgferPM9cV3U1ZPqKQvPpCMiyW4YBAyesO9K IrEX0Q6yKR/29NPnDzEv5J5kMsJe+Sat790ni481acS5jiiGPPiA/7JYXB5dAcHUpXK9 qA== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fmb5jxej3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Apr 2022 15:07:30 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 23QF5554019202; Tue, 26 Apr 2022 15:07:30 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3fm7w3ff1x-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Apr 2022 15:07:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KrCK1Z7nfd4Kp0yGEWTc6wCT39XCMuFxSt2DgGxWHjdY9c76n575P9MKE6gsQ6W6rvnRrdKtGEVhfFjUwJ3sMhchw1pEYViWnSSwwhT/6zcElCFcE7nL0y/ZmFfllSdnHx3Yn+Et4pgVpVeXaFOVGMRGwQ4BaHPfr7z1GFg8A28CIkMcyT8ytS3AEyVVXkhRMd6sf1ccOOgxTI1Zk1JS2A0FHToT5h+XXY/LVpx57IaisY+AMkW8c7wBcj7zfeRHbP7gtbbKlSy+61sss5AcdWXlKxttPDAsPvoWVacLrIt+oMmCXgPiP8Mt3hD2NLnTvbziic0bD8q+W7NuY3nD4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XASC8R938XZ5zv4dXTHdr1y+ObQbBhIQ6mqRknjeR7o=; b=dnNYG5iiB7Y63WrurxcR+gpmOx0Zge09JsE3wqnhqM+mL45Ycx8cSbIq9F6i0j+c34HqgguS6IRn8WUAqag+ivml9vaNFTka2k+BQk5vDRmskTGU5EDan9XsyS087n/baMnEr5J7vz+BQzicRBA069B5jPXJMj3sAlyYsZ7FXi1/ZzTVJMWr5eRXF5eDB+DgDc2guoKtNUsFevAayxbDSyCsCAiGX3m0d4qtS0pe8CJwwYEBur+QF1wYk87B4D86yw3Zi3fuyY8abO9++rPcTh0faJE+8YrH4QWZEWFgd6T+mh3AmmzW2+WcxSBnjXquwPrdIK+Lwa1vLygQue0ZAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XASC8R938XZ5zv4dXTHdr1y+ObQbBhIQ6mqRknjeR7o=; b=soFzXzylXLyVHlg5/xfqURD+qLfIPeb2OqTBYP8yeQU+mQJY/OZsXuxFbRT3EG47fFcUtPVHmM8q3EDwXO7vkCLEcvCxJAz5/AHg3sn5wf+sdMHfYKjI/kCZfLPTu7Q5gnBAd+uAXu4qST8kbhvjZFHkYfGQlSVRBkH0COSJGsA= Received: from SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) by BL0PR10MB2929.namprd10.prod.outlook.com (2603:10b6:208:7a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 26 Apr 2022 15:07:28 +0000 Received: from SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::318c:d02:2280:c2c]) by SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::318c:d02:2280:c2c%7]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022 15:07:28 +0000 From: Liam Howlett To: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Yu Zhao Subject: [PATCH v8 48/70] perf: use VMA iterator Thread-Topic: [PATCH v8 48/70] perf: use VMA iterator Thread-Index: AQHYWX8+PUgnqgSfskCaxxMmPWSybA== Date: Tue, 26 Apr 2022 15:06:45 +0000 Message-ID: <20220426150616.3937571-49-Liam.Howlett@oracle.com> References: <20220426150616.3937571-1-Liam.Howlett@oracle.com> In-Reply-To: <20220426150616.3937571-1-Liam.Howlett@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.35.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8cf19776-1d9e-4cd3-85e4-08da27967ab7 x-ms-traffictypediagnostic: BL0PR10MB2929:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N3nz/E5XWWiTxP3jzWPutmt+Rod2+ANyxHyUkrhI9CDxlaQ7bAAfgB9r4DWisN6bgbzdinDRdYBvgIM/D+82KLt2WH7hBGikb9swZwsumLMstqG2ZsNlcUCc4MjiulPFqjEcasfMglL5qH/sTplJQWvW1OyPSGoQjCSUYkPw2u7kgulTXtdGFOsOIIGnveiDCGm/JBXHAYKx0iMK9BVKGpfV/PYNi0sCOa859ot35rAZEInUgrC688CQ7zl93Rzw4dT3NOkQeml88W7pns9ZyLJF8SjJfn05is5hrAtU5dbY9kkGv/r9gvrkjyJcduId4zsF3QbMsydd5j7tyv2rj/Sa4SiPtxNrRKFirJnp5RX3++gM8Qgv1A+e89+jGUZRj/uRP7RDFmHDTh0FnDd+coZFu8YEPXLAytrwm1b++1zXtPAlH+xHO59fC7zjhmLnSW22oubujnvgq7gI/0+bzlBVmFLdJjEjCSZ5/FQkdDVwU8gPHQiO+IMsBE3o8PSgdM850LZkZcKR81QgsPGTphdCacA/B68qY66xEZ04ScZM4uZUSPH+/rORRtsyQtu3JiBF70p9ezYE/+vdZMA783e6LMgJxzYUSr/3IHxCxTdNeLnnznEOtVhG9S6k0Xsd3SloBVqyq443Wak2WbHyDM5bbqFzH6mQyfhpAgyZyg4BWnrJh2u38eW94+PsiL2g19suOHgWTjyHpJn5W+fmyg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR10MB3022.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(86362001)(44832011)(6666004)(6512007)(2616005)(5660300002)(38070700005)(2906002)(122000001)(38100700002)(83380400001)(76116006)(91956017)(1076003)(110136005)(316002)(26005)(186003)(8936002)(64756008)(66556008)(66446008)(8676002)(66946007)(66476007)(6486002)(508600001)(36756003)(71200400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?KmMFCdiNNNlVM88RlnI/fQz?= =?iso-8859-1?q?iMw3T44oyTh9EVUY5vWXRN9JIh4TnBfMT1QEjpAFtoS1M/5mP7vFjIo74+P4?= =?iso-8859-1?q?sB5cOk8Mf4tobw84Z5c29fgnTMvaPHUl3PYw4eBIxgO4+w52FKPlpTqpAZvH?= =?iso-8859-1?q?b+J8/iFpqA47wfBCYAb26uIxiWR53EsOuBnFSCqswAcX6QIkWZA0dWnbjLkz?= =?iso-8859-1?q?RCCZZoXk+WUIvBpyebYVFzEMLFZm8xkdgIQkLDJoi2EY2ay0UNQZP3bZqai/?= =?iso-8859-1?q?JjRSP6K/0i514OM56unv15cQCIH8/q/PPAEeOX2wx04OfxdtBMMFgbOeqK1M?= =?iso-8859-1?q?BSGzrSgTMUvvrknymFxvXwG+V2sTQP4/AZgNoz3yIsuhdiUKn300Lw+YPU5y?= =?iso-8859-1?q?dg1ZzkqIm2Q7vAbCwt8LqfEsYXQaeR/DGIHllXG5tBz/npUZLUfzWmFQjT87?= =?iso-8859-1?q?cprcXjOTe7PV/U97Jc1KTOyf9DUsVlMg4/4GYav96O0zhtpkDK8S+VSvxTbl?= =?iso-8859-1?q?9KxKFgRurjmXUzVOLUh2mPRzj9Umwk3uyu6ITmr1pgoilhF1DcckHg6Cf6RN?= =?iso-8859-1?q?1wOEBZwrGLxOu9nTfO/0WOhGs4naGQlhrI3Ngg0hrQ1qTYD5LmYBqm3QnUYi?= =?iso-8859-1?q?42hVlnSeHm38Uz+aIV09qjpnJlODwe5508bqxxJ/g4x1SPiE8VglxD0134s+?= =?iso-8859-1?q?6SN8gHfVUuK3rbth0b+88MkIof+zmZO1kbZ2qovRgJqAzEFpuQf8/ZIJJqci?= =?iso-8859-1?q?de6vobiJoPwP0YSzSkQX8lrEtlXyV+J2J6JxnchUpd5QxrBXpuYwxl8bEgyB?= =?iso-8859-1?q?ixMNoSknn6Gixl1cu5exmd0kmX1VDBjeudyCoTW5R+05hwVxN4CHPsFZQoV7?= =?iso-8859-1?q?baWlN7IQzkcLIKVIagJEIou60iNv4K49V9bh0xx1MNvJVPqcCbWFa79aMzXF?= =?iso-8859-1?q?wuNbad0c7ippgtlNg6jB298dP+u4o99r3ZgB+0J42O96Q7rR2vCAGvZcFE3N?= =?iso-8859-1?q?6IYJzSBiOO4r3cJL9BlcnhWjQIRglr3GVaQugcfgMCA8FmC/c21rdHJfAEE6?= =?iso-8859-1?q?zqVuTG7N9T8esdbrRNqZJdLW+RcKi/Gy+zjPy2m4Ep5ITx/uoaUSkMZXStBl?= =?iso-8859-1?q?Uxwl3uP8A3Ya0GCjhqGNX4gMI4tlZqTrJY8ERqAQQp3ezz7ZlA671Tvup8jl?= =?iso-8859-1?q?ZLyQbQlapf/kSfXinUgjLw5bzJVb2ZGbYc+IxZDjPb8khDNgvGRWxi1cbDu2?= =?iso-8859-1?q?Q7bPYnfW6w+8M0k1QjdxPZeNXd6DK1x/YsCz8Svb9JnekjJtGoUzqCwdydjw?= =?iso-8859-1?q?onjsyUvT4ZzJ4gH1B+wb0FM2+Cf3Brdvr6CDPJaxpTrrNsLeoKu44XSQ/nj2?= =?iso-8859-1?q?Ui31x6ZvYh6dECK5rfApkopPuik20UmWLbrbIuB8kUBFAAyslf6U4q9DKQTo?= =?iso-8859-1?q?4otFGnAEIkTZgmdTQjICmjJJfOXeOMS73+P2ntOg4aF9PgTA1rLGjdmFEZ7g?= =?iso-8859-1?q?A4OSwsHsYLGLTXLI68xa1o8xv8zc1iXQmbiExDtH38Nm0IKgax4Lo8cOj6Ml?= =?iso-8859-1?q?Wa32SnUOgHTp2b/YMSE+k2r2JNpec5TmPfdR09F29vPmsWQ8sDBTI05mgLA9?= =?iso-8859-1?q?yFAaW54KmQqzh7Zrg9p0IOEI+5pyoqDIK78VKTU/91GEXvsmo4ckDrjA6UXv?= =?iso-8859-1?q?O1g8LNBR7uhgdruXrgj+SA1kt2VlHa3Ls5gllglCGh6FGxytyhobn8Rwpr1K?= =?iso-8859-1?q?zUf4y8Y32BuB9jHvjXOnhfICoYg0/W7x6BpaWAMUtPwtDckpy8yZTmZ4n3tD?= =?iso-8859-1?q?bgTBzkVE=3D?= MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cf19776-1d9e-4cd3-85e4-08da27967ab7 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2022 15:06:45.7550 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JhVqjSpcVXgtFHfigu9tUqkjYL1g+3dvRxINjr4Oc2lSNckEQS04CQYmIRItxVx+K2P1qsDdAp06E2aVZrpJCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2929 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-04-26_04:2022-04-26,2022-04-26 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204260096 X-Proofpoint-GUID: mwRo29COK5RbsU3iHAOFPiyHHHaW8DCt X-Proofpoint-ORIG-GUID: mwRo29COK5RbsU3iHAOFPiyHHHaW8DCt X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 13AB0100053 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=sFUKtZIi; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=soFzXzyl; spf=none (imf05.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspam-User: X-Stat-Signature: xtoapwbkuo4ybwbdf5rs6b6979i6u9x5 X-HE-Tag: 1650985645-728342 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" The VMA iterator is faster than the linked list and removing the linked list will shrink the vm_area_struct. Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: Liam R. Howlett Acked-by: Vlastimil Babka --- kernel/events/core.c | 3 ++- kernel/events/uprobes.c | 9 ++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 23bb19716ad3..b20b14d8dba7 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -10211,8 +10211,9 @@ static void perf_addr_filter_apply(struct perf_addr_filter *filter, struct perf_addr_filter_range *fr) { struct vm_area_struct *vma; + VMA_ITERATOR(vmi, mm, 0); - for (vma = mm->mmap; vma; vma = vma->vm_next) { + for_each_vma(vmi, vma) { if (!vma->vm_file) continue; diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 4ef5385815d3..c3b2f695cc74 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -349,9 +349,10 @@ static bool valid_ref_ctr_vma(struct uprobe *uprobe, static struct vm_area_struct * find_ref_ctr_vma(struct uprobe *uprobe, struct mm_struct *mm) { + VMA_ITERATOR(vmi, mm, 0); struct vm_area_struct *tmp; - for (tmp = mm->mmap; tmp; tmp = tmp->vm_next) + for_each_vma(vmi, tmp) if (valid_ref_ctr_vma(uprobe, tmp)) return tmp; @@ -1230,11 +1231,12 @@ int uprobe_apply(struct inode *inode, loff_t offset, static int unapply_uprobe(struct uprobe *uprobe, struct mm_struct *mm) { + VMA_ITERATOR(vmi, mm, 0); struct vm_area_struct *vma; int err = 0; mmap_read_lock(mm); - for (vma = mm->mmap; vma; vma = vma->vm_next) { + for_each_vma(vmi, vma) { unsigned long vaddr; loff_t offset; @@ -1982,9 +1984,10 @@ bool uprobe_deny_signal(void) static void mmf_recalc_uprobes(struct mm_struct *mm) { + VMA_ITERATOR(vmi, mm, 0); struct vm_area_struct *vma; - for (vma = mm->mmap; vma; vma = vma->vm_next) { + for_each_vma(vmi, vma) { if (!valid_vma(vma, false)) continue; /*