| Message ID | 20220426231750.48822-3-sj@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | support fixed virtual address ranges monitoring | expand |
Hi, SeongJae I had read and tested your patchset these days. It works. It seems that these patches only fix the issue about init_regions in DAMON-sysfs, but not fix in DAMON-dbgfs? maybe I missing something. If so, do you have any plan to fix this bug in dbgfs? Actually, what I want to say is that I ready a patch for solving the init_regions related bug in dbgfs these days. I not sure if you're interested in it. Best Regards, Rongwei On 4/27/22 7:17 AM, sj@kernel.org wrote: > From: SeongJae Park <sj@kernel.org> > > This commit makes DAMON sysfs interface to support the fixed virtual > address ranges monitoring. After this commit, writing 'fvaddr' to the > 'operations' DAMON sysfs file makes DAMON uses the monitoring operations > set for fixed virtual address ranges, so that users can monitor accesses > to only interested virtual address ranges. > > Signed-off-by: SeongJae Park <sj@kernel.org> > --- > mm/damon/sysfs.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index 719a286d378f..767ab8c33e4d 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -1694,7 +1694,7 @@ static struct kobj_type damon_sysfs_attrs_ktype = { > /* This should match with enum damon_ops_id */ > static const char * const damon_sysfs_ops_strs[] = { > "vaddr", > - "unsupported", /* fvaddr is not supported by sysfs yet */ > + "fvaddr", > "paddr", > }; > > @@ -1844,9 +1844,6 @@ static ssize_t operations_store(struct kobject *kobj, > > for (id = 0; id < NR_DAMON_OPS; id++) { > if (sysfs_streq(buf, damon_sysfs_ops_strs[id])) { > - /* fvaddr is not supported by sysfs yet */ > - if (id == DAMON_OPS_FVADDR) > - return -EINVAL; > context->ops_id = id; > return count; > } > @@ -2136,7 +2133,8 @@ static int damon_sysfs_set_targets(struct damon_ctx *ctx, > damon_sysfs_destroy_targets(ctx); > return -ENOMEM; > } > - if (ctx->ops.id == DAMON_OPS_VADDR) { > + if (ctx->ops.id == DAMON_OPS_VADDR || > + ctx->ops.id == DAMON_OPS_FVADDR) { > t->pid = find_get_pid(sys_target->pid); > if (!t->pid) { > damon_sysfs_destroy_targets(ctx);
Hi Rongwei, On Mon, 2 May 2022 15:56:58 +0800 Rongwei Wang <rongwei.wang@linux.alibaba.com> wrote: > Hi, SeongJae > > I had read and tested your patchset these days. It works. Thank you for the tests! :D > It seems that these patches only fix the issue about init_regions in > DAMON-sysfs, but not fix in DAMON-dbgfs? maybe I missing something. > > If so, do you have any plan to fix this bug in dbgfs? Actually, what I > want to say is that I ready a patch for solving the init_regions related > bug in dbgfs these days. I not sure if you're interested in it. The plan is to freeze DAMON debugfs interface after DAMON sysfs interface is merged, and then entirely remove it after next LTS kernel. It was mentioned in the sysfs interface patchset as below: https://lore.kernel.org/linux-mm/20220228081314.5770-1-sj@kernel.org/ Future Plan of DAMON_DBGFS Deprecation ====================================== Once this patchset is merged, DAMON_DBGFS development will be frozen. That is, we will maintain it to work as is now so that no users will be break. But, it will not be extended to provide any new feature of DAMON. The support will be continued only until next LTS release. After that, we will drop DAMON_DBGFS. The plan was also shared in the kernel doc as below[1], but maybe it was too small to read, or ambiguous. Sorry if it was the case. debugfs interface. This is almost identical to sysfs interface. This will be _removed_ after next LTS kernel is released, so users should move to the sysfs interface. [1] https://docs.kernel.org/admin-guide/mm/damon/usage.html#debugfs-interface So, I don't have a big interest at extending DAMON debugfs for fvaddr. That said, of course we could discuss more if you really need it. If so, please let me know. Thanks, SJ > > Best Regards, > Rongwei >
On 5/3/22 12:18 AM, SeongJae Park wrote: > Hi Rongwei, > > On Mon, 2 May 2022 15:56:58 +0800 Rongwei Wang <rongwei.wang@linux.alibaba.com> wrote: > >> Hi, SeongJae >> >> I had read and tested your patchset these days. It works. > > Thank you for the tests! :D > >> It seems that these patches only fix the issue about init_regions in >> DAMON-sysfs, but not fix in DAMON-dbgfs? maybe I missing something. >> >> If so, do you have any plan to fix this bug in dbgfs? Actually, what I >> want to say is that I ready a patch for solving the init_regions related >> bug in dbgfs these days. I not sure if you're interested in it. > > The plan is to freeze DAMON debugfs interface after DAMON sysfs interface is > merged, and then entirely remove it after next LTS kernel. It was mentioned in > the sysfs interface patchset as below: > https://lore.kernel.org/linux-mm/20220228081314.5770-1-sj@kernel.org/ > > Future Plan of DAMON_DBGFS Deprecation > ====================================== > > Once this patchset is merged, DAMON_DBGFS development will be frozen. That is, > we will maintain it to work as is now so that no users will be break. But, it > will not be extended to provide any new feature of DAMON. The support will be > continued only until next LTS release. After that, we will drop DAMON_DBGFS. > > The plan was also shared in the kernel doc as below[1], but maybe it was too > small to read, or ambiguous. Sorry if it was the case. > > debugfs interface. This is almost identical to sysfs interface. This will > be _removed_ after next LTS kernel is released, so users should move to the > sysfs interface. Hi, SeongJae Thanks, for telling me the doc! It seems that I have to update my datop. New sysfs interface has changed too much. Anyway, Thanks! :) > > [1] https://docs.kernel.org/admin-guide/mm/damon/usage.html#debugfs-interface > > So, I don't have a big interest at extending DAMON debugfs for fvaddr. That > said, of course we could discuss more if you really need it. If so, please let > me know. > > > Thanks, > SJ > >> >> Best Regards, >> Rongwei >>
diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 719a286d378f..767ab8c33e4d 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1694,7 +1694,7 @@ static struct kobj_type damon_sysfs_attrs_ktype = { /* This should match with enum damon_ops_id */ static const char * const damon_sysfs_ops_strs[] = { "vaddr", - "unsupported", /* fvaddr is not supported by sysfs yet */ + "fvaddr", "paddr", }; @@ -1844,9 +1844,6 @@ static ssize_t operations_store(struct kobject *kobj, for (id = 0; id < NR_DAMON_OPS; id++) { if (sysfs_streq(buf, damon_sysfs_ops_strs[id])) { - /* fvaddr is not supported by sysfs yet */ - if (id == DAMON_OPS_FVADDR) - return -EINVAL; context->ops_id = id; return count; } @@ -2136,7 +2133,8 @@ static int damon_sysfs_set_targets(struct damon_ctx *ctx, damon_sysfs_destroy_targets(ctx); return -ENOMEM; } - if (ctx->ops.id == DAMON_OPS_VADDR) { + if (ctx->ops.id == DAMON_OPS_VADDR || + ctx->ops.id == DAMON_OPS_FVADDR) { t->pid = find_get_pid(sys_target->pid); if (!t->pid) { damon_sysfs_destroy_targets(ctx);