| Message ID | 20220428033319.239341-5-gerg@linux-m68k.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | m68knommu: add support for elf-fdpic | expand |
Hi Greg, On Thu, Apr 28, 2022 at 7:05 AM Greg Ungerer <gerg@linux-m68k.org> wrote: > The m68k architecture code is capable of supporting the binfmt_elf_fdpic > loader, so allow it to be configured. It is restricted to nommu > configurations at this time due to the MMU context structures/code not > supporting everything elf_fdpic needs when MMU is enabled. > > Signed-off-by: Greg Ungerer <gerg@linux-m68k.org> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- a/fs/Kconfig.binfmt > +++ b/fs/Kconfig.binfmt > @@ -58,7 +58,7 @@ config ARCH_USE_GNU_PROPERTY > config BINFMT_ELF_FDPIC > bool "Kernel support for FDPIC ELF binaries" > default y if !BINFMT_ELF > - depends on (ARM || (SUPERH && !MMU)) > + depends on (ARM || ((M68K || SUPERH) && !MMU)) While at it, you may want to drop the unneeded outer parentheses, as they make the expression harder to round, IMHO. > select ELFCORE > help > ELF FDPIC binaries are based on ELF, but allow the individual load Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On 28/4/22 17:20, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Apr 28, 2022 at 7:05 AM Greg Ungerer <gerg@linux-m68k.org> wrote: >> The m68k architecture code is capable of supporting the binfmt_elf_fdpic >> loader, so allow it to be configured. It is restricted to nommu >> configurations at this time due to the MMU context structures/code not >> supporting everything elf_fdpic needs when MMU is enabled. >> >> Signed-off-by: Greg Ungerer <gerg@linux-m68k.org> > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> > >> --- a/fs/Kconfig.binfmt >> +++ b/fs/Kconfig.binfmt >> @@ -58,7 +58,7 @@ config ARCH_USE_GNU_PROPERTY >> config BINFMT_ELF_FDPIC >> bool "Kernel support for FDPIC ELF binaries" >> default y if !BINFMT_ELF >> - depends on (ARM || (SUPERH && !MMU)) >> + depends on (ARM || ((M68K || SUPERH) && !MMU)) > > While at it, you may want to drop the unneeded outer parentheses, > as they make the expression harder to round, IMHO. Sure thing, will do, Regards Greg >> select ELFCORE >> help >> ELF FDPIC binaries are based on ELF, but allow the individual load > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/fs/Kconfig.binfmt b/fs/Kconfig.binfmt index 21c6332fa785..2666398120c4 100644 --- a/fs/Kconfig.binfmt +++ b/fs/Kconfig.binfmt @@ -58,7 +58,7 @@ config ARCH_USE_GNU_PROPERTY config BINFMT_ELF_FDPIC bool "Kernel support for FDPIC ELF binaries" default y if !BINFMT_ELF - depends on (ARM || (SUPERH && !MMU)) + depends on (ARM || ((M68K || SUPERH) && !MMU)) select ELFCORE help ELF FDPIC binaries are based on ELF, but allow the individual load
The m68k architecture code is capable of supporting the binfmt_elf_fdpic loader, so allow it to be configured. It is restricted to nommu configurations at this time due to the MMU context structures/code not supporting everything elf_fdpic needs when MMU is enabled. Signed-off-by: Greg Ungerer <gerg@linux-m68k.org> --- fs/Kconfig.binfmt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)