diff mbox series

[v2,1/2] selftests/damon: suppress compiler warnings for huge_count_read_write

Message ID 20220504000358.1174849-1-yuanchu@google.com (mailing list archive)
State New
Headers show
Series [v2,1/2] selftests/damon: suppress compiler warnings for huge_count_read_write | expand

Commit Message

Yuanchu Xie May 4, 2022, 12:03 a.m. UTC
The test case added in commit db7a347b26fe ("mm/damon/dbgfs:
use '__GFP_NOWARN' for user-specified size buffer allocation")
intentionally writes and reads with a large count to cause
allocation failure and check for kernel warnings. We suppress
the compiler warnings for these calls as they work as intended.

Signed-off-by: Yuanchu Xie <yuanchu@google.com>
---
 tools/testing/selftests/damon/Makefile | 3 +++
 1 file changed, 3 insertions(+)

Comments

SeongJae Park May 4, 2022, 12:11 a.m. UTC | #1
Hi Yuanchu, thank you for this patch!

On Wed, 4 May 2022 00:03:57 +0000 Yuanchu Xie <yuanchu@google.com> wrote:

> The test case added in commit db7a347b26fe ("mm/damon/dbgfs:
> use '__GFP_NOWARN' for user-specified size buffer allocation")
> intentionally writes and reads with a large count to cause
> allocation failure and check for kernel warnings. We suppress
> the compiler warnings for these calls as they work as intended.
> 
> Signed-off-by: Yuanchu Xie <yuanchu@google.com>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]
> ---
>  tools/testing/selftests/damon/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile
> index 0470c5f3e690..a300b4c5b373 100644
> --- a/tools/testing/selftests/damon/Makefile
> +++ b/tools/testing/selftests/damon/Makefile
> @@ -1,6 +1,9 @@
>  # SPDX-License-Identifier: GPL-2.0
>  # Makefile for damon selftests
>  
> +CFLAGS += -Wno-stringop-overread
> +CFLAGS += -Wno-stringop-overflow
> +
>  TEST_GEN_FILES += huge_count_read_write
>  
>  TEST_FILES = _chk_dependency.sh _debugfs_common.sh
> -- 
> 2.36.0.464.gb9c8b46e94-goog
>
diff mbox series

Patch

diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile
index 0470c5f3e690..a300b4c5b373 100644
--- a/tools/testing/selftests/damon/Makefile
+++ b/tools/testing/selftests/damon/Makefile
@@ -1,6 +1,9 @@ 
 # SPDX-License-Identifier: GPL-2.0
 # Makefile for damon selftests
 
+CFLAGS += -Wno-stringop-overread
+CFLAGS += -Wno-stringop-overflow
+
 TEST_GEN_FILES += huge_count_read_write
 
 TEST_FILES = _chk_dependency.sh _debugfs_common.sh