From patchwork Wed May 4 01:13:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liam R. Howlett" X-Patchwork-Id: 12838018 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45492C433F5 for ; Wed, 4 May 2022 14:49:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FD966B0071; Wed, 4 May 2022 10:49:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6860F6B0073; Wed, 4 May 2022 10:49:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B35C6B0074; Wed, 4 May 2022 10:49:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3AF3F6B0071 for ; Wed, 4 May 2022 10:49:07 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0F17A2B083 for ; Wed, 4 May 2022 14:49:07 +0000 (UTC) X-FDA: 79428343134.19.0E25748 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf06.hostedemail.com (Postfix) with ESMTP id 7F64C180094 for ; Wed, 4 May 2022 14:49:04 +0000 (UTC) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 243Li9UZ025194; Wed, 4 May 2022 01:14:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=2aBPMD8xyQDIcseUFq99nGOFIefULKFLFSEoKwAb2iw=; b=Y5q4bYW4b6+MtbroB0a2divG6c01MJ+LkYUc0DsKTjXI7yuDzbCpT1iZMxj273EAeMMz 5HTGAnSMmTbZzdIxNkZf+upRAgH9Zj/TRugToGuWJIXKBQAnHz2oAIdMzpQUw9EGAbkf yCJWXZ90YA/1B8KiOtsOdQqu4alP8VcXGTEVm+nPkf2h2nlDsu6TJ7ZTlFFZj7jZhmjb j+fZN3mpZwmX9KJncyNLkm5A47p7ZQxTdNiVRQm4hohjv+d39YGOaywgYpK32WPq8aFe C5/xRnky320eMPJqMFfhpXT9IJDdWJepDKZDOOgBx3yqs889PriwSYGA/m52qJMtA0uh Mw== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fruw2f6bm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 May 2022 01:14:05 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 2441ArPw020035; Wed, 4 May 2022 01:14:05 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2048.outbound.protection.outlook.com [104.47.66.48]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3fruj922jf-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 May 2022 01:14:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jihK/vJdHI0zYFUJ5lSunjw0/xiIY5jesyumlBfIG/cYJXfa9vegwQ9tzRgWI6E1BOzuqtbxRZMYIL9aL0xxovxhHjtaWnC3cUgjsfKqJY6GhdMovHevCGZH1HbJ+OChCK5RUlhiFK6gqeIIbzK5ZNYiWICaxobEeS+ZcOxZVilXKlXs4t4AAcn5irvjgh23pLsrkuSmNLPw42M4Shz8ya6Du4nS7I2as7VBZr2m7RgZjcKglM6jBe+QNeY55TFvSdniDYniCDxETnv8t5TS9LPlcvKVlnLBEwwNVJqCRCri1mG0bkit/6OmHNeDzux15NmA5A52XjhiR4CLJpn5wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2aBPMD8xyQDIcseUFq99nGOFIefULKFLFSEoKwAb2iw=; b=VHaHBUTlc714Mt3CQIHHROARQYO2BGln3sQMz/3y7mso25ymoW5dddGHoou+EfTc/AcCWfbjGWC2o3lmF+h9naQ9Px/WnOQirHbGHYGXF4l6ovVH0Tt+Z7Ls0TEzmMsDA01BiKz8WNnPaz6fR6TMlXRJ6+Nlj3a1pByB/zCFRTi/eiAFdVLufk0SMsiB290r1JYEmmc78/urEHZhyeqeUmUDDYvMZVr8YUkoYWFGYA+hWP17w3P9ol1LcHr0KiV4oIe7nQFxZQMJ59k16t52w3wBR45cPQr+NvMmmljzMypGz7La/KO67yVUewbL/7ag8aEX+P1GUDZh0mTizvga0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2aBPMD8xyQDIcseUFq99nGOFIefULKFLFSEoKwAb2iw=; b=o0ITxx9xcb/LNHHuljZRe4fR+ZKEKxXF3cLbWyMeHbcZzQFy7hDrii7gRF1DWDEqv4h26ExXOm0Zb1updjNd+Lk5QcG8J9Nqf+Hf51lSmrc+cch14hsKeq7ZjfJLwkctB+ZmVDn3aaeNAsIwWX1KT5SUmA6TFBxBmo8Njon2AyE= Received: from SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) by MN2PR10MB3728.namprd10.prod.outlook.com (2603:10b6:208:115::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 4 May 2022 01:14:01 +0000 Received: from SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::318c:d02:2280:c2c]) by SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::318c:d02:2280:c2c%7]) with mapi id 15.20.5206.024; Wed, 4 May 2022 01:14:01 +0000 From: Liam Howlett To: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: [PATCH v9 41/69] exec: use VMA iterator instead of linked list Thread-Topic: [PATCH v9 41/69] exec: use VMA iterator instead of linked list Thread-Index: AQHYX1Q7LXfSeb614U2YVdRUL4gOFA== Date: Wed, 4 May 2022 01:13:58 +0000 Message-ID: <20220504011345.662299-26-Liam.Howlett@oracle.com> References: <20220504002554.654642-1-Liam.Howlett@oracle.com> <20220504011345.662299-1-Liam.Howlett@oracle.com> In-Reply-To: <20220504011345.662299-1-Liam.Howlett@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.35.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4771184a-cca3-4f98-d409-08da2d6b5f99 x-ms-traffictypediagnostic: MN2PR10MB3728:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EzX7NzeNqr5E1rgV2khCZxLS41KMv8OZzb7EkUKEmhQTq+yl2FYQ5GpohbOCsb1MoPiFhUMEVwXMnB7F2YCrUAPFpEcxvZqxzZAnwp5vKSZN1zDWHG2MFmi2CwmtKYoeszRaVl5vfO3SjjTnwiNzEzPWc+VEiVcgiA0Pbsy29HEQYoi78ufCNlttIZJXhSSuob73v7Qb1RDIx2Kx0CFk0RNJdPyuy8Z/2QWynRDUGzGYJ8zhpUwl9+fi+v5PomvoCr0MN4yeNq4/2q/KUUyKm8gn5+Wp1rHmIUaANmenu4e69mAfMSjcFWCYPrguLxuSjYJ5PkI9iMJIu5TgkaM1PYCOu3IKEIaTm2c+s6guDq5io/+hcvsvt8aH4WSlO/ERk0v73ZaxSOIHgH+OtzSCp2Oq31YfkKWenD4nZcZRL3hlK77OCBE3aJH9Gk8KU7fQt6Jwk/SQqnXe0oGl/jBKdqqnU7p8jR7Y2I94gdJpPtg1qlZ5sZB9bpndSeFfCiDBYN4V/Nx63nBC5qLxQGQbQ+tDrOHbv35dhdeNdOZMuxt2Iq5kl7N6MFhURckVwSXxcJrqDrGoYF24pGZGpX8HZOzbnTnIlSCmE+0lnOBMkMqRlNAXLSy6PDOlR18w3yJ7i6UWsFqvovCO1BSaUGOItlLfleakQD/761Ujhu29XG8SSUGO6wR0Hopsr+P/JlFp+RZOeVRqQNy+DeCB5/Suqg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR10MB3022.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(71200400001)(508600001)(5660300002)(8936002)(6486002)(86362001)(26005)(6506007)(2616005)(6512007)(2906002)(83380400001)(44832011)(186003)(6666004)(66946007)(91956017)(76116006)(110136005)(38100700002)(38070700005)(36756003)(316002)(8676002)(66446008)(66556008)(64756008)(66476007)(122000001)(1076003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?SSTYTQuFcoWy9iEh8aAXwCc?= =?iso-8859-1?q?GR/XdpY1K17K0FvFQVByPP+x3sM0D3C+Jy2nCkWUFzTatWAoNEPh1rVESU7M?= =?iso-8859-1?q?Pf386tVfeDIV734UUMsjmCn/z4Jve45AejNHVl/gB+tSl78RTzmRte/pn7vr?= =?iso-8859-1?q?3dsnY2ss2viKSJ/KMtER9YHrgES4TsFMgAqU3eIEmrVp7jDm5GTDkwphiwtZ?= =?iso-8859-1?q?Li7K8HTppKo8wuiom0diINjPAU8+AgGgvrUp/6XHtHLNsL/X35KXdGskt0lJ?= =?iso-8859-1?q?Kegil/xyeX3QEiqjA3Uf+GZ/Wqw1VsHYZv8Viy6TzuWu0ZAWvg/Hslbck0bW?= =?iso-8859-1?q?ilVGjwHHFn8lC+4RAT9joclQfxW8H2/5Gw9wxtKxwEscnLAvqTtcYOyo8GEX?= =?iso-8859-1?q?X52LFthULDDyK2bsoSkkkEpIwPZ+nk91cD80ZeM07X4/ce9pObLDNRVnwTxB?= =?iso-8859-1?q?rHtyXhvGmJkXY76bgdSNicswnZ8vJFGAQScTiH7rYHO4q7rSqk+YbFwHhdmD?= =?iso-8859-1?q?EeGGFMEg4ZNIyhuMSl2a/LLu6GAYnWvYDL2SVh9F27VuYXXZXszjfiu/ubju?= =?iso-8859-1?q?GbaY90sUkJvd/udjmlMPw5VO2vDbD3OP/7nuUsyuL6djZKTFSNwn04k80agN?= =?iso-8859-1?q?eiL8rAuypRBd4gyHuAWJX+DqSzK/LExPOkfkMMmZy+WfPHw2qSfNQROGwrYX?= =?iso-8859-1?q?jI0VGImftaqdwUi6VrfSdk6nB0TfU2PlkNI8dk92sXenjde3Ihx2iOnInuQx?= =?iso-8859-1?q?k8O1l3ONfzAIh3kH7XNHk+9onuAtRwubzFDKT7glxs8+Xy+M5OnMNVMp7CS7?= =?iso-8859-1?q?GGZ0zxB+nXmyHhYJdTWlmYjVWRc4qiqbdXWkMXHcdiTXC4yDTdPJ+f129DVj?= =?iso-8859-1?q?HsB2oykBu0+SMsVcvlvMy24vaKgY3tEv6i0xWSmgdCBCatNy7mF5xtr9vrI2?= =?iso-8859-1?q?7hknVq/AOJLvNPNJXcvzVo6Twvt/ictepr6tDCClVWDdWFevMfgscLlw+Q6c?= =?iso-8859-1?q?Pvxe/h7O4z08nri5bYof9JWB1XV3DuAnxiF88EsZ97O3QCvUicViaYQDYyoh?= =?iso-8859-1?q?UhlaMAESBI6l+R6uLDThIhaLpUX1js27pcPgfsavh88rZqITNSI4jv6H06Cn?= =?iso-8859-1?q?omowtdKCT336AH+I/RwX8u/kp+EzYUNV38gPJjasTvubcf/LSNXJFBVQZMK2?= =?iso-8859-1?q?qTXwWuETtiudSIgHsjIks+RP9O1KWQrBOkBzmXAefEqLpB86niEI24RZgcfU?= =?iso-8859-1?q?JZ6jHNrK/uqCrQ0YG/imfWXOrMfkTyiZRWzNJoKHu5292b/+s1v7gGZB5vvJ?= =?iso-8859-1?q?MyrFqL6/ptNBUuo0Lre1FKyyoDJlt3GYgVZkWEcg9ZC0YoDhzBiO9uHDYis6?= =?iso-8859-1?q?/VfJLQOb/R6cd12bULjEQTPgh5Qvg15IwrCYaW7xUgSFC9YFCQfTSpPfIaZ7?= =?iso-8859-1?q?+kSo7ihK3DC0RHjsm8elkRuez0gAU3m1wpKepTDUVhZcOkCeo3dvFxhtQGG6?= =?iso-8859-1?q?RAxNbdhq1IH3FIL/vJSCQ3zsEYeZ9OkxVTROY7KYDC6jgHp/L34a6OX4XRyj?= =?iso-8859-1?q?H8FAslLHIbRjwiC2SZuHHBFbU/OGiiC17ccdzut6gJTsHgLPddw0GL+Iz6Px?= =?iso-8859-1?q?bC6kVuklCgC+s+eMg8SsorP2EDUSJoIaiglAAV8gThnVAPD8+7WrqmUqgVaK?= =?iso-8859-1?q?SYnnEepaeCxigm1N5tTOVl1sox+aGZWVDTw4P1R5Pi8zNgyh2+sxITc+zlKj?= =?iso-8859-1?q?bYu5eqfCLr8UTCHfoNzrdm5seSYSnxCrof+dmQyTBj5Wil5g+wIJ/D8nSeVs?= =?iso-8859-1?q?0sCrlF2w=3D?= MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4771184a-cca3-4f98-d409-08da2d6b5f99 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2022 01:13:58.5797 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yx9pxNhgY0Sb50PwXqcWDQU8gOofgto4larBW7hfE/VB1NNj+rVV71DNGV6cxQMSDW41rJWNe+47SQXkJ9j/XA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3728 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-03_10:2022-05-02,2022-05-03 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205040006 X-Proofpoint-GUID: k1f0wEe3Y73DI9pHBr5zN7Oftk4GSbH1 X-Proofpoint-ORIG-GUID: k1f0wEe3Y73DI9pHBr5zN7Oftk4GSbH1 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7F64C180094 X-Stat-Signature: f98e9s8weo9xmatehu1jhsomkknmqo65 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=Y5q4bYW4; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=o0ITxx9x; spf=none (imf06.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-HE-Tag: 1651675744-33761 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" Remove a use of the vm_next list by doing the initial lookup with the VMA iterator and then using it to find the next entry. Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: Liam R. Howlett --- fs/exec.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/exec.c b/fs/exec.c index 14e7278a1ab8..b5e3bfd52b53 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -686,6 +686,8 @@ static int shift_arg_pages(struct vm_area_struct *vma, unsigned long shift) unsigned long length = old_end - old_start; unsigned long new_start = old_start - shift; unsigned long new_end = old_end - shift; + VMA_ITERATOR(vmi, mm, new_start); + struct vm_area_struct *next; struct mmu_gather tlb; BUG_ON(new_start > new_end); @@ -694,7 +696,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, unsigned long shift) * ensure there are no vmas between where we want to go * and where we are */ - if (vma != find_vma(mm, new_start)) + if (vma != vma_next(&vmi)) return -EFAULT; /* @@ -713,12 +715,13 @@ static int shift_arg_pages(struct vm_area_struct *vma, unsigned long shift) lru_add_drain(); tlb_gather_mmu(&tlb, mm); + next = vma_next(&vmi); if (new_end > old_start) { /* * when the old and new regions overlap clear from new_end. */ free_pgd_range(&tlb, new_end, old_end, new_end, - vma->vm_next ? vma->vm_next->vm_start : USER_PGTABLES_CEILING); + next ? next->vm_start : USER_PGTABLES_CEILING); } else { /* * otherwise, clean from old_start; this is done to not touch @@ -727,7 +730,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, unsigned long shift) * for the others its just a little faster. */ free_pgd_range(&tlb, old_start, old_end, new_end, - vma->vm_next ? vma->vm_next->vm_start : USER_PGTABLES_CEILING); + next ? next->vm_start : USER_PGTABLES_CEILING); } tlb_finish_mmu(&tlb);