Message ID | 20220504182857.4013401-15-willy@infradead.org (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA4A8C433FE for <linux-mm@archiver.kernel.org>; Wed, 4 May 2022 18:29:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CDB06B0085; Wed, 4 May 2022 14:29:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABFB66B0081; Wed, 4 May 2022 14:29:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A32D6B0087; Wed, 4 May 2022 14:29:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DF9C26B0098 for <linux-mm@kvack.org>; Wed, 4 May 2022 14:29:06 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 31249215D7 for <linux-mm@kvack.org>; Wed, 4 May 2022 18:29:05 +0000 (UTC) X-FDA: 79428897450.22.0E3E8CE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 6992340079 for <linux-mm@kvack.org>; Wed, 4 May 2022 18:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=2eGvpgCwBgNKMZ/RCFgo9zn6gdnt9R9SMtUMcNvwgyo=; b=dX93gx0+N0Xl0w1JNpPBYCA0P6 1HC6Uqwp+xYtI9I2Mq7ZSyqdqYyQvA2Z9VhogiFAm0ISxOAUQLfkLLcfiO0ywpfhe7OxsZMnYyMAm lb5kbtoDxfiWxc5zVSepRZYhZECM3WXI35sQh890J0sUUtqx6Quv09gRMRfo9SNOXbLZlsFhPh/qg GBYLgf9OHyBicS3p5jWqCyBmgtzcrau5/QOytUsStDWnRL9ypiwCctd1Etlw8hLuJhqOrGN23R1y8 L+Z/OJ6nDQxUY5AJfNdLH3Hjze4t7ZLdaVhREYDD0CaF3A43CojMELgH9CmqGHqvwZ9WuW8+57k2Y m/Or1q3Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmJkF-00Gq7A-8n; Wed, 04 May 2022 18:29:03 +0000 From: "Matthew Wilcox (Oracle)" <willy@infradead.org> To: akpm@linuxfoundation.org, linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> Subject: [PATCH v2 14/26] mm: Allow can_split_folio() to be called when THP are disabled Date: Wed, 4 May 2022 19:28:45 +0100 Message-Id: <20220504182857.4013401-15-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220504182857.4013401-1-willy@infradead.org> References: <20220504182857.4013401-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dX93gx0+; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6992340079 X-Stat-Signature: iab1mpg7bfuitpnxj8gknw7j5jrcp6di X-HE-Tag: 1651688928-846085 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
Folio patches for 5.19
|
expand
|
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 2999190adc22..e9e0d591061d 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -347,7 +347,6 @@ static inline void prep_transhuge_page(struct page *page) {} static inline bool can_split_folio(struct folio *folio, int *pextra_pins) { - BUILD_BUG(); return false; } static inline int
The call to can_split_folio() in vmscan is currently guarded by a test of PageTransHuge() so the BUILD_BUG() is eliminated if THP are disabled. The next patch replaces that test with folio_test_large() which may be true, even when THP are disabled. However, if THP are disabled, we cannot split, so an unconditional return of false is appropriate. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- include/linux/huge_mm.h | 1 - 1 file changed, 1 deletion(-)