diff mbox series

[v2,03/26] alpha: Fix alloc_zeroed_user_highpage_movable()

Message ID	20220504182857.4013401-4-willy@infradead.org (mailing list archive)
State	New
Headers	show Return-Path: <owner-linux-mm@kvack.org> From: "Matthew Wilcox (Oracle)" <willy@infradead.org> To: akpm@linuxfoundation.org, linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>, kernel test robot <lkp@intel.com> Subject: [PATCH v2 03/26] alpha: Fix alloc_zeroed_user_highpage_movable() Date: Wed, 4 May 2022 19:28:34 +0100 Message-Id: <20220504182857.4013401-4-willy@infradead.org> In-Reply-To: <20220504182857.4013401-1-willy@infradead.org> References: <20220504182857.4013401-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	Folio patches for 5.19 \| expand [v2,00/26] Folio patches for 5.19 [v2,01/26] shmem: Convert shmem_alloc_hugepage() to use vma_alloc_folio() [v2,02/26] mm/huge_memory: Convert do_huge_pmd_anonymous_page() to use vma_alloc_folio() [v2,03/26] alpha: Fix alloc_zeroed_user_highpage_movable() [v2,04/26] mm: Remove alloc_pages_vma() [v2,05/26] vmscan: Use folio_mapped() in shrink_page_list() [v2,06/26] vmscan: Convert the writeback handling in shrink_page_list() to folios [v2,07/26] swap: Turn get_swap_page() into folio_alloc_swap() [v2,08/26] swap: Convert add_to_swap() to take a folio [v2,09/26] vmscan: Convert dirty page handling to folios [v2,10/26] vmscan: Convert page buffer handling to use folios [v2,11/26] vmscan: Convert lazy freeing to folios [v2,12/26] vmscan: Move initialisation of mapping down [v2,13/26] vmscan: Convert the activate_locked portion of shrink_page_list to folios [v2,14/26] mm: Allow can_split_folio() to be called when THP are disabled [v2,15/26] vmscan: Remove remaining uses of page in shrink_page_list [v2,16/26] mm/shmem: Use a folio in shmem_unused_huge_shrink [v2,17/26] mm/swap: Add folio_throttle_swaprate [v2,18/26] mm/shmem: Convert shmem_add_to_page_cache to take a folio [v2,19/26] mm/shmem: Turn shmem_should_replace_page into shmem_should_replace_folio [v2,20/26] mm/shmem: Add shmem_alloc_folio() [v2,21/26] mm/shmem: Convert shmem_alloc_and_acct_page to use a folio [v2,22/26] mm/shmem: Convert shmem_getpage_gfp to use a folio [v2,23/26] mm/shmem: Convert shmem_swapin_page() to shmem_swapin_folio() [v2,24/26] mm: Add folio_mapping_flags() [v2,25/26] mm: Add folio_test_movable() [v2,26/26] mm/migrate: Convert move_to_new_page() into move_to_new_folio()

Commit Message

Matthew Wilcox (Oracle) May 4, 2022, 6:28 p.m. UTC

Due to a typo, the final argument to alloc_page_vma() didn't refer to a
real variable.  This only affected CONFIG_NUMA, which was marked BROKEN
in 2006 and removed from alpha in 2021.  Found due to a refactoring patch.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 arch/alpha/include/asm/page.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig May 5, 2022, 3:31 p.m. UTC | #1

On Wed, May 04, 2022 at 07:28:34PM +0100, Matthew Wilcox (Oracle) wrote:
> Due to a typo, the final argument to alloc_page_vma() didn't refer to a
> real variable.  This only affected CONFIG_NUMA, which was marked BROKEN
> in 2006 and removed from alpha in 2021.  Found due to a refactoring patch.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

diff mbox series

Patch

diff --git a/arch/alpha/include/asm/page.h b/arch/alpha/include/asm/page.h
index 18f48a6f2ff6..8f3f5eecba28 100644
--- a/arch/alpha/include/asm/page.h
+++ b/arch/alpha/include/asm/page.h
@@ -18,7 +18,7 @@  extern void clear_page(void *page);
 #define clear_user_page(page, vaddr, pg)	clear_page(page)
 
 #define alloc_zeroed_user_highpage_movable(vma, vaddr) \
-	alloc_page_vma(GFP_HIGHUSER_MOVABLE | __GFP_ZERO, vma, vmaddr)
+	alloc_page_vma(GFP_HIGHUSER_MOVABLE | __GFP_ZERO, vma, vaddr)
 #define __HAVE_ARCH_ALLOC_ZEROED_USER_HIGHPAGE_MOVABLE
 
 extern void copy_page(void * _to, void * _from);