From patchwork Thu May 5 07:01:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hyeonggon Yoo <42.hyeyoo@gmail.com> X-Patchwork-Id: 12839100 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1449CC433EF for ; Thu, 5 May 2022 07:01:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EB196B0071; Thu, 5 May 2022 03:01:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79A3F6B0073; Thu, 5 May 2022 03:01:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 661B46B0074; Thu, 5 May 2022 03:01:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 595F06B0071 for ; Thu, 5 May 2022 03:01:17 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2278D6118C for ; Thu, 5 May 2022 07:01:17 +0000 (UTC) X-FDA: 79430792994.07.C01639E Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf20.hostedemail.com (Postfix) with ESMTP id 0CEFA1C009C for ; Thu, 5 May 2022 07:01:09 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id k14so3007584pga.0 for ; Thu, 05 May 2022 00:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Y2zyKE+PVmtj7g0356+Wr3B8/m6MZ/HU48TwGSTdFsA=; b=Qa9+6KsCJCAs7+O/kPuceAYf4+lLRyZhxQwr4acyqao8irXOV5wnhSOmFIkRQXcIxv 3evAUwN4BXH/0OZxsmgFFEcRTU2LqSaRc0/ATm6rVZm5yEnU2TMHgdjhveVgfvMxdFRY CiwD2yd781xhHXTd4eUzXcwQJoC+rNjD9N42bEj/caGWVLfd1TiURjxPbYMXHLfbqPAK iEx5prEM8T2vcB0NANHRqzC47IHcUILQDw8H+NnLJFGRUe1LhbjScjPYg7MsUKKnbgug R6TXr1tWDectWAyCg15kdGMwHQPzv55xqVu88fQ6kVYaaEMBX4Mi6pz3Tdt4/FcG/I3P XyTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Y2zyKE+PVmtj7g0356+Wr3B8/m6MZ/HU48TwGSTdFsA=; b=Ypika9IujvsABCv1Kwfk9alOx3B0pBVtUohwzZiHnZxk6rPsJR2LdBfnS2nmPE2u8L MG/UH3NyjAKWcXznCTYI1iKqKZouE7S5e5aTbLzAG6COUGlJOJMsNZeqMd/noNtrUK9G R0g4YlZ4FaMNk+6d/VNBuTkbkR+JYBZZNbJGNjdNtByDbyJvaZOVL/4NdfxEdXnU1Vxc jHr+PfMVnTjwXG0NNsKMUqYYSQexu6VHpnsy7AmPfngpgv2DuqTy8lFTg82mJ7G5M4B1 SCaoyu3Yuwo4XEqOjpcSzNyupn/VA/GaEdaDLQ/oySLUNPlrZfy4+1W+7nm80GKo7GTM hwgg== X-Gm-Message-State: AOAM531WCk+Kk4AcA9SyJN6Zt/K8/7UMNx9Pvgwfr36F5kO9kmjYQ+p0 L6UL30C5iUjSRGbQgpXqIHg= X-Google-Smtp-Source: ABdhPJyQIdHw26kVDMEddyLAMnmpw7It68/iLkLMKqGsmJ6sFRN2DxbTdfgt+Xam5aKAWUAQ+U5UAw== X-Received: by 2002:a62:5ec6:0:b0:50d:a467:3cb7 with SMTP id s189-20020a625ec6000000b0050da4673cb7mr24431354pfb.85.1651734075331; Thu, 05 May 2022 00:01:15 -0700 (PDT) Received: from hyeyoo.. ([114.29.24.243]) by smtp.gmail.com with ESMTPSA id a7-20020aa795a7000000b0050dc76281e6sm566385pfk.192.2022.05.05.00.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 00:01:14 -0700 (PDT) From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: [PATCH] mm/kfence: reset PG_slab and memcg_data before freeing __kfence_pool Date: Thu, 5 May 2022 16:01:05 +0900 Message-Id: <20220505070105.1835745-1-42.hyeyoo@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Qa9+6KsC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0CEFA1C009C X-Rspam-User: X-Stat-Signature: jf4dd6y8emwhy96msx8ig7xnedoepxi4 X-HE-Tag: 1651734069-573002 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When kfence fails to initialize kfence pool, it frees the pool. But it does not reset PG_slab flag and memcg_data of struct page. Below is a BUG because of this. Let's fix it by resetting PG_slab and memcg_data before free. [ 0.089149] BUG: Bad page state in process swapper/0 pfn:3d8e06 [ 0.089149] page:ffffea46cf638180 refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x3d8e06 [ 0.089150] memcg:ffffffff94a475d1 [ 0.089150] flags: 0x17ffffc0000200(slab|node=0|zone=2|lastcpupid=0x1fffff) [ 0.089151] raw: 0017ffffc0000200 ffffea46cf638188 ffffea46cf638188 0000000000000000 [ 0.089152] raw: 0000000000000000 0000000000000000 00000000ffffffff ffffffff94a475d1 [ 0.089152] page dumped because: page still charged to cgroup [ 0.089153] Modules linked in: [ 0.089153] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G B W 5.18.0-rc1+ #965 [ 0.089154] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014 [ 0.089154] Call Trace: [ 0.089155] [ 0.089155] dump_stack_lvl+0x49/0x5f [ 0.089157] dump_stack+0x10/0x12 [ 0.089158] bad_page.cold+0x63/0x94 [ 0.089159] check_free_page_bad+0x66/0x70 [ 0.089160] __free_pages_ok+0x423/0x530 [ 0.089161] __free_pages_core+0x8e/0xa0 [ 0.089162] memblock_free_pages+0x10/0x12 [ 0.089164] memblock_free_late+0x8f/0xb9 [ 0.089165] kfence_init+0x68/0x92 [ 0.089166] start_kernel+0x789/0x992 [ 0.089167] x86_64_start_reservations+0x24/0x26 [ 0.089168] x86_64_start_kernel+0xa9/0xaf [ 0.089170] secondary_startup_64_no_verify+0xd5/0xdb [ 0.089171] Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reported-by: kernel test robot --- mm/kfence/core.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/mm/kfence/core.c b/mm/kfence/core.c index a203747ad2c0..2ab3d473321e 100644 --- a/mm/kfence/core.c +++ b/mm/kfence/core.c @@ -642,6 +642,13 @@ static bool __init kfence_init_pool_early(void) * fails for the first page, and therefore expect addr==__kfence_pool in * most failure cases. */ + for (char *p = (char *)addr; p < __kfence_pool + KFENCE_POOL_SIZE; p += PAGE_SIZE) { + struct page *page; + + page = virt_to_page(p); + page->memcg_data = 0; + __ClearPageSlab(page); + } memblock_free_late(__pa(addr), KFENCE_POOL_SIZE - (addr - (unsigned long)__kfence_pool)); __kfence_pool = NULL; return false;