From patchwork Fri May 27 15:50:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 12863482 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C60D4C43217 for ; Fri, 27 May 2022 15:51:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD6418D0031; Fri, 27 May 2022 11:50:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D860C8D002F; Fri, 27 May 2022 11:50:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFBEB8D0031; Fri, 27 May 2022 11:50:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B46608D002F for ; Fri, 27 May 2022 11:50:54 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 915E9A63 for ; Fri, 27 May 2022 15:50:54 +0000 (UTC) X-FDA: 79511961228.18.1E18770 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 6407C140043 for ; Fri, 27 May 2022 15:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=DJY687eqHjmpDVUKm/xXxUZxBj5KWv9uItsiE/FIc4I=; b=Y8f1cRpo8fYv+eUKAfQeyS8pik SlRPrFW+ZvhpPNkvDEI8UGgqO26CquSyrXSTmdqXXYSOb5xddzl+KFizeqoDCvwdckwzWioTRFu2o BtyHp4vRjrPr6x2SlMJX1/voab0Kk3/BUT58eNr2bU3ZgoH8stycbX6EN5uAuuom0gAMaBc2nBzfB BfVOcdszN29s6pROELQxSfHGPS2tj/ngpZbfeuVSLtoRUYaqnSBcBLAR0nBAQz2cf97PXGHeryMP+ zEJIifXcjGLyD2jIFhweM0CTS539uARqFxwVEvKQaUeBOEJJL0xYP/Pjd/EwddsBUElfVOI3030Ch 6e9C4rZA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nucEa-002CWc-Tg; Fri, 27 May 2022 15:50:40 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 09/24] nilfs2: Remove check for PageError Date: Fri, 27 May 2022 16:50:21 +0100 Message-Id: <20220527155036.524743-10-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220527155036.524743-1-willy@infradead.org> References: <20220527155036.524743-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 6407C140043 X-Stat-Signature: q9dabd9o9ttbpkoytan4mn4jydj7ac19 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Y8f1cRpo; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1653666631-531830 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If read_mapping_page() encounters an error, it returns an errno, not a page with PageError set, so this test is not needed. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig --- fs/nilfs2/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/dir.c b/fs/nilfs2/dir.c index f8f4c2ff52f4..decd6471300b 100644 --- a/fs/nilfs2/dir.c +++ b/fs/nilfs2/dir.c @@ -194,7 +194,7 @@ static struct page *nilfs_get_page(struct inode *dir, unsigned long n) if (!IS_ERR(page)) { kmap(page); if (unlikely(!PageChecked(page))) { - if (PageError(page) || !nilfs_check_page(page)) + if (!nilfs_check_page(page)) goto fail; } }