Message ID | 20220527155036.524743-16-willy@infradead.org (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | Begin removing PageError | expand |
On Fri, May 27, 2022 at 04:50:27PM +0100, Matthew Wilcox (Oracle) wrote: > Pages returned from read_mapping_page() are always uptodate, so > this check is unnecessary. Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index 387652ae14c2..2e8461ce74de 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c @@ -618,7 +618,7 @@ struct metapage *__get_metapage(struct inode *inode, unsigned long lblock, SetPageUptodate(page); } else { page = read_mapping_page(mapping, page_index, NULL); - if (IS_ERR(page) || !PageUptodate(page)) { + if (IS_ERR(page)) { jfs_err("read_mapping_page failed!"); return NULL; }
Pages returned from read_mapping_page() are always uptodate, so this check is unnecessary. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- fs/jfs/jfs_metapage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)