From patchwork Tue May 31 00:55:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongwei Song X-Patchwork-Id: 12865013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F302C433EF for ; Tue, 31 May 2022 00:56:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB8ED6B0072; Mon, 30 May 2022 20:56:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E686C6B0073; Mon, 30 May 2022 20:56:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D54CA6B0074; Mon, 30 May 2022 20:56:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C3DD76B0072 for ; Mon, 30 May 2022 20:56:07 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8F4D8202C7 for ; Tue, 31 May 2022 00:56:07 +0000 (UTC) X-FDA: 79524221574.10.EEF9182 Received: from pv50p00im-tydg10021701.me.com (pv50p00im-tydg10021701.me.com [17.58.6.54]) by imf13.hostedemail.com (Postfix) with ESMTP id 125652005B for ; Tue, 31 May 2022 00:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1653958566; bh=wgvlbiHXPS4b0FVNndNCUtFwoK4klCA5shEF51SF30M=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=XL3lu02CUzmSCCbYKmJ8aoNxXziM1fazmIgSygrky9eVur94TUkxOtF+RP/o862ac +2us3/rGVsGqaOBxnhiLnIsHychJ0IaU0V158GSvWEbYvGmz0SBIGZtTLcePfz3DW0 +dmu5hjpBg02BzepgK27/JaAyZG+XqPtItBvUtnS209pYccGS2Q4PG7CrchZSi6igI 4RW69mlHIQ+HtO8r3dht9GZHfV9G1ZFNqg3nhmxFQGlHuWLNzjle7Yt+ZmquHRwbc4 Db714Qs2Mw5eAcj/pz7lVnwy0ifabMtzIm50hmgYGteWg5CIfJkS2PCPNiewow99jh h7RchOnzrcrlw== Received: from xiongwei.. (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-tydg10021701.me.com (Postfix) with ESMTPSA id 864D33A0B00; Tue, 31 May 2022 00:56:01 +0000 (UTC) From: sxwjean@me.com To: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiongwei Song Subject: [PATCH] mm/slub: Simplify __kmem_cache_alias() Date: Tue, 31 May 2022 08:55:50 +0800 Message-Id: <20220531005550.10613-1-sxwjean@me.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874 definitions=2022-05-30_10:2022-05-30,2022-05-30 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=668 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2009150000 definitions=main-2205310003 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 125652005B X-Stat-Signature: 5ryjeaxmkr3qgc6rs7ersu6pebeg5uwg X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=me.com header.s=1a1hai header.b=XL3lu02C; spf=pass (imf13.hostedemail.com: domain of sxwjean@me.com designates 17.58.6.54 as permitted sender) smtp.mailfrom=sxwjean@me.com; dmarc=pass (policy=quarantine) header.from=me.com X-HE-Tag: 1653958534-12790 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Xiongwei Song There is no need to do anything if sysfs_slab_alias() return nonzero value after getting a mergeable cache. Signed-off-by: Xiongwei Song Reviewed-by: Muchun Song --- mm/slub.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index d8d5abf49f5f..9444277d669a 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -4861,6 +4861,9 @@ __kmem_cache_alias(const char *name, unsigned int size, unsigned int align, s = find_mergeable(size, align, flags, name, ctor); if (s) { + if (sysfs_slab_alias(s, name)) + return NULL; + s->refcount++; /* @@ -4869,11 +4872,6 @@ __kmem_cache_alias(const char *name, unsigned int size, unsigned int align, */ s->object_size = max(s->object_size, size); s->inuse = max(s->inuse, ALIGN(size, sizeof(void *))); - - if (sysfs_slab_alias(s, name)) { - s->refcount--; - s = NULL; - } } return s;