From patchwork Wed Jun 1 19:23:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 12867176 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE25DC43334 for ; Wed, 1 Jun 2022 19:23:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D78B8D0030; Wed, 1 Jun 2022 15:23:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45F368D0028; Wed, 1 Jun 2022 15:23:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AFE38D0030; Wed, 1 Jun 2022 15:23:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 16CC18D0028 for ; Wed, 1 Jun 2022 15:23:44 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id DD9EA80A08 for ; Wed, 1 Jun 2022 19:23:43 +0000 (UTC) X-FDA: 79530641526.19.F6D52C2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id A3A3340099 for ; Wed, 1 Jun 2022 19:23:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=yHw2wth7/QLOgYffmoVtxIbJyeLsT+RCXVJBn8zWZQY=; b=QG+ZQSqDYzChC/tXlZ0CU21mHr CVnJM+j61y6HDa5o2wWnKmDGvtcvf+7USIFccIBdEI2/Ek1WjbRh7/aj7iKPno6mwujQb9rLdAyzB A5paRudachwOhX7hC3eoWudfqfhaSHpWgVZRKJawguR6q4Rmh9X8CTJp3AwdtIRfB/OuYvCv+6Qw3 l6HnPToPnuuS0Fay3pX1VYsf3kgvX9DOZCitMjlDjf01pMluR5/36XjEjbVwB9vcPym5y3HU4JKHr GfA8x4TB0OuhYd99LTybpScwKkNZI1GxnKEZyuHqaAF9xW2AoR30eOlC3KF26QyEBu3c3Hg7ZR/zp nI7WBKog==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwTwM-006Y2d-96; Wed, 01 Jun 2022 19:23:34 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org, Mike Kravetz , Muchun Song Subject: [PATCH 1/2] hugetlb: Convert huge_add_to_page_cache() to use a folio Date: Wed, 1 Jun 2022 20:23:32 +0100 Message-Id: <20220601192333.1560777-1-willy@infradead.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A3A3340099 X-Stat-Signature: 1zxq5ry6eg5bsrmzoeh9wua7nnfhnor1 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QG+ZQSqD; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1654111381-322615 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Remove the last caller of add_to_page_cache() Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Mike Kravetz Reviewed-by: Muchun Song --- fs/hugetlbfs/inode.c | 2 +- mm/hugetlb.c | 14 ++++++++++---- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index 62408047e8d7..ae2524480f23 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -759,7 +759,7 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, SetHPageMigratable(page); /* - * unlock_page because locked by add_to_page_cache() + * unlock_page because locked by huge_add_to_page_cache() * put_page() due to reference from alloc_huge_page() */ unlock_page(page); diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 7c468ac1d069..eb9d6fe9c492 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -5406,19 +5406,25 @@ static bool hugetlbfs_pagecache_present(struct hstate *h, int huge_add_to_page_cache(struct page *page, struct address_space *mapping, pgoff_t idx) { + struct folio *folio = page_folio(page); struct inode *inode = mapping->host; struct hstate *h = hstate_inode(inode); - int err = add_to_page_cache(page, mapping, idx, GFP_KERNEL); + int err; - if (err) + __folio_set_locked(folio); + err = __filemap_add_folio(mapping, folio, idx, GFP_KERNEL, NULL); + + if (unlikely(err)) { + __folio_clear_locked(folio); return err; + } ClearHPageRestoreReserve(page); /* - * set page dirty so that it will not be removed from cache/file + * mark folio dirty so that it will not be removed from cache/file * by non-hugetlbfs specific code paths. */ - set_page_dirty(page); + folio_mark_dirty(folio); spin_lock(&inode->i_lock); inode->i_blocks += blocks_per_huge_page(h);