From patchwork Sun Jun 5 15:25:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 12869778 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 713D0C43334 for ; Sun, 5 Jun 2022 15:25:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 265778D0003; Sun, 5 Jun 2022 11:25:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 213AA8D0001; Sun, 5 Jun 2022 11:25:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B8478D0005; Sun, 5 Jun 2022 11:25:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E6D388D0003 for ; Sun, 5 Jun 2022 11:25:47 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id C28EE803A2 for ; Sun, 5 Jun 2022 15:25:47 +0000 (UTC) X-FDA: 79544557134.16.733195D Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf23.hostedemail.com (Postfix) with ESMTP id AB127140006 for ; Sun, 5 Jun 2022 15:25:19 +0000 (UTC) Received: by mail-ed1-f53.google.com with SMTP id z7so15763772edm.13 for ; Sun, 05 Jun 2022 08:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f3oII5rEfZoXf7U4b6hs9rpi5sWM6BBnmpd30r2QEOU=; b=PyvPxjctikeWzSfNKXCBFIPiHQj342ETF+dWPSJtdTYhGlMch8kZDbkzZkAyX1rhHD vZ401ub/slIA5YG7R+7EGL6JtPXUmSKeBnMSlw5PZx16vAcARgASoY3pVP9iaOnNox3G 5K+FGbP7qHXBGFM25b//KOjJyLZEDACKFxUT4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f3oII5rEfZoXf7U4b6hs9rpi5sWM6BBnmpd30r2QEOU=; b=BmpT2K5q/I4gxpZeyHkL4gjiKdaNiODqpEwYV71oKwyL8FNwE3YtbIFQidJfhafn6C MXndIoWeYS8pmeDcVODX7x4BntXW0M4KtDWBdNDEhA9Ka/tDh79Mo154cDd5TotY0ZJ9 QSDjJIJjn9sUCbicWyIAyob4sehZoJagXHIp6acVTNibvUlxD9aWmTcAif0YHJk9tVMP sWwpAkGnBoQmKgBiDbre96FAthh4eSzKa6J9IAadK06w4ZjDDQG9k6TweGAtnCev332i kfzf4YyivC4LHf5p753to2ns+LwEhnAc394C5cN02wgQbGQ7Ydz5dhYui223IHxTUdH9 JbRQ== X-Gm-Message-State: AOAM533WBP/gOzMmsOs+JayGdxqrvdIYbg5xfxa6Ic2B2YFOED5FdHQu R71OVIZW93Nv0BYf8cbubTyJXQ== X-Google-Smtp-Source: ABdhPJzO8PurCrRxgpc214KmxgqXebuHnZN2GlgM5MuV0uMe12+HNCSkaguDfuGB/Kq9xPEFTfDOvw== X-Received: by 2002:a05:6402:42d4:b0:416:5cac:a9a0 with SMTP id i20-20020a05640242d400b004165caca9a0mr21618319edc.86.1654442746342; Sun, 05 Jun 2022 08:25:46 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id l21-20020a056402125500b0042dddaa8af3sm7051499edw.37.2022.06.05.08.25.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 08:25:45 -0700 (PDT) From: Daniel Vetter To: LKML Cc: DRI Development , Daniel Vetter , Daniel Vetter , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-mm@kvack.org Subject: [PATCH 2/3] mm/slab: delete cache_alloc_debugcheck_before() Date: Sun, 5 Jun 2022 17:25:38 +0200 Message-Id: <20220605152539.3196045-2-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220605152539.3196045-1-daniel.vetter@ffwll.ch> References: <20220605152539.3196045-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Stat-Signature: jcghnpbrnpj9zxi6e8ybsw5ae8eaiuko X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=ffwll.ch header.s=google header.b=PyvPxjct; spf=none (imf23.hostedemail.com: domain of daniel.vetter@ffwll.ch has no SPF policy when checking 209.85.208.53) smtp.mailfrom=daniel.vetter@ffwll.ch; dmarc=none X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: AB127140006 X-HE-Tag: 1654442719-924549 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It only does a might_sleep_if(GFP_RECLAIM) check, which is already covered by the might_alloc() in slab_pre_alloc_hook(). And all callers of cache_alloc_debugcheck_before() call that beforehand already. Signed-off-by: Daniel Vetter Cc: Christoph Lameter Cc: Pekka Enberg Cc: David Rientjes Cc: Joonsoo Kim Cc: Andrew Morton Cc: Vlastimil Babka Cc: Roman Gushchin Cc: linux-mm@kvack.org Reviewed-by: David Hildenbrand Acked-by: David Rientjes Reviewed-by: Muchun Song --- mm/slab.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/mm/slab.c b/mm/slab.c index b04e40078bdf..75779ac5f5ba 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -2973,12 +2973,6 @@ static void *cache_alloc_refill(struct kmem_cache *cachep, gfp_t flags) return ac->entry[--ac->avail]; } -static inline void cache_alloc_debugcheck_before(struct kmem_cache *cachep, - gfp_t flags) -{ - might_sleep_if(gfpflags_allow_blocking(flags)); -} - #if DEBUG static void *cache_alloc_debugcheck_after(struct kmem_cache *cachep, gfp_t flags, void *objp, unsigned long caller) @@ -3219,7 +3213,6 @@ slab_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid, size_t orig_ if (unlikely(ptr)) goto out_hooks; - cache_alloc_debugcheck_before(cachep, flags); local_irq_save(save_flags); if (nodeid == NUMA_NO_NODE) @@ -3304,7 +3297,6 @@ slab_alloc(struct kmem_cache *cachep, struct list_lru *lru, gfp_t flags, if (unlikely(objp)) goto out; - cache_alloc_debugcheck_before(cachep, flags); local_irq_save(save_flags); objp = __do_cache_alloc(cachep, flags); local_irq_restore(save_flags); @@ -3541,8 +3533,6 @@ int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size, if (!s) return 0; - cache_alloc_debugcheck_before(s, flags); - local_irq_disable(); for (i = 0; i < size; i++) { void *objp = kfence_alloc(s, s->object_size, flags) ?: __do_cache_alloc(s, flags);