| Message ID | 20220610101258.75738-1-david@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] MAINTAINERS: add MEMORY HOT(UN)PLUG section and add myself as reviewer | expand |
On 2022/6/10 18:12, David Hildenbrand wrote: > There are certainly a lot more files that partially fall into the memory > hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c > and mm/page_alloc.c. Let's only add what's almost completely memory > hot(un)plug related. > > Add myself as reviewer so it's easier for contributors to figure out > whom to CC. This really helps. Thanks! :) > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > MAINTAINERS | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index a6d3bd9d2a8d..77aebce76288 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12848,6 +12848,18 @@ F: include/linux/vmalloc.h > F: mm/ > F: tools/testing/selftests/vm/ > > +MEMORY HOT(UN)PLUG > +M: Andrew Morton <akpm@linux-foundation.org> > +R: David Hildenbrand <david@redhat.com> > +L: linux-mm@kvack.org > +S: Maintained > +F: Documentation/admin-guide/mm/memory-hotplug.rst > +F: Documentation/core-api/memory-hotplug.rst > +F: drivers/base/memory.c > +F: include/linux/memory_hotplug.h > +F: mm/memory_hotplug.c > +F: tools/testing/selftests/memory-hotplug/ > + > MEMORY TECHNOLOGY DEVICES (MTD) > M: Miquel Raynal <miquel.raynal@bootlin.com> > M: Richard Weinberger <richard@nod.at> >
On Fri, Jun 10, 2022 at 12:12:58PM +0200, David Hildenbrand wrote: > There are certainly a lot more files that partially fall into the memory > hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c > and mm/page_alloc.c. Let's only add what's almost completely memory > hot(un)plug related. > > Add myself as reviewer so it's easier for contributors to figure out > whom to CC. > > Signed-off-by: David Hildenbrand <david@redhat.com> You are really awesome. Thank for your work on this. Acked-by: Muchun Song <songmuchun@bytedance.com>
On 10.06.22 12:12, David Hildenbrand wrote: > There are certainly a lot more files that partially fall into the memory > hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c > and mm/page_alloc.c. Let's only add what's almost completely memory > hot(un)plug related. > > Add myself as reviewer so it's easier for contributors to figure out > whom to CC. > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > MAINTAINERS | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index a6d3bd9d2a8d..77aebce76288 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12848,6 +12848,18 @@ F: include/linux/vmalloc.h > F: mm/ > F: tools/testing/selftests/vm/ > > +MEMORY HOT(UN)PLUG > +M: Andrew Morton <akpm@linux-foundation.org> > +R: David Hildenbrand <david@redhat.com> > +L: linux-mm@kvack.org > +S: Maintained > +F: Documentation/admin-guide/mm/memory-hotplug.rst > +F: Documentation/core-api/memory-hotplug.rst > +F: drivers/base/memory.c > +F: include/linux/memory_hotplug.h > +F: mm/memory_hotplug.c > +F: tools/testing/selftests/memory-hotplug/ (thanks for the kind words from reviewers :) ) Thinking about it (and remembering having a discussion about submaintainers for MM in general at LSF/MM): @Andrew, do we want "official" submaintainers for that section? If so, we could turn my R into an M. Further, Oscar did a lot of work in the memory hot(un)plug world as well -- so if we want submaintainers, Oscar might be a very good fit as well. ... I guess, that would mostly reflect reality :)
On Tue, Jun 14, 2022 at 08:58:55AM +0200, David Hildenbrand wrote: > (thanks for the kind words from reviewers :) ) > > Thinking about it (and remembering having a discussion about > submaintainers for MM in general at LSF/MM): > > @Andrew, do we want "official" submaintainers for that section? If so, > we could turn my R into an M. Further, Oscar did a lot of work in the > memory hot(un)plug world as well -- so if we want submaintainers, Oscar > might be a very good fit as well. I would be glad to take on such role, officially, alongside David, and I think this can benefit this area.
On Fri, Jun 10, 2022 at 12:12:58PM +0200, David Hildenbrand wrote: > There are certainly a lot more files that partially fall into the memory > hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c > and mm/page_alloc.c. Let's only add what's almost completely memory > hot(un)plug related. > > Add myself as reviewer so it's easier for contributors to figure out > whom to CC. > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > MAINTAINERS | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index a6d3bd9d2a8d..77aebce76288 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12848,6 +12848,18 @@ F: include/linux/vmalloc.h > F: mm/ > F: tools/testing/selftests/vm/ > > +MEMORY HOT(UN)PLUG > +M: Andrew Morton <akpm@linux-foundation.org> > +R: David Hildenbrand <david@redhat.com> > +L: linux-mm@kvack.org > +S: Maintained > +F: Documentation/admin-guide/mm/memory-hotplug.rst > +F: Documentation/core-api/memory-hotplug.rst > +F: drivers/base/memory.c > +F: include/linux/memory_hotplug.h > +F: mm/memory_hotplug.c > +F: tools/testing/selftests/memory-hotplug/ Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> One question, will patches from you go through my driver core tree, or the -mm tree? Either is fine for me, just curious. thanks, greg k-h
On 14.06.22 11:33, Greg Kroah-Hartman wrote: > On Fri, Jun 10, 2022 at 12:12:58PM +0200, David Hildenbrand wrote: >> There are certainly a lot more files that partially fall into the memory >> hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c >> and mm/page_alloc.c. Let's only add what's almost completely memory >> hot(un)plug related. >> >> Add myself as reviewer so it's easier for contributors to figure out >> whom to CC. >> >> Signed-off-by: David Hildenbrand <david@redhat.com> >> --- >> MAINTAINERS | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index a6d3bd9d2a8d..77aebce76288 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -12848,6 +12848,18 @@ F: include/linux/vmalloc.h >> F: mm/ >> F: tools/testing/selftests/vm/ >> >> +MEMORY HOT(UN)PLUG >> +M: Andrew Morton <akpm@linux-foundation.org> >> +R: David Hildenbrand <david@redhat.com> >> +L: linux-mm@kvack.org >> +S: Maintained >> +F: Documentation/admin-guide/mm/memory-hotplug.rst >> +F: Documentation/core-api/memory-hotplug.rst >> +F: drivers/base/memory.c >> +F: include/linux/memory_hotplug.h >> +F: mm/memory_hotplug.c >> +F: tools/testing/selftests/memory-hotplug/ > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > One question, will patches from you go through my driver core tree, or > the -mm tree? Either is fine for me, just curious. In the past, most stuff regarding drivers/base/memory.c went through -mm, so I'd say we keep it like that, unless it's really generic changes to the driver model etc.
On Tue, Jun 14, 2022 at 11:35:28AM +0200, David Hildenbrand wrote: > On 14.06.22 11:33, Greg Kroah-Hartman wrote: > > On Fri, Jun 10, 2022 at 12:12:58PM +0200, David Hildenbrand wrote: > >> There are certainly a lot more files that partially fall into the memory > >> hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c > >> and mm/page_alloc.c. Let's only add what's almost completely memory > >> hot(un)plug related. > >> > >> Add myself as reviewer so it's easier for contributors to figure out > >> whom to CC. > >> > >> Signed-off-by: David Hildenbrand <david@redhat.com> > >> --- > >> MAINTAINERS | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index a6d3bd9d2a8d..77aebce76288 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -12848,6 +12848,18 @@ F: include/linux/vmalloc.h > >> F: mm/ > >> F: tools/testing/selftests/vm/ > >> > >> +MEMORY HOT(UN)PLUG > >> +M: Andrew Morton <akpm@linux-foundation.org> > >> +R: David Hildenbrand <david@redhat.com> > >> +L: linux-mm@kvack.org > >> +S: Maintained > >> +F: Documentation/admin-guide/mm/memory-hotplug.rst > >> +F: Documentation/core-api/memory-hotplug.rst > >> +F: drivers/base/memory.c > >> +F: include/linux/memory_hotplug.h > >> +F: mm/memory_hotplug.c > >> +F: tools/testing/selftests/memory-hotplug/ > > > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > One question, will patches from you go through my driver core tree, or > > the -mm tree? Either is fine for me, just curious. > > In the past, most stuff regarding drivers/base/memory.c went through > -mm, so I'd say we keep it like that, unless it's really generic changes > to the driver model etc. Sounds great to me, thanks for taking this on, much appreciated! greg k-h
On Tue, 14 Jun 2022 08:58:55 +0200 David Hildenbrand <david@redhat.com> wrote: > On 10.06.22 12:12, David Hildenbrand wrote: > > There are certainly a lot more files that partially fall into the memory > > hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c > > and mm/page_alloc.c. Let's only add what's almost completely memory > > hot(un)plug related. > > > > Add myself as reviewer so it's easier for contributors to figure out > > whom to CC. > > > > Signed-off-by: David Hildenbrand <david@redhat.com> > > --- > > MAINTAINERS | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index a6d3bd9d2a8d..77aebce76288 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -12848,6 +12848,18 @@ F: include/linux/vmalloc.h > > F: mm/ > > F: tools/testing/selftests/vm/ > > > > +MEMORY HOT(UN)PLUG > > +M: Andrew Morton <akpm@linux-foundation.org> > > +R: David Hildenbrand <david@redhat.com> > > +L: linux-mm@kvack.org > > +S: Maintained > > +F: Documentation/admin-guide/mm/memory-hotplug.rst > > +F: Documentation/core-api/memory-hotplug.rst > > +F: drivers/base/memory.c > > +F: include/linux/memory_hotplug.h > > +F: mm/memory_hotplug.c > > +F: tools/testing/selftests/memory-hotplug/ > > (thanks for the kind words from reviewers :) ) > > Thinking about it (and remembering having a discussion about > submaintainers for MM in general at LSF/MM): > > @Andrew, do we want "official" submaintainers for that section? If so, > we could turn my R into an M. Further, Oscar did a lot of work in the > memory hot(un)plug world as well -- so if we want submaintainers, Oscar > might be a very good fit as well. > > ... I guess, that would mostly reflect reality :) um, fine, no opinion really. I think the main thing is to make get_maintainer.pl spit out all the suitable email addresses.
On Tue, Jun 14, 2022 at 10:38:42AM -0700, Andrew Morton wrote: > On Tue, 14 Jun 2022 08:58:55 +0200 David Hildenbrand <david@redhat.com> wrote: > um, fine, no opinion really. I think the main thing is to make > get_maintainer.pl spit out all the suitable email addresses. As already pointed out, David and I have already kind of acted as maintainers of this aready already for quite some time, reviewing and contributing the most, so it might make sense to just spell that out, so, without willing to step on anyone's toes, what about this: diff --git a/MAINTAINERS b/MAINTAINERS index 1fc9ead83d2a..f5a746624a9f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12857,6 +12857,18 @@ F: include/linux/vmalloc.h F: mm/ F: tools/testing/selftests/vm/ +MEMORY HOT(UN)PLUG +M: David Hildenbrand <david@redhat.com> +M: Oscar Salvador <osalvador@suse.de> +L: linux-mm@kvack.org +S: Maintained +F: Documentation/admin-guide/mm/memory-hotplug.rst +F: Documentation/core-api/memory-hotplug.rst +F: drivers/base/memory.c +F: include/linux/memory_hotplug.h +F: mm/memory_hotplug.c +F: tools/testing/selftests/memory-hotplug/ Thanks
On 15.06.22 06:03, Oscar Salvador wrote: > On Tue, Jun 14, 2022 at 10:38:42AM -0700, Andrew Morton wrote: >> On Tue, 14 Jun 2022 08:58:55 +0200 David Hildenbrand <david@redhat.com> wrote: >> um, fine, no opinion really. I think the main thing is to make >> get_maintainer.pl spit out all the suitable email addresses. > > As already pointed out, David and I have already kind of acted as maintainers of > this aready already for quite some time, reviewing and contributing the most, so > it might make sense to just spell that out, so, without willing to step on > anyone's toes, what about this: > > diff --git a/MAINTAINERS b/MAINTAINERS > index 1fc9ead83d2a..f5a746624a9f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12857,6 +12857,18 @@ F: include/linux/vmalloc.h > F: mm/ > F: tools/testing/selftests/vm/ > > +MEMORY HOT(UN)PLUG > +M: David Hildenbrand <david@redhat.com> > +M: Oscar Salvador <osalvador@suse.de> > +L: linux-mm@kvack.org > +S: Maintained > +F: Documentation/admin-guide/mm/memory-hotplug.rst > +F: Documentation/core-api/memory-hotplug.rst > +F: drivers/base/memory.c > +F: include/linux/memory_hotplug.h > +F: mm/memory_hotplug.c > +F: tools/testing/selftests/memory-hotplug/ Fine with me to remove Andrew from that list because he's implicitly covering most stuff via the "MEMORY MANAGEMENT" section. @Andrew, whatever you prefer. Acked-by: David Hildenbrand <david@redhat.com> @Andrew, would it make sense to update the git tree in the "MEMORY MANAGEMENT" section now that mm-stable etc. resides on git.kernel.org ?
On Wed, 15 Jun 2022 11:15:30 +0200 David Hildenbrand <david@redhat.com> wrote: > @Andrew, would it make sense to update the git tree in the "MEMORY > MANAGEMENT" section now that mm-stable etc. resides on git.kernel.org ? Thanks, didn't know we had a MAINTAINERS entry ;) From: Andrew Morton <akpm@linux-foundation.org> Subject: MAINTAINERS: update tree references Date: Wed Jun 15 02:22:44 PM PDT 2022 Describe the new kernel.org location of the MM trees. Suggested-by: David Hildenbrand <david@redhat.com> Cc: Muchun Song <songmuchun@bytedance.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Miaohe Lin <linmiaohe@huawei.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- MAINTAINERS | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/MAINTAINERS~maintainers-update-tree-references +++ a/MAINTAINERS @@ -12846,9 +12846,8 @@ M: Andrew Morton <akpm@linux-foundation. L: linux-mm@kvack.org S: Maintained W: http://www.linux-mm.org -T: quilt https://ozlabs.org/~akpm/mmotm/ -T: quilt https://ozlabs.org/~akpm/mmots/ -T: git git://github.com/hnaz/linux-mm.git +T: git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm +T: quilt git://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new F: include/linux/gfp.h F: include/linux/memory_hotplug.h F: include/linux/mm.h
diff --git a/MAINTAINERS b/MAINTAINERS index a6d3bd9d2a8d..77aebce76288 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12848,6 +12848,18 @@ F: include/linux/vmalloc.h F: mm/ F: tools/testing/selftests/vm/ +MEMORY HOT(UN)PLUG +M: Andrew Morton <akpm@linux-foundation.org> +R: David Hildenbrand <david@redhat.com> +L: linux-mm@kvack.org +S: Maintained +F: Documentation/admin-guide/mm/memory-hotplug.rst +F: Documentation/core-api/memory-hotplug.rst +F: drivers/base/memory.c +F: include/linux/memory_hotplug.h +F: mm/memory_hotplug.c +F: tools/testing/selftests/memory-hotplug/ + MEMORY TECHNOLOGY DEVICES (MTD) M: Miquel Raynal <miquel.raynal@bootlin.com> M: Richard Weinberger <richard@nod.at>
There are certainly a lot more files that partially fall into the memory hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c and mm/page_alloc.c. Let's only add what's almost completely memory hot(un)plug related. Add myself as reviewer so it's easier for contributors to figure out whom to CC. Signed-off-by: David Hildenbrand <david@redhat.com> --- MAINTAINERS | 12 ++++++++++++ 1 file changed, 12 insertions(+)