From patchwork Tue Jun 21 20:46:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liam R. Howlett" X-Patchwork-Id: 12889776 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DB32C43334 for ; Tue, 21 Jun 2022 20:47:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B96028E0025; Tue, 21 Jun 2022 16:47:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD83B8E0024; Tue, 21 Jun 2022 16:47:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A6858E0025; Tue, 21 Jun 2022 16:47:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 74C478E0023 for ; Tue, 21 Jun 2022 16:47:14 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 41310207A2 for ; Tue, 21 Jun 2022 20:47:14 +0000 (UTC) X-FDA: 79603427988.02.8CC3DA2 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf26.hostedemail.com (Postfix) with ESMTP id DEBFF140015 for ; Tue, 21 Jun 2022 20:47:13 +0000 (UTC) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25LJ4NhA004714; Tue, 21 Jun 2022 20:47:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=WzplbQx7UHqj6+5lf1Bo7goPdCygbqVhUEeBo617ex4=; b=C7AGdgxUbXvbWvB+gNsJDDVlrBQOeu9SYFXpOMTVbn56CWs9i7rMMT8IZL7mTq/I0u48 8b5dJJLu6aQCjCSmtQgg3+AKdy7Q2xpevkpwgR/Aih2rxzZgwuQyHb9Eo91A9rKbaYmo YNLUfEmdbrOJDeGolLcXau11KqlMpc2F8tyRasEiH2gWGxtkXViV7j/g+jOhDR2BuVhb QjqxMSmDWmWq7z4HLhsAfDQIOO2QJ8HmaS7QN787KFK/tPYE3HlQvY+T5ekQhz8Ov+xk WqFgkozlgmJ1jjxPv65U7vBEUyj2FJO1aswGFXEdJ4+Z95UndQ0jwuDGTe4zIEGcFo7q 4g== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gs54cpnvw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jun 2022 20:47:10 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25LKeUhZ027847; Tue, 21 Jun 2022 20:47:09 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2171.outbound.protection.outlook.com [104.47.56.171]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3gth8wsp0s-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jun 2022 20:47:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OH4voE0DqI05f0ojbkpHmyIOQ+vHkgfef+Qm9UOJquioJYMFAyzOEdGpDXq5n0q2A0a8buzJkcSje1Je2Xi8KthRJ6iHUqvjpyl7Yd3pKM2R1zF1C8GGOcpJhy4M/9cL7pyBTaRxi08ASgeamf7RonbUYgo1c6XZLd6mh6QwYAaYBA8ftxI48LYod3UErRzOlPFcnnz4OaHqqsQnx5WvHXDXg/YWNiFSaHtcfhFWWCc2dVg/PuTCv5eucnWy1OmQKt57Kdj+JTkpo/oqgIhfs0gvHV5tI2s/ONoMMcTyljnQKjmRr0j2bIvO0RqmiJh3U9NwEGmo9So0FtAgHDtRfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WzplbQx7UHqj6+5lf1Bo7goPdCygbqVhUEeBo617ex4=; b=GxBzwhr9NBhzBnRd+MWJOGlwF7unkLhgHg4HJQ6PqXqYp/GTUzkRk5SFe0wivaIFNPhCqbSzoPwgpS58mNnuM+C65phbasHjT6eK3GW3/m9+9zLU8CB+khQJyLZcINqs8jpfTVmW27DJ/zx+lR7Yl6/HGYT6wn6GvdUbvtHNTvCJO0iG0qq8CzvRkBjyHVXR8Lzw9TOwgoP4GyArexuYpiHJxg61IiO98cb4qSLxhAJYrfgoumpY4Xsrf+6kGdS0ie9LZkDnf99TUUK4JsRI8agR3n6SJEivWv9RBGxZynStjL1uol/nS8+xM+f2UPlWnFAfQlX4pC+gagkxptnlyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WzplbQx7UHqj6+5lf1Bo7goPdCygbqVhUEeBo617ex4=; b=ZTYLlUj2Fw8SR2zwHb/SMbE8EOX64+uKFI785I832qzuP7ELrtnOOhnJb+VOe7MEIECfjm9w0F2GzLHyp5if2Ownfb1HhQTz5CFswVz5ECkGGZ9ogBNNXJ5zLKj7tTq/0jPJfab3R04zYIXQWKUBLFRVmZoDeX/QNVFyHjxvEyo= Received: from SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) by SN6PR10MB3085.namprd10.prod.outlook.com (2603:10b6:805:da::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Tue, 21 Jun 2022 20:47:06 +0000 Received: from SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::f59a:175d:d24:949c]) by SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::f59a:175d:d24:949c%7]) with mapi id 15.20.5353.022; Tue, 21 Jun 2022 20:47:06 +0000 From: Liam Howlett To: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "damon @ lists . linux . dev" , SeongJae Park , David Hildenbrand Subject: [PATCH v10 19/69] xen: use vma_lookup() in privcmd_ioctl_mmap() Thread-Topic: [PATCH v10 19/69] xen: use vma_lookup() in privcmd_ioctl_mmap() Thread-Index: AQHYhbAM/jtODHr+AUirdm/bFOz3jQ== Date: Tue, 21 Jun 2022 20:46:57 +0000 Message-ID: <20220621204632.3370049-20-Liam.Howlett@oracle.com> References: <20220621204632.3370049-1-Liam.Howlett@oracle.com> In-Reply-To: <20220621204632.3370049-1-Liam.Howlett@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.35.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d733183d-89d8-4940-530e-08da53c733e1 x-ms-traffictypediagnostic: SN6PR10MB3085:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YRbponWYdfpeXD1khSbh8YANHDtB8pdy1N3njS/zUc+ZnVISevGMFbjDk8KSb62Kx/A/NROOpzChiosykhAGy0PqENPCldkEIG65D4b8ZB+u6c1atq53V9T59KFQ3V4c2Rhe7OF2D4oKlGVEqwzcdrSLDIzXvPRjFKfQnyhCMGtZb1AHlZNP3d9fUx89iEbpg/wcAuPwIjGUeiRt8YKHFqbU3Cd2oOFZk1kwW/8u3iu7jAfxAhQBh0SsnOUXRbp+vBkjEaN8FyKuaLk8e6aw4v8/76eiFPEXBi+tXNs0txDa1p0f/pGazmpcI3qpQFXQIybllk38+EeLpBNN6axAuwrdZ9/ezDN447/nIs7HPwWOlL83bkBCSZKZ2MEj7Flm9qam2TR1GEIljjhjE6lxWw5YjxlcbItwvZHgnlaBhCKUIqbspxDViV+oaTf9nmFHZNiYmYjjaiL89BK/rDJ13gL2Rgd9eckRQX3qA8Ird+VtEvZWZKnjD19LZrAr/WlPP8oAAp3LcgvhnaSOzvZkpURnHM9b26qNq2X5gJIQzoHR/iTnEgfyS7bA6qHf/Qahlz2QwHKDwtpq1no1iUaFmVRULS4X4fGn59g12eCTL+VX4ZqNX1kZihoDH05ZumcxWlmfQqoooK6fx26cLufLEEBvwmiscQa10bP/fQNNjwMys6JtKzCRVR5Mx+Kb1t6q0VgjOwq1ekfls3mJnKhGOKlHUnoIPlNo8+8Hi/TWta0BSrpqA0xoo8D4ahBeGFRMzNsvDIeezGKbffd43jZsT7OygWHowhGaXBK8ZK/K00U= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR10MB3022.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(376002)(39860400002)(346002)(136003)(2616005)(66446008)(6486002)(76116006)(66556008)(966005)(36756003)(64756008)(83380400001)(478600001)(66476007)(1076003)(71200400001)(316002)(186003)(44832011)(5660300002)(8676002)(66946007)(6506007)(2906002)(41300700001)(26005)(6666004)(86362001)(91956017)(6512007)(38070700005)(38100700002)(122000001)(110136005)(8936002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?DdU9Ses9JWV25SmN0LO2Ci2?= =?iso-8859-1?q?OitwTYcv+YzmOfxnEmpOcQbWfeJ3oQaoBd1ydeloWmlDvjj5qPj63QVqSF9z?= =?iso-8859-1?q?UJAMBfz9gTlE8nuZsN+bTC6ffWlMxcqC2IvqR/qsz3Qk22PrEdy9+L8NzbsW?= =?iso-8859-1?q?o293bJtcRviXOSwRRvB0I5z6WVjzq5oqASRrc2/tcZR4+MCgGGCN7tssIqTI?= =?iso-8859-1?q?dcxFbh+xJ9/cxiJqjmBKD7cgnk0FszLN9cCo/3iUY6dxHhms7aolbeZq7Wf+?= =?iso-8859-1?q?lCTmtfnzndnuPIZJLKUVMH91RcP4KokYOH56oPh/La6p2472F2gtKUIPKuLU?= =?iso-8859-1?q?Irnq7MlJ6EkMMYHKu1aVEohG4rJZqQoybspXZwrM/dXoBIgpJbN8eVWBekxu?= =?iso-8859-1?q?qwhWb5c/el67ykINvGXaLONWZRtBSlIAXh1PlHQ7v4AGl81knM5z1zY5Gsa5?= =?iso-8859-1?q?4P69aVpYo7tU4/CnpncGPLWmqCpwNYmzCT9HzmAB5GpucYs7nqKTVXgL7S2I?= =?iso-8859-1?q?yaToqkQI0O1flDQFRYITj2rycnw8uqYsTfjseoYnsTmbbv3LH5ePPDyJx1XW?= =?iso-8859-1?q?G9gKnwKydIjsnd56uk55OYZZOr0qetkRnOspQVga3Y9jK9wVm93h0a5gNeUp?= =?iso-8859-1?q?FN2xw6F0ysecFliO7MdYWoTYUJDv4uxRFqAahplXh2eV5mmcJy5E5ktEH9ev?= =?iso-8859-1?q?Ai/fZhuffQc9soSbNjE50da8FpeRkU0ggam7akWOuf1pJRzJUDKU/qsWWvZj?= =?iso-8859-1?q?yR0hs212EPl8YpVGhY92soPRm1VPea1k+o4LVB0qeQmYzfRU5hTb6OuE/qs0?= =?iso-8859-1?q?UjuCwyjupbEnsY1FVL+wGLQ78Ainxc1pvX0gQ+Sx48qbzo0ZXZtYw9UaLsjB?= =?iso-8859-1?q?S1/37/rbxVjxbHXOlqeGmMEHvUg52D/wmJ9oUA1mMoA7oKyikd+OJu5cSXdS?= =?iso-8859-1?q?hWX2UNHCWRPY+pEVO3wSMG8Sy+suEZbPmzfH6gVEa/LFMAmUxPmkA8Vv2GOJ?= =?iso-8859-1?q?6cdxwUagdk1plr0hynb+vg84Ycd9HIUFYQUXSBPkw2E5cp+r6lCoGFj4XRUF?= =?iso-8859-1?q?ea7gOZE9m76LaC6JDdNDafWvvruLfDkAsyTtkINA4iuJZPMCI5+PkQjpYjiA?= =?iso-8859-1?q?mMRlTVjhhIC/AKadyMZRUfvlNLTe3SmSqwoTp0SY2ya/07vVcgvx4+WEp2D5?= =?iso-8859-1?q?EpBnz+Mo9KWm6Cif4zauc4ZbQ+bx7rtmoRUwOcIFNLigjABl19Y9BVZgqWUx?= =?iso-8859-1?q?IYDqbXa4/r8YmFnJ6hxUxd5H3lkRs5oftfwF206ZaQOeXPrJAdjzayxXB/Vb?= =?iso-8859-1?q?fupNmXNRJZk5pYMdNOwDqdR0sh+IyA2ldXy3Acwbs0QWEi2BN6eaIIfGJo1g?= =?iso-8859-1?q?fzr27opSBC9x+iPouGuwuAuLELdKdMLnNTgWF/0D2Li0oP6LFAgKm1E5elBD?= =?iso-8859-1?q?VrBED+N72iidcFOjHZq/gxKHZDhHgMIJT7NWbc4dHgOZT7A6Ns2FK6Tu31A7?= =?iso-8859-1?q?II+mnF4gVr/BU/X8BQcUYPywQocnui172lIVE0cn2uFYIgTc/Y8RfuJcLwEp?= =?iso-8859-1?q?byHXLCdjPMkBh0D8Y1orRRsbxpEcvhyplxcHFeGnlJfICLMQkPLsOtKt7NcV?= =?iso-8859-1?q?j0fCX3NEcuOpeOY5sRxges1/GER89RzXJ7rIvXtfLNIH1jTgrFJpxn8fCyrS?= =?iso-8859-1?q?7TizKt2CBv27MbPAyQZLrtIkQchGQBUC039GkkCpDR5Un67j31V5ffJSYoj1?= =?iso-8859-1?q?KqdGcy5ZvhYPr/MehNwxQ2amt/4LpCHfaxIhTbnsJElKCrH5kFajGkMTczSH?= =?iso-8859-1?q?MymIyJSY=3D?= MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d733183d-89d8-4940-530e-08da53c733e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2022 20:46:57.5354 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LARet9OZGsKeY1e7O8JctmMJgTj5vXvshPLR83jxHvH6qAejedzJCCnqmqAwvCQCXavqNwCFiG53TsOtCI5tSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB3085 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-06-21_09:2022-06-21,2022-06-21 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0 phishscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206210087 X-Proofpoint-GUID: L3DjX3fhyDLLr0ACg-OBbEJhRMqJyKH8 X-Proofpoint-ORIG-GUID: L3DjX3fhyDLLr0ACg-OBbEJhRMqJyKH8 ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1655844434; a=rsa-sha256; cv=pass; b=om3nl6iFmeg81SNo0sB9THZHRWIi1V9ENXaSr4ERG2ATkS/ttHpwbeLxRQTitmYhkIz7pP POcbdycwqxmoaHlTQeNR62NYAhuoD28G4gRQq1+z14Dn6XVWf/FdN9iC+OpE6N/x0vkT7e TgX4gFy32SkXRTswVnvQ+nVDFSCY+sU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655844434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WzplbQx7UHqj6+5lf1Bo7goPdCygbqVhUEeBo617ex4=; b=3Rae80TSOV+A07ZFjs7zf2Vxa07tCjN0Vw0l/ouoH7xgHIaF19Qpsf5d2EDbsYd4MasrjN 9VUnqiz9gnSn00iOM9TACoV5lUyvAuMsahlTPPy3CKJiyS6DLD8+eGqp1kHTCFpDcq26s0 CKoG8ie180MQ4INUcQD8WEnE6YTzB28= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=C7AGdgxU; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ZTYLlUj2; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf26.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=C7AGdgxU; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ZTYLlUj2; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf26.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: DEBFF140015 X-Stat-Signature: pfwti58beghpwgc3bdcq51xhjii1ww7h X-HE-Tag: 1655844433-723310 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Liam R. Howlett" vma_lookup() walks the VMA tree for a specific value, find_vma() will search the tree after walking to a specific value. It is more efficient to only walk to the requested value since privcmd_ioctl_mmap() will exit the loop if vm_start != msg->va. Link: https://lkml.kernel.org/r/20220504011345.662299-4-Liam.Howlett@oracle.com Signed-off-by: Liam R. Howlett Acked-by: Vlastimil Babka Cc: Catalin Marinas Cc: David Howells Cc: "Matthew Wilcox (Oracle)" Cc: SeongJae Park Cc: Will Deacon Cc: Davidlohr Bueso Signed-off-by: Andrew Morton --- drivers/xen/privcmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 3369734108af..ad17166b0ef6 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -282,7 +282,7 @@ static long privcmd_ioctl_mmap(struct file *file, void __user *udata) struct page, lru); struct privcmd_mmap_entry *msg = page_address(page); - vma = find_vma(mm, msg->va); + vma = vma_lookup(mm, msg->va); rc = -EINVAL; if (!vma || (msg->va != vma->vm_start) || vma->vm_private_data)