From patchwork Wed Jun 22 17:06:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 12891181 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CCB8C43334 for ; Wed, 22 Jun 2022 17:07:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0431F8E00D6; Wed, 22 Jun 2022 13:06:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7F298E00D8; Wed, 22 Jun 2022 13:06:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 760FD8E00D7; Wed, 22 Jun 2022 13:06:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 540698E00D5 for ; Wed, 22 Jun 2022 13:06:54 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 1B7FC120410 for ; Wed, 22 Jun 2022 17:06:54 +0000 (UTC) X-FDA: 79606501548.16.0397F28 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf25.hostedemail.com (Postfix) with ESMTP id ED479A00AC for ; Wed, 22 Jun 2022 17:06:48 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LSqVc34nyz1KC7g; Thu, 23 Jun 2022 01:04:24 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 23 Jun 2022 01:06:31 +0800 From: Miaohe Lin To: CC: , , , , , Subject: [PATCH 09/16] mm/huge_memory: fix comment in zap_huge_pud Date: Thu, 23 Jun 2022 01:06:20 +0800 Message-ID: <20220622170627.19786-10-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220622170627.19786-1-linmiaohe@huawei.com> References: <20220622170627.19786-1-linmiaohe@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655917610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CIOMoqeYcv8TX91p5iT/XNazOHEZTMTgLz2JpZ3FcY8=; b=2os+k29PPJLX8H3BL8QAwK4kTvzPtibMctLiOnrD0ubr1hz+B4S0Y90XOYHEawvy0pxmnh f42VkR7tcK0swhXEoISw2pyN1SieqRGKJx3QnTDeanw1S0sycTq4zsxy8DEZa+CaQc8lGV xNRjh2GeOhauIIvjXL6rKgf2Y7fewuA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655917610; a=rsa-sha256; cv=none; b=EhRD77esWSGGWfTnPN7c9tkXV4Rg/NYXUK/deqQhN9QsD6fxvaT/rkbgpg4BYnw+ltLI0O i9RE+SdZdTZik0RaDUwKM4k0lxZwdtNjDZoNfWexOz4QOaVmHEr5vUf1v7NJvYMrIwbSWR YxUycaiTKGM1iHu6iq1GsfecrTB5HCY= X-Rspamd-Queue-Id: ED479A00AC Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Stat-Signature: cacgmj4cihnpqmoenz63j44qiostqbjy X-Rspamd-Server: rspam04 X-HE-Tag: 1655917608-660175 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The comment about deposited pgtable is borrowed from zap_huge_pmd but there's no deposited pgtable stuff for huge pud in zap_huge_pud. Remove it to avoid confusion. Signed-off-by: Miaohe Lin --- mm/huge_memory.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index b42c8fa51e46..fd12fa930937 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1914,12 +1914,7 @@ int zap_huge_pud(struct mmu_gather *tlb, struct vm_area_struct *vma, ptl = __pud_trans_huge_lock(pud, vma); if (!ptl) return 0; - /* - * For architectures like ppc64 we look at deposited pgtable - * when calling pudp_huge_get_and_clear. So do the - * pgtable_trans_huge_withdraw after finishing pudp related - * operations. - */ + pudp_huge_get_and_clear_full(tlb->mm, addr, pud, tlb->fullmm); tlb_remove_pud_tlb_entry(tlb, pud, addr); if (vma_is_special_huge(vma)) {