From patchwork Fri Jun 24 19:52:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gautam Menghani X-Patchwork-Id: 12895032 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 279CCC433EF for ; Fri, 24 Jun 2022 19:53:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98DFD8E0270; Fri, 24 Jun 2022 15:52:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93DE28E0244; Fri, 24 Jun 2022 15:52:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8053E8E0270; Fri, 24 Jun 2022 15:52:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 71D2C8E0244 for ; Fri, 24 Jun 2022 15:52:59 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 491A83530C for ; Fri, 24 Jun 2022 19:52:59 +0000 (UTC) X-FDA: 79614177678.09.F6234C7 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf31.hostedemail.com (Postfix) with ESMTP id 8D04620017 for ; Fri, 24 Jun 2022 19:52:58 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id a17so2965727pls.6 for ; Fri, 24 Jun 2022 12:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F64miWX8OIqGg7SQtGzniGR3amqV7Fg7vGx9jO7hUCs=; b=KG3QkLlWUxzLyv8sJMKH921oVvgVk521YHQekwTUWlGSfDMB9pqY0/y10mxQ5RC/sE RACAUQBOb9GFJAD0pNe7zYYb0zT6qdwrMkun4xBAmlAVFUVejeIgPtfkImyTxDcK9joG WIyobwYTQFAzSCctv50iKXFyYvsWZ2NtQoaZp2XypkYmBi9vCH3bCMzGO1zf9oFrsiaA m0sLaImwJ8X3u0ZEBoVB33JOBGWULVChZZaKNosHVhxAR7tgzzxUQiCZEi2cfOGxe8Og JDxEJb/8Q/5s9D41e0wWDLUquxLYba8LZ/0lPR1GoAoRRWGvZ2yuwD1MOHsJbJVbszia ueKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F64miWX8OIqGg7SQtGzniGR3amqV7Fg7vGx9jO7hUCs=; b=yg9rAsR1uQRju+oB9fGqgiu9aa3tAYgLb+KHwcf8ZmOwGTN8OwdhplQqlSkWX79oS7 544Os6xHBmu8lbCAiWxCsAbLwZC2ql0W9CpO/G7rT4gtFdEPUczYFFvLQ9xyXePly9s9 oa53quIvBh2uresUJT38ZlD0SGBFtZVKzlMr5/xfCiTj3F73s+r9CW/71XqG/t3q/T0a PQi+DZTiZK0CNNmIBICYPSa5LbXD7ftVyYf7xorBkthBnv83lm9otiJQlUMEuPgnMLrv s+OjBvM24YKCH+MFfPcpP8yCrGgECnmh9YClGryor0zaP4rJrUVSWLzqj3RTgshAq/1F AvqQ== X-Gm-Message-State: AJIora9EAzaIMWATjN8Hfm899INfZgerGZQwRlZNVtiSVTFzYwatr75K 3SlHq7Duo+gStfg4qpGwGT0= X-Google-Smtp-Source: AGRyM1u5oABiaQ4N9vv8eRRoGYjSna+gp2MU2xgiqmbWPGR0eG0IzoEqq8qbimjBVbruzHb8HViHyQ== X-Received: by 2002:a17:90a:8041:b0:1ec:9f10:3c4e with SMTP id e1-20020a17090a804100b001ec9f103c4emr614193pjw.148.1656100377092; Fri, 24 Jun 2022 12:52:57 -0700 (PDT) Received: from fedora.. ([103.230.148.187]) by smtp.gmail.com with ESMTPSA id h9-20020a170902f70900b001663cf001besm2186069plo.174.2022.06.24.12.52.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 12:52:56 -0700 (PDT) From: Gautam To: sj@kernel.org, shuah@kernel.org Cc: Gautam , damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] kselftests/damon: add support for checking secureboot status Date: Sat, 25 Jun 2022 01:22:39 +0530 Message-Id: <20220624195239.7293-1-gautammenghani201@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656100378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=F64miWX8OIqGg7SQtGzniGR3amqV7Fg7vGx9jO7hUCs=; b=WWVdR412p/QYxjI6NHNWNNyZLjLAhtJlY3jGBu6kWl+GstGrTHPITKbdi27TJjRpnLP+U1 3CmTfcB6VEaJreeZGCt4/QSTXsU7dLEdRqQSraRtDwBp2WWTmECeLgaAxJnc3BQN9d2iBM kAVLtzb7KiEl/WJraDz+VZKRTLNmrF0= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KG3QkLlW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf31.hostedemail.com: domain of gautammenghani201@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=gautammenghani201@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656100378; a=rsa-sha256; cv=none; b=t/rsPUJ1jFweS+RnZh0+d+dgIAwWENwVKZmm6Dtp8asuFr5GVoyWwuNBdK2LQSfEppAhCt /wzdcIpolgTrDfrcKj1fb6/LTqlrn0WfZK790e8gb2UUBVipli6QB5XFHNIEsrIzqDteP6 aWdXqW71UPrYaDEkYTPZERCT0G9Gwo0= X-Rspamd-Queue-Id: 8D04620017 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KG3QkLlW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf31.hostedemail.com: domain of gautammenghani201@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=gautammenghani201@gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: h1pe15wrupfj91knnx3a5rxgu3iooak8 X-HE-Tag: 1656100378-971081 X-Bogosity: Ham, tests=bogofilter, spamicity=0.043861, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The kernel is in lockdown mode when secureboot is enabled and hence debugfs cannot be used. But the error printed after running tests does not indicate this currently: >TAP version 13 >1..6 ># selftests: damon: debugfs_attrs.sh ># cat: /sys/kernel/debug/damon/monitor_on: Operation not permitted ># _debugfs_common.sh: line 48: [: =: unary operator expected ># cat: /sys/kernel/debug/damon/attrs: Operation not permitted ># _debugfs_common.sh: line 11: /sys/kernel/debug/damon/attrs: Operation > not permitted ># writing 1 2 3 4 5 to /sys/kernel/debug/damon/attrs doesn't return 0 ># expected because: valid input ># _debugfs_common.sh: line 16: /sys/kernel/debug/damon/attrs: Operation > not permitted >not ok 1 selftests: damon: debugfs_attrs.sh # exit=1 After adding the check for secureboot, the output is as follows: >TAP version 13 >1..6 ># selftests: damon: debugfs_attrs.sh ># debugfs cannot work with secureboot enabled >not ok 1 selftests: damon: debugfs_attrs.sh # exit=1 Signed-off-by: Gautam --- tools/testing/selftests/damon/_chk_dependency.sh | 10 ++++++++++ 1 file changed, 10 insertions(+) mode change 100644 => 100755 tools/testing/selftests/damon/_chk_dependency.sh diff --git a/tools/testing/selftests/damon/_chk_dependency.sh b/tools/testing/selftests/damon/_chk_dependency.sh old mode 100644 new mode 100755 index 0189db81550b..6e45c1fe230e --- a/tools/testing/selftests/damon/_chk_dependency.sh +++ b/tools/testing/selftests/damon/_chk_dependency.sh @@ -26,3 +26,13 @@ do exit 1 fi done + +secureboot_error="Operation not permitted" +for f in attrs target_ids monitor_on +do + status=$( cat "$DBGFS/$f" 2>&1 ) + if [ "${status#*$secureboot_error}" != "$status" ]; then + echo "debugfs cannot work with secureboot enabled" + exit 1 + fi +done