From patchwork Thu Jun 30 08:41:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 12901425 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0977C433EF for ; Thu, 30 Jun 2022 08:43:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D6DF8E0002; Thu, 30 Jun 2022 04:43:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3864C6B0074; Thu, 30 Jun 2022 04:43:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24EE98E0002; Thu, 30 Jun 2022 04:43:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 14C0C6B0073 for ; Thu, 30 Jun 2022 04:43:53 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id C887161169 for ; Thu, 30 Jun 2022 08:43:52 +0000 (UTC) X-FDA: 79634264304.22.425C0B5 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf16.hostedemail.com (Postfix) with ESMTP id 63BD5180031 for ; Thu, 30 Jun 2022 08:43:52 +0000 (UTC) Received: by mail-lj1-f169.google.com with SMTP id s14so22187252ljs.3 for ; Thu, 30 Jun 2022 01:43:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+mWa9uy7ICYbhRKIdnH3Wgfnf22wyfGmVH7zQlKGXVg=; b=nIfKpOgf+DgKD9NQ/+rnH0Tt0Eh9mEo4JtYG/gXqPmCHs0dS9D59YzmM6MwhgZpk50 S3616TOcHJ8GIrOoKmSVhaXKQJVvh15QbLGwZGGLPZVXvDW8cmB2HmOpjvQM/cSCtayC 7fpG08B18h4nYVIvcCy9C9LLcpcJyn82RxyUxqD8GQX9lP1XxOoiVHypPOg9PUoV5h+Z ZkK75FUvTZCulRCVaLOytmh8bMFCnaygW/JhZrC7TRBAVlHGR/Un/mymJeE1mKlCFTzZ 1+Qc2I1NITgbq/T3jcwY8v5FrfX7fKmoeA0iKhTOiVRO/3RuYYJakNlhw8CCFMqjX3Y1 Ef6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+mWa9uy7ICYbhRKIdnH3Wgfnf22wyfGmVH7zQlKGXVg=; b=QkSKGLlKMHnPaClkqy5g2603MgnZI7OFfCElgwUGQNcKBGOZJ5aniKK2sEEMXnpR+n 7QKug/StVu2g+LEdimWL3Lt8md9LAbP/bRwnNW6UxkS4BFJ92C1GmnpKt7A2gFWLnoQl L9uDXj0t2RZ9E7nEDzaJMHEp+EJ5tOZ6AC1FBRtSV+HhDGpW3EHl6jaL/Sft5wK/Reof D1T/BSV0zRK7/VLrRL4ZIV3BB6DkcJvx9gyyJRvBbHkbMo1V2H3hU1ZGhCTWccB7Jgpt E6/ziBNuwqwuT/JReDweiY7w/IBAgj4O5A98Ui6g8QlaDRsjreRQkD6YaQfccFgbYaFp zJvA== X-Gm-Message-State: AJIora9UROG5t4vMSC/sUrlKxwlsZFAWUvS2BGMHkMptsEvwRS11MfNB WlbNQh4uzJjZvv8nS0d9LmodmQ== X-Google-Smtp-Source: AGRyM1ufws5XubUS21/PCnMupVOGV6Q7BRiUwxb6JwjuVYh4cMAPwJaWBkL8xcIULfRuz/L5/eU86g== X-Received: by 2002:a2e:934b:0:b0:24f:cce:5501 with SMTP id m11-20020a2e934b000000b0024f0cce5501mr4271792ljh.443.1656578630976; Thu, 30 Jun 2022 01:43:50 -0700 (PDT) Received: from localhost.localdomain (c-fdcc225c.014-348-6c756e10.bbcust.telenor.se. [92.34.204.253]) by smtp.gmail.com with ESMTPSA id o23-20020a05651205d700b0047f62762100sm2973023lfo.138.2022.06.30.01.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 01:43:50 -0700 (PDT) From: Linus Walleij To: Andrew Morton Cc: linux-mm@kvack.org, Linus Walleij Subject: [PATCH 2/5] mm/highmem: Pass a pointer to virt_to_page() Date: Thu, 30 Jun 2022 10:41:21 +0200 Message-Id: <20220630084124.691207-3-linus.walleij@linaro.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220630084124.691207-1-linus.walleij@linaro.org> References: <20220630084124.691207-1-linus.walleij@linaro.org> MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656578632; a=rsa-sha256; cv=none; b=EzN3a+nAAeAaXS70OLMIKfIv6V9syTQ1F99x/8fz29nXXuA0Y7JAeHJ0HSb9IROXvrGhGN VZ2d1RnADsjdDjkbBynRTBOptEdYUmzHVdgoUm/kkUUoVAOSucqF4iR4fnbrG8r4C7pD8U XnnjEvNWimY8HuIM6v+K0iMeeLhk2KU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=nIfKpOgf; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf16.hostedemail.com: domain of linus.walleij@linaro.org designates 209.85.208.169 as permitted sender) smtp.mailfrom=linus.walleij@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656578632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+mWa9uy7ICYbhRKIdnH3Wgfnf22wyfGmVH7zQlKGXVg=; b=F3e/Gwmj04Cck9rSkJqx1eqV/n34+1xyjxCpF5sC4bW1aVLxDw3Tc1c/C3mXez763nLO6V yJKe9n9fJ238nIeMNhcMUvbj1Dn+XoYcMoyUlJH3VRWlKFf8jWicuL54USm3b1XQYVG79P bqACBrVO/Ug0BgYVBtUZDpnPMZ/PgYo= X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 63BD5180031 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=nIfKpOgf; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf16.hostedemail.com: domain of linus.walleij@linaro.org designates 209.85.208.169 as permitted sender) smtp.mailfrom=linus.walleij@linaro.org X-Rspam-User: X-Stat-Signature: sywz75n1crodny8cda9o38ajabjsinu3 X-HE-Tag: 1656578632-640679 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Functions that work on a pointer to virtual memory such as virt_to_pfn() and users of that function such as virt_to_page() are supposed to pass a pointer to virtual memory, ideally a (void *) or other pointer. However since many architectures implement virt_to_pfn() as a macro, this function becomes polymorphic and accepts both a (unsigned long) and a (void *). If we instead implement a proper virt_to_pfn(void *addr) function the following happens (occurred on arch/arm): mm/highmem.c:153:29: warning: passing argument 1 of 'virt_to_pfn' makes pointer from integer without a cast [-Wint-conversion] We already have a proper void * pointer in the scope of this function named "vaddr" so pass that instead. Cc: Andrew Morton Cc: linux-mm@kvack.org Signed-off-by: Linus Walleij --- mm/highmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/highmem.c b/mm/highmem.c index 1a692997fac4..e92a7ceb30e8 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -150,7 +150,7 @@ struct page *__kmap_to_page(void *vaddr) return pte_page(pkmap_page_table[i]); } - return virt_to_page(addr); + return virt_to_page(vaddr); } EXPORT_SYMBOL(__kmap_to_page);