From patchwork Sat Jul 9 15:44:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 12912269 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1636DCCA47C for ; Sat, 9 Jul 2022 15:45:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12BE36B0074; Sat, 9 Jul 2022 11:45:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 104056B0075; Sat, 9 Jul 2022 11:45:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBDE66B0078; Sat, 9 Jul 2022 11:45:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DF5A26B0074 for ; Sat, 9 Jul 2022 11:45:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id BAC3B1203D8 for ; Sat, 9 Jul 2022 15:45:04 +0000 (UTC) X-FDA: 79667984928.06.04D757C Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf01.hostedemail.com (Postfix) with ESMTP id 5D5D84001D for ; Sat, 9 Jul 2022 15:45:04 +0000 (UTC) Received: by mail-qk1-f178.google.com with SMTP id x22so1007758qkf.13 for ; Sat, 09 Jul 2022 08:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+sK84UVH2wquFXSzUUNoreC4W5iW3VQxZVW1oXFAj7M=; b=K+EBOXFVQx22mAysawqPPGd6YF6te2G3ocmODstIFyaoRmScuzwpcC9duEm7VoF1Pp P92mJu5GOvGrrgBsgTSJ7RU5dHhaM9gzAdcHKhQ2PZZAgH/lUwBBPydcnx0LqgVp5XEq iJXxuSYQEObaYzV7IKJITVT5yUophFPIE1WaQBhaZH9VZKOcYat3AT0FAtHh6866m415 v/8FKRd1nfulbf0rvPp89YwQDdQP5a8UZdogIEyBSovqnRpayLAx8K5z021nHSBYxjhY I05RV4vRNwvGoww0DQkCTd2LGAdYGOoR1rKcXQ2tS95sjaVWDHGgQW3Vg8Qz6FFSJlQw MEfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+sK84UVH2wquFXSzUUNoreC4W5iW3VQxZVW1oXFAj7M=; b=yQ4X8aHRyFDS1nV7SYC/5rhIqpPr6XEA7jfY62sJvAee2POFMsQLMIdCBF06jRWZMU xg+PDFSwOTXFWoUqndrtP3Vs4MVzWHllea65FOiea+UASl7/OxLVCCWN4Ah1qIyOGYsk kXVGIwV/YUud5uhL/2KVLAXdBUG2K/W5WVVnoFiIuWS7vI2s790qgq4YqIw+TT7dL9U1 ZtT7nvEAlrkJ0QHgodmq20vsJcStmP8x20225Nnv0+v/svcxga3U2qnpu//mq/xL1PqW sNyTtdO1jE1YcYX6nICUPH4UgEylHZ/36t9trzQYmSozQDQZf3PIqHkbvMIqwj+KdWlc 5fgQ== X-Gm-Message-State: AJIora+zu7fh28Fmj1QOPNmlF7pkUs3aZ5x22teNEUJ7VJxZJhQrP5jA gnDmBbhnKTcid//zaHkMDcs= X-Google-Smtp-Source: AGRyM1thPlTdIi4KTSZfgwOR+dB868cIZmv/k3fKNJ8+KGIYpj7VcJN/cbdNBWTmaqgEV08IwHvvnA== X-Received: by 2002:a05:620a:27c6:b0:6af:3c1d:7fac with SMTP id i6-20020a05620a27c600b006af3c1d7facmr6132331qkp.516.1657381503710; Sat, 09 Jul 2022 08:45:03 -0700 (PDT) Received: from vultr.guest ([2001:19f0:5:6e4b:5400:4ff:fe10:17bb]) by smtp.gmail.com with ESMTPSA id u14-20020a05620a430e00b006a6a6f148e6sm1682411qko.17.2022.07.09.08.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 08:45:02 -0700 (PDT) From: Yafang Shao To: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, quentin@isovalent.com, roman.gushchin@linux.dev, haoluo@google.com, shakeelb@google.com Cc: bpf@vger.kernel.org, linux-mm@kvack.org, Yafang Shao Subject: [PATCH bpf-next v3 2/2] bpf: Warn on non-preallocated case for missed trace types Date: Sat, 9 Jul 2022 15:44:57 +0000 Message-Id: <20220709154457.57379-3-laoar.shao@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220709154457.57379-1-laoar.shao@gmail.com> References: <20220709154457.57379-1-laoar.shao@gmail.com> MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657381504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+sK84UVH2wquFXSzUUNoreC4W5iW3VQxZVW1oXFAj7M=; b=RNsC2vZmZX0iDQpChYfQkGOWU53Qdwd0Xj9k46Q841y8TEqe2+7FjAuwiXcFJWKYPxOIen egpWjjJfHujy6whC9c3Z/NS+1c78nNPPoNomaGTEhZ0rV/HJjtAU+wd8Oxw8dfuXFBZwlQ CtMKBpPgi6jVwXJvdRQCWltfvILjc54= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657381504; a=rsa-sha256; cv=none; b=wx30O9GBb2EpYgT98rWNuGf669lAMN4fqzeToGUog+OUPqd1OZzGfOzUZhOmvf0OlbHqb2 gYfJV8ZoDxG/3Z8iFRrl9CH9UJkxPl5WMrQltROwwujy2PUQbPTzK+cxq1aMPjgdTO8dto CaOpmIA+5rc9YNMHequ9IOqALdqt7Ys= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=K+EBOXFV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.178 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=K+EBOXFV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.178 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5D5D84001D X-Stat-Signature: 9xopmc1g6y87rsdn8oz578gxq8g11afq X-Rspam-User: X-HE-Tag: 1657381504-461039 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The raw tracepoint may cause unexpected memory allocation if we set BPF_F_NO_PREALLOC. So let's warn on it. Signed-off-by: Yafang Shao --- kernel/bpf/verifier.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index e3cf6194c24f..3cd8260827e0 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -12574,14 +12574,20 @@ static int check_map_prealloc(struct bpf_map *map) !(map->map_flags & BPF_F_NO_PREALLOC); } -static bool is_tracing_prog_type(enum bpf_prog_type type) +static bool is_tracing_prog_type(enum bpf_prog_type prog_type, + enum bpf_attach_type attach_type) { - switch (type) { + switch (prog_type) { case BPF_PROG_TYPE_KPROBE: case BPF_PROG_TYPE_TRACEPOINT: case BPF_PROG_TYPE_PERF_EVENT: case BPF_PROG_TYPE_RAW_TRACEPOINT: + case BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE: return true; + case BPF_PROG_TYPE_TRACING: + if (attach_type == BPF_TRACE_RAW_TP) + return true; + return false; default: return false; } @@ -12601,7 +12607,9 @@ static int check_map_prog_compatibility(struct bpf_verifier_env *env, struct bpf_prog *prog) { + enum bpf_attach_type attach_type = prog->expected_attach_type; enum bpf_prog_type prog_type = resolve_prog_type(prog); + /* * Validate that trace type programs use preallocated hash maps. * @@ -12619,7 +12627,7 @@ static int check_map_prog_compatibility(struct bpf_verifier_env *env, * now, but warnings are emitted so developers are made aware of * the unsafety and can fix their programs before this is enforced. */ - if (is_tracing_prog_type(prog_type) && !is_preallocated_map(map)) { + if (is_tracing_prog_type(prog_type, attach_type) && !is_preallocated_map(map)) { if (prog_type == BPF_PROG_TYPE_PERF_EVENT) { verbose(env, "perf_event programs can only use preallocated hash map\n"); return -EINVAL; @@ -12638,7 +12646,7 @@ static int check_map_prog_compatibility(struct bpf_verifier_env *env, return -EINVAL; } - if (is_tracing_prog_type(prog_type)) { + if (is_tracing_prog_type(prog_type, attach_type)) { verbose(env, "tracing progs cannot use bpf_spin_lock yet\n"); return -EINVAL; } @@ -12650,7 +12658,7 @@ static int check_map_prog_compatibility(struct bpf_verifier_env *env, } if (map_value_has_timer(map)) { - if (is_tracing_prog_type(prog_type)) { + if (is_tracing_prog_type(prog_type, attach_type)) { verbose(env, "tracing progs cannot use bpf_timer yet\n"); return -EINVAL; }