[v12,12/69] mm/mmap: use the maple tree for find_vma_prev() instead of the rbtree

Commit Message

Liam R. Howlett July 20, 2022, 2:17 a.m. UTC

From: "Liam R. Howlett" <[e-mail]>

Use the maple tree's advanced API and a maple state to walk the tree for
the entry at the address of the next vma, then use the maple state to walk
back one entry to find the previous entry.

Add kernel documentation comments for this API.

Link: https://lkml.kernel.org/r/[e-mail]
Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Liam R. Howlett <[e-mail]>
Signed-off-by: Matthew Wilcox (Oracle) <[e-mail]>
Acked-by: Vlastimil Babka <[e-mail]>
Reviewed-by: David Hildenbrand <[e-mail]>
Cc: Catalin Marinas <[e-mail]>
Cc: David Howells <[e-mail]>
Cc: SeongJae Park <[e-mail]>
Cc: Will Deacon <[e-mail]>
Cc: Davidlohr Bueso <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---
 mm/mmap.c | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

Patch

diff --git a/mm/mmap.c b/mm/mmap.c
index 208deb8f55a9..12abf6a75690 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2517,23 +2517,30 @@  struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
 }
 EXPORT_SYMBOL(find_vma);
 
-/*
- * Same as find_vma, but also return a pointer to the previous VMA in *pprev.
+/**
+ * find_vma_prev() - Find the VMA for a given address, or the next vma and
+ * set %pprev to the previous VMA, if any.
+ * @mm: The mm_struct to check
+ * @addr: The address
+ * @pprev: The pointer to set to the previous VMA
+ *
+ * Note that RCU lock is missing here since the external mmap_lock() is used
+ * instead.
+ *
+ * Returns: The VMA associated with @addr, or the next vma.
+ * May return %NULL in the case of no vma at addr or above.
  */
 struct vm_area_struct *
 find_vma_prev(struct mm_struct *mm, unsigned long addr,
 			struct vm_area_struct **pprev)
 {
 	struct vm_area_struct *vma;
+	MA_STATE(mas, &mm->mm_mt, addr, addr);
 
-	vma = find_vma(mm, addr);
-	if (vma) {
-		*pprev = vma->vm_prev;
-	} else {
-		struct rb_node *rb_node = rb_last(&mm->mm_rb);
-
-		*pprev = rb_node ? rb_entry(rb_node, struct vm_area_struct, vm_rb) : NULL;
-	}
+	vma = mas_walk(&mas);
+	*pprev = mas_prev(&mas, 0);
+	if (!vma)
+		vma = mas_next(&mas, ULONG_MAX);
 	return vma;
 }