| Message ID | 20220721131637.6306-4-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | A few cleanup and fixup patches for hugetlbfs | expand |
On 07/21/22 21:16, Miaohe Lin wrote: > The header file signal.h is unneeded now. Remove it. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > --- > fs/hugetlbfs/inode.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index a10156df5726..aa7a5b8fc724 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -11,7 +11,6 @@ > > #include <linux/thread_info.h> > #include <asm/current.h> > -#include <linux/sched/signal.h> /* remove ASAP */ I see the original '#include <linux/sched.h>' with this 'remove ASAP' comment has been there since the initial git repository build. No idea why it was originally added, and can find no reason for it to be there today. Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
On 2022/7/22 7:18, Mike Kravetz wrote: > On 07/21/22 21:16, Miaohe Lin wrote: >> The header file signal.h is unneeded now. Remove it. >> >> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> >> --- >> fs/hugetlbfs/inode.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c >> index a10156df5726..aa7a5b8fc724 100644 >> --- a/fs/hugetlbfs/inode.c >> +++ b/fs/hugetlbfs/inode.c >> @@ -11,7 +11,6 @@ >> >> #include <linux/thread_info.h> >> #include <asm/current.h> >> -#include <linux/sched/signal.h> /* remove ASAP */ > > I see the original '#include <linux/sched.h>' with this 'remove ASAP' comment > has been there since the initial git repository build. No idea why it was > originally added, and can find no reason for it to be there today. Me too. This might be a historical vestige. > > Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com> Many thank for your reviewing. >
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index a10156df5726..aa7a5b8fc724 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -11,7 +11,6 @@ #include <linux/thread_info.h> #include <asm/current.h> -#include <linux/sched/signal.h> /* remove ASAP */ #include <linux/falloc.h> #include <linux/fs.h> #include <linux/mount.h>
The header file signal.h is unneeded now. Remove it. Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- fs/hugetlbfs/inode.c | 1 - 1 file changed, 1 deletion(-)