| Message ID | 20220723073804.53035-1-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | hugetlb_cgroup: fix wrong hugetlb cgroup numa stat | expand |
On Sat, Jul 23, 2022 at 03:38:04PM +0800, Miaohe Lin wrote: > We forget to set cft->private for numa stat file. As a result, numa stat > of hstates[0] is always showed for all hstates. Encode the hstates index > into cft->private to fix this issue. > > Fixes: f47761999052 ("hugetlb: add hugetlb.*.numa_stat file") > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Thanks for fixing this. Acked-by: Muchun Song <songmuchun@bytedance.com>
diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c index f9942841df18..c86691c431fd 100644 --- a/mm/hugetlb_cgroup.c +++ b/mm/hugetlb_cgroup.c @@ -772,6 +772,7 @@ static void __init __hugetlb_cgroup_file_dfl_init(int idx) /* Add the numa stat file */ cft = &h->cgroup_files_dfl[6]; snprintf(cft->name, MAX_CFTYPE_NAME, "%s.numa_stat", buf); + cft->private = MEMFILE_PRIVATE(idx, 0); cft->seq_show = hugetlb_cgroup_read_numa_stat; cft->flags = CFTYPE_NOT_ON_ROOT;
We forget to set cft->private for numa stat file. As a result, numa stat of hstates[0] is always showed for all hstates. Encode the hstates index into cft->private to fix this issue. Fixes: f47761999052 ("hugetlb: add hugetlb.*.numa_stat file") Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/hugetlb_cgroup.c | 1 + 1 file changed, 1 insertion(+)