[12/59] mm/swapfile: Remove page_swapcount()

Message ID	20220808193430.3378317-13-willy@infradead.org (mailing list archive)
State	New
Headers	show Return-Path: <owner-linux-mm@kvack.org> From: "Matthew Wilcox (Oracle)" <willy@infradead.org> To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>, hughd@google.com Subject: [PATCH 12/59] mm/swapfile: Remove page_swapcount() Date: Mon, 8 Aug 2022 20:33:40 +0100 Message-Id: <20220808193430.3378317-13-willy@infradead.org> In-Reply-To: <20220808193430.3378317-1-willy@infradead.org> References: <20220808193430.3378317-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	MM folio changes for 6.1 \| expand [00/59] MM folio changes for 6.1 [01/59] mm: Fix VM_BUG_ON in __delete_from_swap_cache() [02/59] shmem: Update folio if shmem_replace_page() updates the page [03/59] vmscan: Check folio_test_private(), not folio_get_private() [04/59] mm/vmscan: Fix a lot of comments [05/59] mm: Add the first tail page to struct folio [06/59] mm: Reimplement folio_order() and folio_nr_pages() [07/59] mm: Add split_folio() [08/59] mm: Add folio_add_lru_vma() [09/59] shmem: Convert shmem_writepage() to use a folio throughout [10/59] shmem: Convert shmem_delete_from_page_cache() to take a folio [11/59] shmem: Convert shmem_replace_page() to use folios throughout [12/59] mm/swapfile: Remove page_swapcount() [13/59] mm/swapfile: Convert try_to_free_swap() to folio_free_swap() [14/59] mm/swap: Convert __read_swap_cache_async() to use a folio [15/59] mm/swap: Convert add_to_swap_cache() to take a folio [16/59] mm/swap: Convert put_swap_page() to put_swap_folio() [17/59] mm: Convert do_swap_page() to use a folio [18/59] mm: Convert do_swap_page()'s swapcache variable to a folio [19/59] memcg: Convert mem_cgroup_swapin_charge_page() to mem_cgroup_swapin_charge_folio() [20/59] shmem: Convert shmem_mfill_atomic_pte() to use a folio [21/59] shmem: Convert shmem_replace_page() to shmem_replace_folio() [22/59] swap: Add swap_cache_get_folio() [23/59] shmem: Eliminate struct page from shmem_swapin_folio() [24/59] shmem: Convert shmem_getpage_gfp() to shmem_get_folio_gfp() [25/59] shmem: Convert shmem_fault() to use shmem_get_folio_gfp() [26/59] shmem: Convert shmem_read_mapping_page_gfp() to use shmem_get_folio_gfp() [27/59] shmem: Add shmem_get_folio() [28/59] shmem: Convert shmem_get_partial_folio() to use shmem_get_folio() [29/59] shmem: Convert shmem_write_begin() to use shmem_get_folio() [30/59] shmem: Convert shmem_file_read_iter() to use shmem_get_folio() [31/59] shmem: Convert shmem_fallocate() to use a folio [32/59] shmem: Convert shmem_symlink() to use a folio [33/59] shmem: Convert shmem_get_link() to use a folio [34/59] khugepaged: Call shmem_get_folio() [35/59] userfaultfd: Convert mcontinue_atomic_pte() to use a folio [36/59] shmem: Remove shmem_getpage() [37/59] swapfile: Convert try_to_unuse() to use a folio [38/59] swapfile: Convert __try_to_reclaim_swap() to use a folio [39/59] swapfile: Convert unuse_pte_range() to use a folio [40/59] mm: Convert do_swap_page() to use swap_cache_get_folio() [41/59] mm: Remove lookup_swap_cache() [42/59] swap_state: Convert free_swap_cache() to use a folio [43/59] swap: Convert swap_writepage() to use a folio [44/59] mm: Convert do_wp_page() to use a folio [45/59] huge_memory: Convert do_huge_pmd_wp_page() to use a folio [46/59] madvise: Convert madvise_free_pte_range() to use a folio [47/59] uprobes: Use folios more widely in __replace_page() [48/59] ksm: Use a folio in replace_page() [49/59] mm: Convert do_swap_page() to use folio_free_swap() [50/59] memcg: Convert mem_cgroup_swap_full() to take a folio [51/59] mm: Remove try_to_free_swap() [52/59] rmap: Convert page_move_anon_rmap() to use a folio [53/59] migrate: Convert __unmap_and_move() to use folios [54/59] migrate: Convert unmap_and_move_huge_page() to use folios [55/59] huge_memory: Convert split_huge_page_to_list() to use a folio [56/59] huge_memory: Convert unmap_page() to unmap_folio() [57/59] mm: Convert page_get_anon_vma() to folio_get_anon_vma() [58/59] rmap: Remove page_unlock_anon_vma_read() [59/59] uprobes: Use new_folio in __replace_page()

Message ID

20220808193430.3378317-13-willy@infradead.org (mailing list archive)

State

New

Headers

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: linux-mm@kvack.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	hughd@google.com
Subject: [PATCH 12/59] mm/swapfile: Remove page_swapcount()
Date: Mon,  8 Aug 2022 20:33:40 +0100
Message-Id: <20220808193430.3378317-13-willy@infradead.org>
In-Reply-To: <20220808193430.3378317-1-willy@infradead.org>
References: <20220808193430.3378317-1-willy@infradead.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: owner-linux-mm@kvack.org
Precedence: bulk

Series

MM folio changes for 6.1 | expand

Commit Message

Matthew Wilcox Aug. 8, 2022, 7:33 p.m. UTC

By restructuring folio_swapped(), it can use swap_swapcount() instead
of page_swapcount().  It's even a little more efficient.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 mm/swapfile.c | 46 +++++++++++++---------------------------------
 1 file changed, 13 insertions(+), 33 deletions(-)

diff --git a/mm/swapfile.c b/mm/swapfile.c
index 1fdccd2f1422..c042fd71de02 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -1427,30 +1427,6 @@  void swapcache_free_entries(swp_entry_t *entries, int n)
 		spin_unlock(&p->lock);
 }
 
-/*
- * How many references to page are currently swapped out?
- * This does not give an exact answer when swap count is continued,
- * but does include the high COUNT_CONTINUED flag to allow for that.
- */
-static int page_swapcount(struct page *page)
-{
-	int count = 0;
-	struct swap_info_struct *p;
-	struct swap_cluster_info *ci;
-	swp_entry_t entry;
-	unsigned long offset;
-
-	entry.val = page_private(page);
-	p = _swap_info_get(entry);
-	if (p) {
-		offset = swp_offset(entry);
-		ci = lock_cluster_or_swap_info(p, offset);
-		count = swap_count(p->swap_map[offset]);
-		unlock_cluster_or_swap_info(p, ci);
-	}
-	return count;
-}
-
 int __swap_count(swp_entry_t entry)
 {
 	struct swap_info_struct *si;
@@ -1465,11 +1441,16 @@  int __swap_count(swp_entry_t entry)
 	return count;
 }
 
+/*
+ * How many references to @entry are currently swapped out?
+ * This does not give an exact answer when swap count is continued,
+ * but does include the high COUNT_CONTINUED flag to allow for that.
+ */
 static int swap_swapcount(struct swap_info_struct *si, swp_entry_t entry)
 {
-	int count = 0;
 	pgoff_t offset = swp_offset(entry);
 	struct swap_cluster_info *ci;
+	int count;
 
 	ci = lock_cluster_or_swap_info(si, offset);
 	count = swap_count(si->swap_map[offset]);
@@ -1570,17 +1551,16 @@  static bool swap_page_trans_huge_swapped(struct swap_info_struct *si,
 
 static bool folio_swapped(struct folio *folio)
 {
-	swp_entry_t entry;
-	struct swap_info_struct *si;
+	swp_entry_t entry = folio_swap_entry(folio);
+	struct swap_info_struct *si = _swap_info_get(entry);
+
+	if (!si)
+		return false;
 
 	if (!IS_ENABLED(CONFIG_THP_SWAP) || likely(!folio_test_large(folio)))
-		return page_swapcount(&folio->page) != 0;
+		return swap_swapcount(si, entry) != 0;
 
-	entry = folio_swap_entry(folio);
-	si = _swap_info_get(entry);
-	if (si)
-		return swap_page_trans_huge_swapped(si, entry);
-	return false;
+	return swap_page_trans_huge_swapped(si, entry);
 }
 
 /*

[12/59] mm/swapfile: Remove page_swapcount()

Commit Message

Patch