From patchwork Tue Aug 16 13:05:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 12944892 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08F3C25B0E for ; Tue, 16 Aug 2022 13:06:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A8F78D0002; Tue, 16 Aug 2022 09:06:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 232338D0001; Tue, 16 Aug 2022 09:06:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D3448D0002; Tue, 16 Aug 2022 09:06:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F22268D0001 for ; Tue, 16 Aug 2022 09:06:22 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C0EA6140D8F for ; Tue, 16 Aug 2022 13:06:22 +0000 (UTC) X-FDA: 79805479404.26.E5888E9 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf27.hostedemail.com (Postfix) with ESMTP id D5F9840065 for ; Tue, 16 Aug 2022 13:06:21 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4M6WXg1Brvz1M8xv; Tue, 16 Aug 2022 21:02:59 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 16 Aug 2022 21:06:18 +0800 From: Miaohe Lin To: , , CC: , , Subject: [PATCH 2/6] mm/hugetlb: fix WARN_ON(!kobj) in sysfs_create_group() Date: Tue, 16 Aug 2022 21:05:49 +0800 Message-ID: <20220816130553.31406-3-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220816130553.31406-1-linmiaohe@huawei.com> References: <20220816130553.31406-1-linmiaohe@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660655182; a=rsa-sha256; cv=none; b=T/yBVn422eezNZLfO2PDl+Qv6N0mFNWhbW06oAOGlvkpC8yET1omQw+dJtNRTnr5Quz5ze Ic08Mj01CHATRQa4RhYE8WVqiXbRsFreFI4rQyT0OE5csCdyZCpLbgjCiJKk5/b+q36PvW jBnwNUoVwphuh2slEnu4uOaMdASq4fM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660655182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W3/clTcnLGJxTGNbpkP0Yyon62dURfYJ2FHwKz+Ejgw=; b=B3/WH2NKY7js39kNlx5LgVHokdK6zpacRLTOvz+HEw/Mu8SDLbMppA2h5T0zRPKPlRSMlH 2jekCJCDM2MSm2nlrNad3c1nfEkHBXGCPpAk1TtAc8FhINDIg1tC/6aWdWh6thnuqG6yVd HNuOBFYa7+ZWggEhTmIndBafsBeuT1g= X-Stat-Signature: 4rcyioagnbkf77izqcwixg64x4sdbqne X-Rspamd-Queue-Id: D5F9840065 Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1660655181-758979 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If sysfs_create_group() fails with hstate_attr_group, hstate_kobjs[hi] will be set to NULL. Then it will be passed to sysfs_create_group() if h->demote_order != 0 thus triggering WARN_ON(!kobj) check. Fix this by making sure hstate_kobjs[hi] != NULL when calling sysfs_create_group. Signed-off-by: Miaohe Lin Reviewed-by: Mike Kravetz Reviewed-by: Muchun Song --- mm/hugetlb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index e72052964fb5..ff991e5bdf1f 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -3846,6 +3846,7 @@ static int hugetlb_sysfs_add_hstate(struct hstate *h, struct kobject *parent, if (retval) { kobject_put(hstate_kobjs[hi]); hstate_kobjs[hi] = NULL; + return retval; } if (h->demote_order) {