From patchwork Fri Aug 19 09:30:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: mawupeng X-Patchwork-Id: 12948610 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A3EC32789 for ; Fri, 19 Aug 2022 09:31:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 663258D0006; Fri, 19 Aug 2022 05:31:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 611BA8D0002; Fri, 19 Aug 2022 05:31:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4477D8E0001; Fri, 19 Aug 2022 05:31:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 239258D0006 for ; Fri, 19 Aug 2022 05:31:00 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F3B14AB93B for ; Fri, 19 Aug 2022 09:30:59 +0000 (UTC) X-FDA: 79815823038.01.22B39C4 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf30.hostedemail.com (Postfix) with ESMTP id 3F2B780019 for ; Fri, 19 Aug 2022 09:30:58 +0000 (UTC) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4M8Gf11ttsznTcm; Fri, 19 Aug 2022 17:28:41 +0800 (CST) Received: from dggpemm500014.china.huawei.com (7.185.36.153) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 19 Aug 2022 17:30:55 +0800 Received: from localhost.localdomain (10.175.112.125) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 19 Aug 2022 17:30:54 +0800 From: Wupeng Ma To: CC: , , , , , , , , , , , , , , , Subject: [PATCH v2 1/2] mm: Cap zone movable's min wmark to small value Date: Fri, 19 Aug 2022 17:30:24 +0800 Message-ID: <20220819093025.105403-2-mawupeng1@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220819093025.105403-1-mawupeng1@huawei.com> References: <20220819093025.105403-1-mawupeng1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660901459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U5bkmKf8dK4mdugDx1Le1YAAcP0u2XWJP4+i9GYE9LI=; b=MJ0mv2m4wsYA6qj41ARkPOelT8KSj5EsruJwj1qkSKJmQ9ZZ2MLl4fr29rvSAKIW6s7I6K yU0EGb/YrAQmwTphcttumrcMHkd5J7DO/c6UMYQxaxhSDVf0CymdVybogK4m/9htOyVYbc PZSzLfT6ixP/wG3T9yeq9/KgR+SnXWU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660901459; a=rsa-sha256; cv=none; b=vIzKmlnBDzjx+4xou4FIyqDO+j3//6O3x/llFot6yY8780WLBdjQtzSaCEZNcNB4hlSeoi SabDJACoJvqCXiEVIv72ElXI5s7vPCcJab/Zd2BVk6LvOqTUgFKh7sRIYLFxwPjCKmtVHa GCdqbtybPdSIVi/3bp0AY3L3P2w9F9w= Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Rspamd-Queue-Id: 3F2B780019 X-Rspamd-Server: rspam02 X-Stat-Signature: gz3gbgbgimygy8zfy3xxxdw3sbociqyn X-HE-Tag: 1660901458-811307 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Ma Wupeng Since min_free_kbytes is based on gfp_zone(GFP_USER) which does not include zone movable. However zone movable will get its min share in __setup_per_zone_wmarks() which does not make any sense. And like highmem pages, __GFP_HIGH and PF_MEMALLOC allocations usually don't need movable pages, so there is no need to assign min pages for zone movable. Let's cap pages_min for zone movable to a small value here just link highmem pages. Signed-off-by: Ma Wupeng --- mm/page_alloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e5486d47406e..ff644205370f 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -8638,7 +8638,7 @@ static void __setup_per_zone_wmarks(void) /* Calculate total number of !ZONE_HIGHMEM pages */ for_each_zone(zone) { - if (!is_highmem(zone)) + if (!is_highmem(zone) && zone_idx(zone) != ZONE_MOVABLE) lowmem_pages += zone_managed_pages(zone); } @@ -8648,7 +8648,7 @@ static void __setup_per_zone_wmarks(void) spin_lock_irqsave(&zone->lock, flags); tmp = (u64)pages_min * zone_managed_pages(zone); do_div(tmp, lowmem_pages); - if (is_highmem(zone)) { + if (is_highmem(zone) || zone_idx(zone) == ZONE_MOVABLE) { /* * __GFP_HIGH and PF_MEMALLOC allocations usually don't * need highmem pages, so cap pages_min to a small