From patchwork Thu Aug 25 16:46:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 12955084 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D72CECAA27 for ; Thu, 25 Aug 2022 16:47:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C306C6B0078; Thu, 25 Aug 2022 12:47:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B43A06B007B; Thu, 25 Aug 2022 12:47:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BC5F940007; Thu, 25 Aug 2022 12:47:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 91B716B0078 for ; Thu, 25 Aug 2022 12:47:17 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6A104ACA51 for ; Thu, 25 Aug 2022 16:47:17 +0000 (UTC) X-FDA: 79838695314.09.DDA926C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 1EF851A0006 for ; Thu, 25 Aug 2022 16:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661446036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0pHEpCNYxkjW/UyrCPUA7dfCnACPQEp1wsHh/kCfEpU=; b=ic9rS8T6QrIyYJ49y8Z+0SLsIsydE8/d8Gus4k7s/YmM3AUN0lZKa+VRoo5+qfMkPtzoX/ idGjw3QCoKWdOOM0OkHxBpSIM1PUZ89W90RrZmZX18KUh7aZhazng+uQc6zOT9usVBq+zu J6bQzQE5Vphi1sCiqmaIVD6dwEbsOmI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-611-YJeOGrswNsy7KzmUBM-aoA-1; Thu, 25 Aug 2022 12:47:12 -0400 X-MC-Unique: YJeOGrswNsy7KzmUBM-aoA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7D0FB101AA45; Thu, 25 Aug 2022 16:47:11 +0000 (UTC) Received: from t480s.fritz.box (unknown [10.39.192.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id A8104492CA2; Thu, 25 Aug 2022 16:47:09 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, David Hildenbrand , Andrew Morton , Mel Gorman , Jason Gunthorpe , John Hubbard , "Matthew Wilcox (Oracle)" , Andrea Arcangeli , Hugh Dickins , Peter Xu Subject: [PATCH v1 3/3] mm: fixup documentation regarding pte_numa() and PROT_NUMA Date: Thu, 25 Aug 2022 18:46:59 +0200 Message-Id: <20220825164659.89824-4-david@redhat.com> In-Reply-To: <20220825164659.89824-1-david@redhat.com> References: <20220825164659.89824-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ic9rS8T6; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661446037; a=rsa-sha256; cv=none; b=Xoudx16QarYqTyM3XbBbyjSzLYg5R6hUWRy/nWd6+5Yp/8yw821bcXnz49euzSZyGY+3Ho j6xyWtb1XOUUMiChxxkMs1mCR1R71NGK/IVxREQbk+wKF3Olaj0mSx/RgxkSoE4YsaFhn9 wxKzggocIfl49ZVKMEcIZ0bFcjg1UYk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661446037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0pHEpCNYxkjW/UyrCPUA7dfCnACPQEp1wsHh/kCfEpU=; b=uOZk/IAAg49NKb5FP047S/BRZ1e3V1solcq3xZGPceEvhXbjnJ4xvYB8PiD72e6ee5BfwX mPEQFfD356YzD66UQdyc/aMCaCKb0LVkikRlvdhrlUEMDmDRbeooqHCVnb0Hzr+zHQbW3B u06UJYW1QtBNzs0jvlvnUZxmHCrlJU0= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1EF851A0006 X-Rspam-User: X-Stat-Signature: gn3ip7i6khxzknzmy5udg7hinwuptkbn Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ic9rS8T6; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1661446036-476630 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: pte_numa() no longer exists -- replaced by pte_protnone() -- and PROT_NUMA probably never existed: MM_CP_PROT_NUMA also ends up using PROT_NONE. Let's fixup the doc. Signed-off-by: David Hildenbrand --- include/linux/mm_types.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index cf97f3884fda..85a6e9853b7b 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -631,22 +631,22 @@ struct mm_struct { #endif #ifdef CONFIG_NUMA_BALANCING /* - * numa_next_scan is the next time that the PTEs will be marked - * pte_numa. NUMA hinting faults will gather statistics and - * migrate pages to new nodes if necessary. + * numa_next_scan is the next time that PTEs will be remapped + * PROT_NONE to trigger NUMA hinting faults; such faults gather + * statistics and migrate pages to new nodes if necessary. */ unsigned long numa_next_scan; - /* Restart point for scanning and setting pte_numa */ + /* Restart point for scanning and remapping PTEs. */ unsigned long numa_scan_offset; - /* numa_scan_seq prevents two threads setting pte_numa */ + /* numa_scan_seq prevents two threads remapping PTEs. */ int numa_scan_seq; #endif /* * An operation with batched TLB flushing is going on. Anything * that can move process memory needs to flush the TLB when - * moving a PROT_NONE or PROT_NUMA mapped page. + * moving a PROT_NONE mapped page. */ atomic_t tlb_flush_pending; #ifdef CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH