| Message ID | 20220901063725.24220-1-yuancan@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: remove extra empty line | expand |
Le 01/09/2022 à 08:37, Yuan Can a écrit : > [Vous ne recevez pas souvent de courriers de yuancan@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > Remove extra empty line. Don't you have anything more exciting and usefull to do in your life ? This kind of standalone patch is a waste of time for both you and the reviewers/maintainers. Christophe > > Signed-off-by: Yuan Can <yuancan@huawei.com> > --- > mm/mmap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 6445fd386f04..2504f89d519f 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -2804,7 +2804,6 @@ SYSCALL_DEFINE2(munmap, unsigned long, addr, size_t, len) > SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, > unsigned long, prot, unsigned long, pgoff, unsigned long, flags) > { > - > struct mm_struct *mm = current->mm; > struct vm_area_struct *vma; > unsigned long populate = 0; > -- > 2.17.1 > >
On 01.09.22 09:37, Christophe Leroy wrote: > > > Le 01/09/2022 à 08:37, Yuan Can a écrit : >> [Vous ne recevez pas souvent de courriers de yuancan@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] >> >> Remove extra empty line. > > Don't you have anything more exciting and usefull to do in your life ? > > This kind of standalone patch is a waste of time for both you and the > reviewers/maintainers. While I agree with the general idea of that message, we could phrase that a little differently I think, after seeing: $ git shortlog -s --author "Yuan Can <yuancan@huawei.com>" 2 Yuan Can The linux-mm list is currently fairly overloaded (lots of new material, reviewers/maintainers having a hard time to catch up), which is why such simple cleanups that could essentially be done semi-automatically by tooling (coccinelle scripts ?) are not of general interest and rather an unpleasant distraction for reviewers/maintainers.
diff --git a/mm/mmap.c b/mm/mmap.c index 6445fd386f04..2504f89d519f 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2804,7 +2804,6 @@ SYSCALL_DEFINE2(munmap, unsigned long, addr, size_t, len) SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, unsigned long, prot, unsigned long, pgoff, unsigned long, flags) { - struct mm_struct *mm = current->mm; struct vm_area_struct *vma; unsigned long populate = 0;
Remove extra empty line. Signed-off-by: Yuan Can <yuancan@huawei.com> --- mm/mmap.c | 1 - 1 file changed, 1 deletion(-)