From patchwork Fri Sep 16 07:22:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 12978219 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B9DC6FA82 for ; Fri, 16 Sep 2022 07:24:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB49F80011; Fri, 16 Sep 2022 03:23:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B669E80010; Fri, 16 Sep 2022 03:23:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 943D780011; Fri, 16 Sep 2022 03:23:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8125C80010 for ; Fri, 16 Sep 2022 03:23:49 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 63ED3161AE2 for ; Fri, 16 Sep 2022 07:23:49 +0000 (UTC) X-FDA: 79917108978.08.D95FAE9 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf06.hostedemail.com (Postfix) with ESMTP id D0A2A180092 for ; Fri, 16 Sep 2022 07:23:48 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MTQSG40s2zlVyw; Fri, 16 Sep 2022 15:19:42 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 16 Sep 2022 15:23:42 +0800 From: Miaohe Lin To: , , , CC: , , , Subject: [PATCH v2 14/16] mm/page_alloc: use costly_order in WARN_ON_ONCE_GFP() Date: Fri, 16 Sep 2022 15:22:55 +0800 Message-ID: <20220916072257.9639-15-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220916072257.9639-1-linmiaohe@huawei.com> References: <20220916072257.9639-1-linmiaohe@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663313029; a=rsa-sha256; cv=none; b=jXy8Mtc+jhKRjeOPGpe13EykcmhDQJ+cTFPRSvhw560YpVuTGfsfbYPJ2l5dTkkDjv3dMM GSahfvxcktU6RS5tDNdq0Ks1GPRfX5QGzhNLAyZXLp+bkbNK+iObTmcR5AQffZnEEPUgbR 3+naL2ybPLO7GZEd0H94FEOcvba50ZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663313029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GuG/aQGBzQUlR14SnEuumxij3zFNtwkrffWWQU2Os0c=; b=vFXPC6THTzK51rxlFvenxDe27bnAvALmeG6nc+Q68BieAE3BYAINnxMkek8kOS4gz47M5a tPDrbzRAXqmIakf9uGJPvnwgQFG9xN1sRACT3+NIqeBPpHsgztmOh2QHUGMc8Q96T1PlnO GgvQcCeIWeP9ss4IAXsFKkZkmR+/6fw= X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D0A2A180092 Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Stat-Signature: hos4z1jozdcwkwkrfuzuxqiehnqoa5jh X-HE-Tag: 1663313028-983308 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There's no need to check whether order > PAGE_ALLOC_COSTLY_ORDER again. Minor readability improvement. Signed-off-by: Miaohe Lin Reviewed-by: David Hildenbrand Reviewed-by: Anshuman Khandual Reviewed-by: Oscar Salvador --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 652b3d766003..3d2ad5c197d5 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5272,7 +5272,7 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, * so that we can identify them and convert them to something * else. */ - WARN_ON_ONCE_GFP(order > PAGE_ALLOC_COSTLY_ORDER, gfp_mask); + WARN_ON_ONCE_GFP(costly_order, gfp_mask); /* * Help non-failing allocations by giving them access to memory