From patchwork Wed Sep 28 10:45:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 12992083 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB72CC32771 for ; Wed, 28 Sep 2022 10:46:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A75838E0138; Wed, 28 Sep 2022 06:45:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A23A38E0120; Wed, 28 Sep 2022 06:45:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EA998E0138; Wed, 28 Sep 2022 06:45:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7FD948E0120 for ; Wed, 28 Sep 2022 06:45:59 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 43988A117F for ; Wed, 28 Sep 2022 10:45:59 +0000 (UTC) X-FDA: 79961164038.23.7A6B72D Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by imf04.hostedemail.com (Postfix) with ESMTP id 471604001E for ; Wed, 28 Sep 2022 10:45:58 +0000 (UTC) From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1664361955; bh=4jcq0VaC/iDXcd4j2uJ4w0vNny9swybKQkCYoOfOC5k=; h=From:To:Cc:Subject:Date:From; b=Qa9qhGRLkpREYaE4iLS0o/hjjWX1Wzj56X+39n6KNg7ShMYFrVzF8pjEQanUDQN6G nEsK1vk4b/wpIHEGpsP0RUwqY3tZwKYK2NsszSf2Rkgg0KtQZRFsWaB0/26T4IfWmt GcMAWT34lxZGkIJcdcufgZASwm73J8WloKwbbC94= To: Hugh Dickins , Andrew Morton Cc: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , linux-mm@kvack.org, linux-kernel@vger.kernel.org, =?utf-8?q?Thomas_Wei?= =?utf-8?q?=C3=9Fschuh?= Subject: [PATCH] tmpfs: ensure O_LARGEFILE with generic_file_open() Date: Wed, 28 Sep 2022 12:45:35 +0200 Message-Id: <20220928104535.61186-1-linux@weissschuh.net> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1664361931; l=887; i=linux@weissschuh.net; s=20211113; h=from:subject; bh=d66fuy49WyqPJLzFDKOViGXYieS8rDSH8RKJPKnQnVU=; b=a8GADzUi4rhImJ18q5ENvGnE0+4c+H6JL0fbYL7u3mDoLpE4BpFBjsL/oBthgtnwVGEBUnzCk44H 5YLhloXkC2HEYVLv9fvjqfeZgv0Hzkh9R/YXEfnk4E+VlUbnN1Ze X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=9LP6KM4vD/8CwHW7nouRBhWLyQLcK1MkP6aTZbzUlj4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664361958; a=rsa-sha256; cv=none; b=W6ZqqUzfg19jWWfY1zQOLAW5dNC30iK1qWtEoM52OCW1/TAXQqQ14ztnRJlsCuS9Gyx/yE uxf7gV+0umuSuHz1MRzFbxk1bjzmEpvThiscxNjpgKhFkhT7/Mgzki+FVm3GPy94J2oPpe 5TSYBa6AArSFNfMkgceQ1c66fS2d92I= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=weissschuh.net header.s=mail header.b=Qa9qhGRL; dmarc=none; spf=pass (imf04.hostedemail.com: domain of linux@weissschuh.net designates 159.69.126.157 as permitted sender) smtp.mailfrom=linux@weissschuh.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664361958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=heMTOg+m21LM9fK+ii8bVcNKwgGdOMtRNvGqb0nIcyk=; b=cSbZ9KT6Ue150Ibo3vXXUEvc8Eeh3X6I1R/hlNEfRn15kRj/M6RmyeNDdjk3VaWwkk4xlh 13JTvmy9zq8vkIb6ARU7vqZWHpkT+fSmIA7dmAXzGhutAVfnSn4paklqEBnX8ohxShb2M6 oITcWQqikxT8KZxrd85eOLggWNs1PyY= X-Stat-Signature: qkfysk5nks19e7bp3w33w1rpaq63a7bq X-Rspamd-Queue-Id: 471604001E X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=weissschuh.net header.s=mail header.b=Qa9qhGRL; dmarc=none; spf=pass (imf04.hostedemail.com: domain of linux@weissschuh.net designates 159.69.126.157 as permitted sender) smtp.mailfrom=linux@weissschuh.net X-Rspamd-Server: rspam11 X-HE-Tag: 1664361958-357447 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Thomas Weißschuh Without this check open() will open large files on tmpfs although O_LARGEFILE was not specified. This is inconsistent with other filesystems. Also it will later result in EOVERFLOW on stat() or EFBIG on write(). Link: https://lore.kernel.org/lkml/76bedae6-22ea-4abc-8c06-b424ceb39217@t-8ch.de/ Signed-off-by: Thomas Weißschuh Acked-by: Hugh Dickins --- mm/shmem.c | 1 + 1 file changed, 1 insertion(+) base-commit: f76349cf41451c5c42a99f18a9163377e4b364ff diff --git a/mm/shmem.c b/mm/shmem.c index 42e5888bf84d..902c5550fabc 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -3876,6 +3876,7 @@ EXPORT_SYMBOL(shmem_aops); static const struct file_operations shmem_file_operations = { .mmap = shmem_mmap, + .open = generic_file_open, .get_unmapped_area = shmem_get_unmapped_area, #ifdef CONFIG_TMPFS .llseek = shmem_file_llseek,