[RFC,UKL,02/10] x86/boot: Load the PT_TLS segment for Unikernel configs

Commit Message

Ali Raza Oct. 3, 2022, 10:21 p.m. UTC

The kernel normally skips loading this segment as it is not inlcuded in
standard builds. However, when linked with an application in the Unikernel
configuration the segment will be present. Load PT_TLS when configured as a
unikernel.

Cc: Jonathan Corbet <[e-mail]>
Cc: Masahiro Yamada <[e-mail]>
Cc: Michal Marek <[e-mail]>
Cc: Nick Desaulniers <[e-mail]>
Cc: Thomas Gleixner <[e-mail]>
Cc: Ingo Molnar <[e-mail]>
Cc: Borislav Petkov <[e-mail]>
Cc: Dave Hansen <[e-mail]>
Cc: "H. Peter Anvin" <[e-mail]>
Cc: Andy Lutomirski <[e-mail]>
Cc: Eric Biederman <[e-mail]>
Cc: Kees Cook <[e-mail]>
Cc: Peter Zijlstra <[e-mail]>
Cc: Alexander Viro <[e-mail]>
Cc: Arnd Bergmann <[e-mail]>
Cc: Juri Lelli <[e-mail]>
Cc: Vincent Guittot <[e-mail]>
Cc: Dietmar Eggemann <[e-mail]>
Cc: Steven Rostedt <[e-mail]>
Cc: Ben Segall <[e-mail]>
Cc: Mel Gorman <[e-mail]>
Cc: Daniel Bristot de Oliveira <[e-mail]>
Cc: Valentin Schneider <[e-mail]>
Cc: Paolo Bonzini <[e-mail]>
Cc: Josh Poimboeuf <[e-mail]>

Signed-off-by: Ali Raza <[e-mail]>
---
 arch/x86/boot/compressed/misc.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Andy Lutomirski Oct. 4, 2022, 5:30 p.m. UTC | #1

On Mon, Oct 3, 2022, at 3:21 PM, Ali Raza wrote:
> The kernel normally skips loading this segment as it is not inlcuded in
> standard builds. However, when linked with an application in the Unikernel
> configuration the segment will be present. Load PT_TLS when configured as a
> unikernel.
>
> Cc: Jonathan Corbet <[e-mail]>
> Cc: Masahiro Yamada <[e-mail]>
> Cc: Michal Marek <[e-mail]>
> Cc: Nick Desaulniers <[e-mail]>
> Cc: Thomas Gleixner <[e-mail]>
> Cc: Ingo Molnar <[e-mail]>
> Cc: Borislav Petkov <[e-mail]>
> Cc: Dave Hansen <[e-mail]>
> Cc: "H. Peter Anvin" <[e-mail]>
> Cc: Andy Lutomirski <[e-mail]>
> Cc: Eric Biederman <[e-mail]>
> Cc: Kees Cook <[e-mail]>
> Cc: Peter Zijlstra <[e-mail]>
> Cc: Alexander Viro <[e-mail]>
> Cc: Arnd Bergmann <[e-mail]>
> Cc: Juri Lelli <[e-mail]>
> Cc: Vincent Guittot <[e-mail]>
> Cc: Dietmar Eggemann <[e-mail]>
> Cc: Steven Rostedt <[e-mail]>
> Cc: Ben Segall <[e-mail]>
> Cc: Mel Gorman <[e-mail]>
> Cc: Daniel Bristot de Oliveira <[e-mail]>
> Cc: Valentin Schneider <[e-mail]>
> Cc: Paolo Bonzini <[e-mail]>
> Cc: Josh Poimboeuf <[e-mail]>
>
> Signed-off-by: Ali Raza <[e-mail]>
> ---
>  arch/x86/boot/compressed/misc.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
> index cf690d8712f4..0d07b5661c9c 100644
> --- a/arch/x86/boot/compressed/misc.c
> +++ b/arch/x86/boot/compressed/misc.c
> @@ -310,6 +310,9 @@ static void parse_elf(void *output)
>  		phdr = &phdrs[i];
> 
>  		switch (phdr->p_type) {
> +#ifdef CONFIG_UNIKERNEL_LINUX
> +		case PT_TLS:
> +#endif

Can you explain why exactly a Linux boot image would have a TLS segment?  What does it do?

>  		case PT_LOAD:
>  #ifdef CONFIG_X86_64
>  			if ((phdr->p_align % 0x200000) != 0)
> -- 
> 2.21.3

Ali Raza Oct. 6, 2022, 9 p.m. UTC | #2

On 10/4/22 13:30, Andy Lutomirski wrote:
> On Mon, Oct 3, 2022, at 3:21 PM, Ali Raza wrote:
>> The kernel normally skips loading this segment as it is not inlcuded in
>> standard builds. However, when linked with an application in the Unikernel
>> configuration the segment will be present. Load PT_TLS when configured as a
>> unikernel.
>>
>> Cc: Jonathan Corbet <[e-mail]>
>> Cc: Masahiro Yamada <[e-mail]>
>> Cc: Michal Marek <[e-mail]>
>> Cc: Nick Desaulniers <[e-mail]>
>> Cc: Thomas Gleixner <[e-mail]>
>> Cc: Ingo Molnar <[e-mail]>
>> Cc: Borislav Petkov <[e-mail]>
>> Cc: Dave Hansen <[e-mail]>
>> Cc: "H. Peter Anvin" <[e-mail]>
>> Cc: Andy Lutomirski <[e-mail]>
>> Cc: Eric Biederman <[e-mail]>
>> Cc: Kees Cook <[e-mail]>
>> Cc: Peter Zijlstra <[e-mail]>
>> Cc: Alexander Viro <[e-mail]>
>> Cc: Arnd Bergmann <[e-mail]>
>> Cc: Juri Lelli <[e-mail]>
>> Cc: Vincent Guittot <[e-mail]>
>> Cc: Dietmar Eggemann <[e-mail]>
>> Cc: Steven Rostedt <[e-mail]>
>> Cc: Ben Segall <[e-mail]>
>> Cc: Mel Gorman <[e-mail]>
>> Cc: Daniel Bristot de Oliveira <[e-mail]>
>> Cc: Valentin Schneider <[e-mail]>
>> Cc: Paolo Bonzini <[e-mail]>
>> Cc: Josh Poimboeuf <[e-mail]>
>>
>> Signed-off-by: Ali Raza <[e-mail]>
>> ---
>>  arch/x86/boot/compressed/misc.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
>> index cf690d8712f4..0d07b5661c9c 100644
>> --- a/arch/x86/boot/compressed/misc.c
>> +++ b/arch/x86/boot/compressed/misc.c
>> @@ -310,6 +310,9 @@ static void parse_elf(void *output)
>>  		phdr = &phdrs[i];
>>
>>  		switch (phdr->p_type) {
>> +#ifdef CONFIG_UNIKERNEL_LINUX
>> +		case PT_TLS:
>> +#endif
> 
> Can you explain why exactly a Linux boot image would have a TLS segment?  What does it do?

Thank you for taking the time to review the patch. 

A UKL boot image will have a TLS segment if an application has it, or is
linked with glibc, and the resulting binary is then linked with the
kernel. This will allow applications depending on TLS to function
without modification in the UKL setting.

That is why, the first patch in this series adds TLS section to the
kernel linker script. Also, if you use an application binary that does
not have a TLS section (like the one given with this patchset in
samples/ukl), you can turn it off through the CONFIG_UKL_TLS option.
This means the size of the TLS section would be zero and this code will
effectively not load anything.

> 
>>  		case PT_LOAD:
>>  #ifdef CONFIG_X86_64
>>  			if ((phdr->p_align % 0x200000) != 0)
>> -- 
>> 2.21.3

Patch

diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
index cf690d8712f4..0d07b5661c9c 100644
--- a/arch/x86/boot/compressed/misc.c
+++ b/arch/x86/boot/compressed/misc.c
@@ -310,6 +310,9 @@  static void parse_elf(void *output)
 		phdr = &phdrs[i];
 
 		switch (phdr->p_type) {
+#ifdef CONFIG_UNIKERNEL_LINUX
+		case PT_TLS:
+#endif
 		case PT_LOAD:
 #ifdef CONFIG_X86_64
 			if ((phdr->p_align % 0x200000) != 0)