From patchwork Tue Oct 18 15:26:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Chancellor X-Patchwork-Id: 13010756 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47225C433FE for ; Tue, 18 Oct 2022 15:27:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83FC96B0072; Tue, 18 Oct 2022 11:27:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C90B6B0075; Tue, 18 Oct 2022 11:27:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 690B86B0078; Tue, 18 Oct 2022 11:27:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 55C086B0072 for ; Tue, 18 Oct 2022 11:27:37 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 21B36404F3 for ; Tue, 18 Oct 2022 15:27:37 +0000 (UTC) X-FDA: 80034449754.07.6ACE284 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf11.hostedemail.com (Postfix) with ESMTP id 70DC040015 for ; Tue, 18 Oct 2022 15:27:35 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C67F1B81BFB; Tue, 18 Oct 2022 15:27:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5B8AC433C1; Tue, 18 Oct 2022 15:27:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666106852; bh=ndYwEDeqYYf4sJcQ9WB423y7Tx/pDZ5xDnUm1T2vjNg=; h=From:To:Cc:Subject:Date:From; b=CpLiFvwhxFyJUQGrqKFPYaQRniijzGx0jLG31Dy+yGr2tkELrWR415sTtbsx4TTA2 URCcynPkdMHjuB0hEgY6DSKXGUVuEpfBvjq7QT39MIuJz23UlelcqoYEacuPYt/6g6 If/P3tMGCjPT6/SdnDaZXUFRM8Z+VpchrR+LKbCaihSrF4TVksVMoyAsktduG2klHm gcyUbW1nOQXJH0nBOPoelJrEIR/uZQp2i8fE8ZQtG6LU0b4I6yVxzZRt2o5yqHO4H0 zEKczOCamb8aKxGy5Kdmcye/VXvGpY+HF1TM6S7PAXW/ap4x1GsB6PvcnWGe5xtzv6 D7LNE+8Cy6OaA== From: Nathan Chancellor To: Andrew Morton , Dan Williams Cc: Nick Desaulniers , Tom Rix , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev, Nathan Chancellor Subject: [PATCH] mm/memremap: Mark folio_span_valid() as __maybe_unused Date: Tue, 18 Oct 2022 08:26:46 -0700 Message-Id: <20221018152645.3195108-1-nathan@kernel.org> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666106855; a=rsa-sha256; cv=none; b=ZeqGYifUffe7/5WlZ7yacKZvq7mrMl3RCQDXi18KuqbxssHqc4aohBHaA9WvA1MeLYUeZs 73eZbt378hLw9GiluBChyFIvrvIXNDiChlWPDDJGYqzs4VAsHtEUUqjsXt+awm2bajWX2w PxigfcyhlLlwHE5UhIbpUQa2M7GLQME= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CpLiFvwh; spf=pass (imf11.hostedemail.com: domain of nathan@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666106855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=lFFcvFl+0U7wETucj6Hv9a1n5ZlQOQIp41teajtgkBY=; b=Ghk6TbtYAROqZT9yWAY0FNEnPYZGsgIIlbTv2dhyvWVEegleMaxy+7mzzoFamcSzS/PaNV xNDkJr+RQ2YX/T29DyuIyp8Sz/bpuMRPjO9T6OBO0bdFAq2aba+og7hqIPmXLnVMhfl1b0 Vq9w50nrAusP2hn/ipiCBCDVFtWlF2I= X-Stat-Signature: 3sdo67iphwj538jin4rknscwa7jaak51 X-Rspamd-Queue-Id: 70DC040015 X-Rspam-User: X-Rspamd-Server: rspam03 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CpLiFvwh; spf=pass (imf11.hostedemail.com: domain of nathan@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1666106855-930613 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When building without CONFIG_DEBUG_VM, clang warns: mm/memremap.c:495:13: error: function 'folio_span_valid' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration] static bool folio_span_valid(struct dev_pagemap *pgmap, struct folio *folio, ^ 1 error generated. folio_span_valid() is only used within a instance of VM_WARN_ON_ONCE(), which evaluates to BUILD_BUG_ON_INVALID() with CONFIG_DEBUG_VM=n, which ultimately resolves to sizeof(), which is fully resolved at compile time. Basically, the warning is flagging that folio_span_valid() is only used in a compile time context and will not be called at run time. Since this is expected given the configuration, mark folio_span_valid() as __maybe_unused so that there is no warning. Fixes: 07108d5bfeeb ("fsdax: introduce pgmap_request_folios()") Link: https://github.com/ClangBuiltLinux/linux/issues/1739 Signed-off-by: Nathan Chancellor --- I am aware the Fixes SHA is probably not stable but I figured I would include it anyways. mm/memremap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) base-commit: f5938bbbb79d48ca167e305c228dccbecea0309e diff --git a/mm/memremap.c b/mm/memremap.c index 53fe30bb79bb..02b796749b72 100644 --- a/mm/memremap.c +++ b/mm/memremap.c @@ -492,8 +492,9 @@ void free_zone_device_page(struct page *page) put_dev_pagemap(page->pgmap); } -static bool folio_span_valid(struct dev_pagemap *pgmap, struct folio *folio, - int nr_folios) +static __maybe_unused bool folio_span_valid(struct dev_pagemap *pgmap, + struct folio *folio, + int nr_folios) { unsigned long pfn_start, pfn_end;