diff mbox series

[v2,6/7] mm: vmalloc: Use trace_free_vmap_area_noflush event

Message ID 20221018181053.434508-7-urezki@gmail.com (mailing list archive)
State New
Headers show
Series Add basic trace events for vmap/vmalloc (v2) | expand

Commit Message

Uladzislau Rezki Oct. 18, 2022, 6:10 p.m. UTC 
It is for a debug purpose and is called when a vmap area
gets freed. This event gives some indication about:
- a start address of released area;
- a current number of outstanding pages;
- a maximum number of allowed outstanding pages.

Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
---
 mm/vmalloc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Christoph Hellwig Oct. 20, 2022, 11:25 a.m. UTC | #1 
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 4292f44ae670..bd56f68bedf0 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1822,6 +1822,8 @@  static void drain_vmap_area_work(struct work_struct *work)
  */
 static void free_vmap_area_noflush(struct vmap_area *va)
 {
+	unsigned long nr_lazy_max = lazy_max_pages();
+	unsigned long va_start = va->va_start;
 	unsigned long nr_lazy;
 
 	spin_lock(&vmap_area_lock);
@@ -1839,8 +1841,10 @@  static void free_vmap_area_noflush(struct vmap_area *va)
 		&purge_vmap_area_root, &purge_vmap_area_list);
 	spin_unlock(&purge_vmap_area_lock);
 
+	trace_free_vmap_area_noflush(va_start, nr_lazy, nr_lazy_max);
+
 	/* After this point, we may free va at any time */
-	if (unlikely(nr_lazy > lazy_max_pages()))
+	if (unlikely(nr_lazy > nr_lazy_max))
 		schedule_work(&drain_vmap_work);
 }