From patchwork Fri Oct 21 16:36:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Houghton X-Patchwork-Id: 13015072 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D382FA373E for ; Fri, 21 Oct 2022 16:37:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F13798E0006; Fri, 21 Oct 2022 12:37:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9C968E0001; Fri, 21 Oct 2022 12:37:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA18E8E0006; Fri, 21 Oct 2022 12:37:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B8CC38E0001 for ; Fri, 21 Oct 2022 12:37:19 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8F7E7140C26 for ; Fri, 21 Oct 2022 16:37:19 +0000 (UTC) X-FDA: 80045511798.29.1F76339 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf16.hostedemail.com (Postfix) with ESMTP id 273ED180033 for ; Fri, 21 Oct 2022 16:37:18 +0000 (UTC) Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-352e29ff8c2so34074357b3.21 for ; Fri, 21 Oct 2022 09:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=lZUN9P7JGIQHPnquxx9reV3Jbe3B3qBfX9sZ+LRQm7o=; b=GJoNeaGDjwD1Fl1cyhHuK2aLhzkgPOKG7HEw7TkRJFgoz4poH2nLCE3sHMXaMDFunc w58AGv5zD/ndOCN5807bGBahVC5t3I4qD5n2viZgEwpgYmeuPO+w8ZUmQC0tetwyZma6 tnt+SbOGRucmBwJ4t0wW+XGY70fiV6i1Si6lkcLf27swVkRoOYIPAlkG/JqDsto1XLnY Mc9LriuigNU7e6Dt/Y1OKV5sJg/o96ytQuNXvUjynTNWGnVUG1Ap7CSa0NXR3xqkTQw9 i4dLRfrG2R7TcYitFjvdRgvivePstzTsFNXsq03qGK/00RpCzirkjyJ+wubBLyXDN6fR YW/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lZUN9P7JGIQHPnquxx9reV3Jbe3B3qBfX9sZ+LRQm7o=; b=lmW+/uzPX4jQNMaBnA6/HDjq2whbdtv643EDu5EhMTYgBaVT2QhkaAzxgZ8/Z9sq2d keln1Uy178gZ86nD8QQDLK3i+xE5K1iyw2n1pEBafWGe7v5ZUzwBRA9FE7993j5/MTTs PWIE0vXgxKFSTJhWGz2nw6LkA57fecxmDmwnMzJIdybChq/0O8ffDGkwNzPauSCT4BSZ ymzB816EtkwwPC/si45VCF5KXuQ/Jv7Q9a2McXhnnURHBtf5K8tk1cl+xAGt+H5Nkud8 wPtQLOFiYp/9XM9hcnaVpOvTyaxG7xPrX/ftqIda9h/xy93ccVeRVb7Pd3VUNA9rJYOP Cl6w== X-Gm-Message-State: ACrzQf0+cXOaXHtLSrVou6WHvyY7DeAPoYW0SsZLEdcGzBbXxBq9b8Xs fNU/LFTYSxJwJqCy9MJVsclyg3YTwT/rrAY3 X-Google-Smtp-Source: AMsMyM6glgNF0xzBVlnv9CGZLhulgQ4Bomw5BBvj+Pqsya/BXuBbeRDw2FnYNlQBJbKk9FqkELlNYTzbRdED6jS4 X-Received: from jthoughton.c.googlers.com ([fda3:e722:ac3:cc00:14:4d90:c0a8:2a4f]) (user=jthoughton job=sendgmr) by 2002:a81:383:0:b0:350:9b62:60bc with SMTP id 125-20020a810383000000b003509b6260bcmr17608845ywd.514.1666370238413; Fri, 21 Oct 2022 09:37:18 -0700 (PDT) Date: Fri, 21 Oct 2022 16:36:19 +0000 In-Reply-To: <20221021163703.3218176-1-jthoughton@google.com> Mime-Version: 1.0 References: <20221021163703.3218176-1-jthoughton@google.com> X-Mailer: git-send-email 2.38.0.135.g90850a2211-goog Message-ID: <20221021163703.3218176-4-jthoughton@google.com> Subject: [RFC PATCH v2 03/47] hugetlb: remove redundant pte_mkhuge in migration path From: James Houghton To: Mike Kravetz , Muchun Song , Peter Xu Cc: David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , "Zach O'Keefe" , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=GJoNeaGD; spf=pass (imf16.hostedemail.com: domain of 3vspSYwoKCL8oymtzlmytslttlqj.htrqnsz2-rrp0fhp.twl@flex--jthoughton.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3vspSYwoKCL8oymtzlmytslttlqj.htrqnsz2-rrp0fhp.twl@flex--jthoughton.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666370239; a=rsa-sha256; cv=none; b=vlk8oxAXzDq1LsBcSh2I5sPfgGFx48/XTcUz8F/Gkg/GHVItGpY6rDwMxy9uwy0MBSG0m9 zfdjoooE1b7vZ/BVb4MAnn0afbUNcDpgY+1tYdVHYteHD2rtSUi1BIyw5Q4aXkT3beysVp cZuzVjW/KsIaaLSk73GvCUeaCAzbatQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666370239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lZUN9P7JGIQHPnquxx9reV3Jbe3B3qBfX9sZ+LRQm7o=; b=Cv6YZ1oA5QuHb1XVEBsIdNmmEx3o6+Nigi05PSK0xjyBOzVy13ie72MXKnw+sVzR/MZ3vl 8b75uCQgwd4eJXyXTaxbirYRFVFn1bKSmoeipVu64AlKzBC/hUUOJhBS4/jk79eHv3jh5z C5CQD/8214JU7a//DIPHnSbX/pngVRw= X-Stat-Signature: 5834m7665cg8yt4a3q5t6w96p1kcxmzp X-Rspamd-Queue-Id: 273ED180033 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=GJoNeaGD; spf=pass (imf16.hostedemail.com: domain of 3vspSYwoKCL8oymtzlmytslttlqj.htrqnsz2-rrp0fhp.twl@flex--jthoughton.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3vspSYwoKCL8oymtzlmytslttlqj.htrqnsz2-rrp0fhp.twl@flex--jthoughton.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam06 X-HE-Tag: 1666370238-535234 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: arch_make_huge_pte, which is called immediately following pte_mkhuge, already makes the necessary changes to the PTE that pte_mkhuge would have. The generic implementation of arch_make_huge_pte simply calls pte_mkhuge. Signed-off-by: James Houghton Acked-by: Peter Xu Acked-by: Mina Almasry Reviewed-by: Mike Kravetz --- mm/migrate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/migrate.c b/mm/migrate.c index 8e5eb6ed9da2..1457cdbb7828 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -237,7 +237,6 @@ static bool remove_migration_pte(struct folio *folio, if (folio_test_hugetlb(folio)) { unsigned int shift = huge_page_shift(hstate_vma(vma)); - pte = pte_mkhuge(pte); pte = arch_make_huge_pte(pte, shift, vma->vm_flags); if (folio_test_anon(folio)) hugepage_add_anon_rmap(new, vma, pvmw.address,