From patchwork Wed Oct 26 12:00:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukas Bulwahn X-Patchwork-Id: 13020509 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B74A8C433FE for ; Wed, 26 Oct 2022 12:01:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 465858E0003; Wed, 26 Oct 2022 08:01:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 414A28E0001; Wed, 26 Oct 2022 08:01:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DD548E0003; Wed, 26 Oct 2022 08:01:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 203D18E0001 for ; Wed, 26 Oct 2022 08:01:08 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D65E2C0F6E for ; Wed, 26 Oct 2022 12:01:07 +0000 (UTC) X-FDA: 80062959774.14.DC1CC7A Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf12.hostedemail.com (Postfix) with ESMTP id EF29640034 for ; Wed, 26 Oct 2022 12:01:06 +0000 (UTC) Received: by mail-ed1-f45.google.com with SMTP id x2so13778060edd.2 for ; Wed, 26 Oct 2022 05:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=eCtqGBwRR52BjUb2Wh7FLafniFKggPInKgSqsTGAvt0=; b=leGA4qoyrfWu79SeDDY1Fpo34CYPzzjLv68Ja1abwz+SMwx1nPmuvDTz1TDqpIatxk 3RpcqHN5wUmk14raenigd1/dCfWPgu02Mcro/BOa/EDedD2UJcYRcE+GxYpGyva10ZwX JODRghr9tCLi8eWJawFMZ7+PIS19+3gyxhbPzNi+qQX3XkZboKHABroQ0h7Qiwm55U3L H5gHn2nXTessOqFZxDrZ5TQYYscZBkEp15vI3ZXC3aNaS00JRD5aZrILQhUOY9WlR/0Z uSR0ZIra0x4coQA9R/cBeF1uiGWGH2QlKD1/ULE44TBzkuK6u6EmR98B7xbmkYgSmmOG J9xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eCtqGBwRR52BjUb2Wh7FLafniFKggPInKgSqsTGAvt0=; b=pcSax2Rq4VB3FCioZr7Kpu0hkNJsyLgAY/ixN7Yi4zHDaJERb4kNah+71rruRZPDSK qXi0cz17z49kpNrAZC7U7E9xpGTomT+Zx/TLHtFDQKy682bnn2qAl6Wu02ycNc0Efe0A aTAlt/SYxdbPJ/hvGy2lmUAYFCzMwNwJ0d0zwTvPWpibI0rynxtT+TPQJi9EoavRzbGi MNpFOb4c1BCtq7h1545cQooc7W3RK2+Lxy7mBI6ikgcrWiTI5EsQ3XoPSO4vDpzmrD+Q uN1A9eqm+oWteeU/CH1Ipmr7z8O6Z/m2WRmnMeWdoUpfQlUXHxjSNanN45pGMGufJGI6 9C1Q== X-Gm-Message-State: ACrzQf3BSlH/A6IexHiax67oev/paDJC9NZ9nRAvSaDVpFpQbNvQWGNU WFqXnrXwfaMuf43TNfQqTs8= X-Google-Smtp-Source: AMsMyM4S2WOpYB7baEE7G/A5nEFun1gaZ1VPWURaDzAg4GG41p/l6TvGEF3Y7ZSEwi5jJcOhKde5/w== X-Received: by 2002:a05:6402:11ce:b0:45c:a364:2c3d with SMTP id j14-20020a05640211ce00b0045ca3642c3dmr41106701edw.204.1666785665669; Wed, 26 Oct 2022 05:01:05 -0700 (PDT) Received: from felia.fritz.box (200116b826195000091b3ab8e8f9a156.dip.versatel-1u1.de. [2001:16b8:2619:5000:91b:3ab8:e8f9:a156]) by smtp.gmail.com with ESMTPSA id ky21-20020a170907779500b00788c622fa2csm2872760ejc.135.2022.10.26.05.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 05:01:04 -0700 (PDT) From: Lukas Bulwahn To: "Liam R . Howlett" , Matthew Wilcox , Andrew Morton , linux-mm@kvack.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH 1/1] lib: maple_tree: remove unneeded initialization in mtree_range_walk() Date: Wed, 26 Oct 2022 14:00:29 +0200 Message-Id: <20221026120029.12555-2-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221026120029.12555-1-lukas.bulwahn@gmail.com> References: <20221026120029.12555-1-lukas.bulwahn@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666785667; a=rsa-sha256; cv=none; b=Gr0S1/I2SYkS4AWg7PO66ulIoqmlJDhoc2Pw5sK/q1V51Qp0ADtcPuNz3K+kbRCEDCCfIW opIIc8gWTjphsi0ineWc5hVDKOAzSXfg4DYdEUI9KOFnVV+sUcgJbiGDnwsywhv4uEGv9G 7Qylg9VxDvBomLJrY83UlP3v0kq646U= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=leGA4qoy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of lukas.bulwahn@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=lukas.bulwahn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666785667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=eCtqGBwRR52BjUb2Wh7FLafniFKggPInKgSqsTGAvt0=; b=v7LPqn9IUvCyPjpmhbyt/0ZRclyam+zk0VewTOKF2Iiotak0IyzUdcy1QBNZBGQW+JOv+D u/Y+XAaY34AdMuR2m7wnbzidSGWREFNe6Su7BuwzkVTcmYrZe5Q7VHNr5B98kgdhBhI+IF I/1ioVu4c0vpJYHW4pjPUBvKZ+AzzDU= X-Stat-Signature: dzmoc7351x8grgdig3gsfh5xfxwmfjca X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EF29640034 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=leGA4qoy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of lukas.bulwahn@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=lukas.bulwahn@gmail.com X-HE-Tag: 1666785666-786135 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Before the do-while loop in mtree_range_walk(), the variables next, min, max need to be initialized. The variables last, prev_min and prev_max are set within the loop body before they are eventually used after exiting the loop body. As it is a do-while loop, the loop body is executed at least once, so the variables last, prev_min and prev_max do not need to be initialized before the loop body. Remove unneeded initialization of last and prev_min. The needless initialization was reported by clang-analyzer as Dead Stores. As the compiler already identifies these assignments as unneeded, it optimizes the assignments away. Hence: No functional change. No change in object code. Signed-off-by: Lukas Bulwahn Reviewed-by: Liam R. Howlett --- lib/maple_tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/maple_tree.c b/lib/maple_tree.c index e1743803c851..fbde494444b8 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -2903,8 +2903,8 @@ static inline void *mtree_range_walk(struct ma_state *mas) unsigned long max, min; unsigned long prev_max, prev_min; - last = next = mas->node; - prev_min = min = mas->min; + next = mas->node; + min = mas->min; max = mas->max; do { offset = 0;