| Message ID | 20221110030751.1627266-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/demotion: Fix NULL vs IS_ERR checking in memory_tier_init | expand |
Miaoqian Lin <linmq006@gmail.com> writes: > The alloc_memory_type() function return error pointers on error > instead of NULL. > Use IS_ERR() to check the return value to fix this. > > Fixes: 7b88bda3761b ("mm/demotion/dax/kmem: set node's abstract distance to MEMTIER_DEFAULT_DAX_ADISTANCE") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Thanks! Reviewed-by: "Huang, Ying" <ying.huang@intel.com> > --- > mm/memory-tiers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index fa8c9d07f9ce..ac0dae9e54bf 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -645,7 +645,7 @@ static int __init memory_tier_init(void) > * than default DRAM tier. > */ > default_dram_type = alloc_memory_type(MEMTIER_ADISTANCE_DRAM); > - if (!default_dram_type) > + if (IS_ERR(default_dram_type)) > panic("%s() failed to allocate default DRAM tier\n", __func__); > > /*
diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index fa8c9d07f9ce..ac0dae9e54bf 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -645,7 +645,7 @@ static int __init memory_tier_init(void) * than default DRAM tier. */ default_dram_type = alloc_memory_type(MEMTIER_ADISTANCE_DRAM); - if (!default_dram_type) + if (IS_ERR(default_dram_type)) panic("%s() failed to allocate default DRAM tier\n", __func__); /*
The alloc_memory_type() function return error pointers on error instead of NULL. Use IS_ERR() to check the return value to fix this. Fixes: 7b88bda3761b ("mm/demotion/dax/kmem: set node's abstract distance to MEMTIER_DEFAULT_DAX_ADISTANCE") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- mm/memory-tiers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)