From patchwork Thu Nov 10 06:53:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lu Jialin X-Patchwork-Id: 13038363 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08F77C433FE for ; Thu, 10 Nov 2022 07:02:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CD8E6B0071; Thu, 10 Nov 2022 02:02:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 17E1A6B0072; Thu, 10 Nov 2022 02:02:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06D226B0074; Thu, 10 Nov 2022 02:02:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ECD816B0071 for ; Thu, 10 Nov 2022 02:02:14 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BFF661A0960 for ; Thu, 10 Nov 2022 07:02:14 +0000 (UTC) X-FDA: 80116638588.25.E1B323B Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf07.hostedemail.com (Postfix) with ESMTP id 7A92640007 for ; Thu, 10 Nov 2022 07:02:12 +0000 (UTC) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4N7CHG4qjLzJnZY; Thu, 10 Nov 2022 14:54:02 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 10 Nov 2022 14:57:04 +0800 Received: from ubuntu1804.huawei.com (10.67.174.175) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 10 Nov 2022 14:57:04 +0800 From: Lu Jialin To: Johannes Weiner , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song CC: Lu Jialin , , , Subject: [PATCH] mm/memcontrol.c: drains percpu charge caches in memory.reclaim Date: Thu, 10 Nov 2022 14:53:16 +0800 Message-ID: <20221110065316.67204-1-lujialin4@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.67.174.175] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668063734; a=rsa-sha256; cv=none; b=qTk8aelJUnutO7Z/QlkZCym/iP8Hl31bLGZ42Ud5rhJEX0vhuYJJiXn3/nHxYyksqYbQKf /F9F/1ILbf4KVeHtiizql9OkiwZQCDkvBS5Rho8Gx5U1qs3xn4PFTCdZk6qe7qLxSubuG7 jfGdnQNOfpk9z8jNbFQXbpgi1GX9IM4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of lujialin4@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=lujialin4@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668063734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=EWxKRFOmKADNnzF1Aod+jnkWVfK1/B27gMLsjTAJHmQ=; b=iEOjoPv0NG6WqWAxnjQoy6Woz2wrf8L2U6ay/VugktQs7anJS2PdkI066InY18dJ66uqHl khovH4/2EmfkRyRgp7KySp9w5s692D0zaJFY29mVWhHuTEp/r+dKuiPPx6kYkdric7W8qs 3G9AYN7SMsa9zk8+2pnL7XjRuw+uUo4= Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of lujialin4@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=lujialin4@huawei.com X-Rspam-User: X-Stat-Signature: 918sgzwpuiuuopgqptzhw4g8hba6cmzf X-Rspamd-Queue-Id: 7A92640007 X-Rspamd-Server: rspam05 X-HE-Tag: 1668063732-666196 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When user use memory.reclaim to reclaim memory, after drain percpu lru caches, drain percpu charge caches for given memcg stock in the hope of introducing more evictable pages. Signed-off-by: Lu Jialin --- mm/memcontrol.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 2d8549ae1b30..768091cc6a9a 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -6593,10 +6593,13 @@ static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf, /* * This is the final attempt, drain percpu lru caches in the * hope of introducing more evictable pages for - * try_to_free_mem_cgroup_pages(). + * try_to_free_mem_cgroup_pages(). Also, drain all percpu + * charge caches for given memcg. */ - if (!nr_retries) + if (!nr_retries) { lru_add_drain_all(); + drain_all_stock(memcg); + } reclaimed = try_to_free_mem_cgroup_pages(memcg, nr_to_reclaim - nr_reclaimed,