| Message ID | 20221114182954.4745-3-sj@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/damon/sysfs-schemes: avoid updating | expand |
diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 4df3c99983e8..e6baf55d617d 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -1260,6 +1260,10 @@ int damon_sysfs_schemes_clear_regions( damon_for_each_scheme(scheme, ctx) { struct damon_sysfs_scheme *sysfs_scheme; + /* user could removed the scheme sysfs dir */ + if (schemes_idx >= sysfs_schemes->nr) + break; + sysfs_scheme = sysfs_schemes->schemes_arr[schemes_idx++]; damon_sysfs_scheme_regions_rm_dirs( sysfs_scheme->tried_regions);
A DAMON sysfs interface user can start DAMON with a scheme, remove the sysfs directory for the scheme, and then ask clearing of the scheme's tried regions. Because the schemes tried regions clearing logic doesn't aware of the situation, it results in an invalid memory access. Fix the bug by checking if the scheme sysfs directory exists. Fixes: bb9641eb3a3e ("mm/damon/sysfs-schemes: implement DAMOS-tried regions clear command") # mm-unstable Signed-off-by: SeongJae Park <sj@kernel.org> --- mm/damon/sysfs-schemes.c | 4 ++++ 1 file changed, 4 insertions(+)