From patchwork Mon Dec 5 03:41:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: mawupeng X-Patchwork-Id: 13064111 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C808AC4321E for ; Mon, 5 Dec 2022 03:41:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DA398E0007; Sun, 4 Dec 2022 22:41:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C43288E0005; Sun, 4 Dec 2022 22:41:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FD388E0007; Sun, 4 Dec 2022 22:41:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7FB408E0005 for ; Sun, 4 Dec 2022 22:41:28 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5C71C80179 for ; Mon, 5 Dec 2022 03:41:28 +0000 (UTC) X-FDA: 80206852656.17.FDC8638 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf26.hostedemail.com (Postfix) with ESMTP id 7CCF7140006 for ; Mon, 5 Dec 2022 03:41:26 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670211688; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xKn90cRs20tjV+2ypNKNISYfa3aiejQalfBolX0oqB4=; b=Rn/eA9eo+D1iRQtFuo5Y/o/4CMOmhNXka/fRuc7z4d3B9ONDyRUrQNF+CyrFwKmnBcY63j jplcB6YtlTNU5od1KCdy+cWHYhPGqIk9F+peCctpfxFJxF2FmvGQz5uscK5GMYIv/pjLMz u3OOhMnYEPl7eSMhLaJqasOXNilH2vI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670211688; a=rsa-sha256; cv=none; b=4Kx8J+EllNC/QetlYKzIc+6qkkKlJN7IBPY9vnO0WdL9CSdzcCaTrGXvgb2rrybIZCyGnG SOXexCWvYUZLz4kkDBTmYC93+WNRpW1NwGleDN01meB5c37qPxd6ejDyC8VpP89uQVOC2N XxGJZSS9trkqpiOdC5w7f4L3oCQxkCw= Received: from dggpemm500014.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NQTpX55rrzmVdp; Mon, 5 Dec 2022 11:40:36 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 5 Dec 2022 11:41:23 +0800 From: Wupeng Ma To: CC: , , , , , Subject: [PATCH 3/4] mm/mempolicy: return EINVAL for illegal user memory range for mbind Date: Mon, 5 Dec 2022 11:41:07 +0800 Message-ID: <20221205034108.3365182-4-mawupeng1@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221205034108.3365182-1-mawupeng1@huawei.com> References: <20221205034108.3365182-1-mawupeng1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7CCF7140006 X-Stat-Signature: soz37gf9bmx9w8ano85jcdfjk1z9kpbf X-Spamd-Result: default: False [-0.04 / 9.00]; BAYES_HAM(-2.84)[91.05%]; R_MISSING_CHARSET(2.50)[]; MID_CONTAINS_FROM(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[huawei.com,quarantine]; R_SPF_ALLOW(-0.20)[+ip4:45.249.212.187/29:c]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_SEVEN(0.00)[7]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; MIME_TRACE(0.00)[0:+]; HAS_XOIP(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; TO_DN_NONE(0.00)[]; ARC_NA(0.00)[] X-Rspam-User: X-HE-Tag: 1670211686-367751 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Ma Wupeng Add access_ok to check user memory range and return EINVAL if overflows for mbind. Signed-off-by: Ma Wupeng --- mm/mempolicy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index e3a2c465fe8a..a6bddf454953 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1272,6 +1272,9 @@ static long do_mbind(unsigned long start, unsigned long len, if (start & ~PAGE_MASK) return -EINVAL; + if (unlikely(!access_ok((void __user *)start, len))) + return -EINVAL; + if (mode == MPOL_DEFAULT) flags &= ~MPOL_MF_STRICT;