From patchwork Wed Dec 21 00:12:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Zhao X-Patchwork-Id: 13078281 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9489DC41535 for ; Wed, 21 Dec 2022 00:12:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 275D5940007; Tue, 20 Dec 2022 19:12:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 22607900002; Tue, 20 Dec 2022 19:12:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 113E4940007; Tue, 20 Dec 2022 19:12:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F2CC1900002 for ; Tue, 20 Dec 2022 19:12:48 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B1023C01CA for ; Wed, 21 Dec 2022 00:12:48 +0000 (UTC) X-FDA: 80264387616.08.6E2C913 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf10.hostedemail.com (Postfix) with ESMTP id 25FF9C0015 for ; Wed, 21 Dec 2022 00:12:46 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=K59wK9Xm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of 3fk-iYwYKCMkD9Ewp3v33v0t.r310x29C-11zAprz.36v@flex--yuzhao.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3fk-iYwYKCMkD9Ewp3v33v0t.r310x29C-11zAprz.36v@flex--yuzhao.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671581567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XaREnfCRyQU3ad5Wd1iK/L1d7XHMzN1hNI71g9W9Aqc=; b=PMH2qO2VOJAfXa4+aBpX4bwtJm41IS8wn5YebnQxOFrX713ujd+24FbHFm0gkpMmnHpsP4 ROfQd2kFbs131ghC/lcz7IJeDp+ueOaRty/ee1Cl8QZf35hHlSvnuaDhuxKK4mnKg353ef 47XLpdF2Nbf2modVFZCR5q2dRmsXpZo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=K59wK9Xm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of 3fk-iYwYKCMkD9Ewp3v33v0t.r310x29C-11zAprz.36v@flex--yuzhao.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3fk-iYwYKCMkD9Ewp3v33v0t.r310x29C-11zAprz.36v@flex--yuzhao.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671581567; a=rsa-sha256; cv=none; b=IN+S0HIccsbXsLBesY2+mNIMhhu979hayDLBH4Jk7jtWNwtUy+gQXOYMZJYFtuVeq0faIn g7bGBrkoivbsU3S3S0HdGlstJedM0hs1qs8vF13tqgZbc9cn0jNB3GwT8kNabYQrGEeci2 R4HmoFMjNUjOHbYnuzzQZNRinoci1M8= Received: by mail-yb1-f202.google.com with SMTP id k7-20020a256f07000000b006cbcc030bc8so15882793ybc.18 for ; Tue, 20 Dec 2022 16:12:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=XaREnfCRyQU3ad5Wd1iK/L1d7XHMzN1hNI71g9W9Aqc=; b=K59wK9Xmrz3Bi5vvMVhN1G0pDO7CebJ60f+DjHwvBqntIUvRaRf11KCBF3IsW1uuCm LmdCEuyR6sl4QvqXqpqJlFmXBaasCbZ9nmXW6MTluImHgbKMWTiBxrs1SJxF+2QwuG8Y n3lT/WRDW8kZrenttBA6PiXNPTJQt4eM3DyDoOliigATORAsfTFpRCXSul0pGuAI9MlF xvpQD3dmjMzt8YndE3tmefxjvQ2G/DucE0e/w5OXs/Vyk/ThipPMV2jWTndUm75lJJeN Y5SOmz71wirINtVmmU6GITMwX4RwAhx/qeWMh267Z+OXa2GTQYBVO7aJK80W77QZ+2mh Zn+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XaREnfCRyQU3ad5Wd1iK/L1d7XHMzN1hNI71g9W9Aqc=; b=gD4Qf5GEbci/c8CcmtT3lJ85tzdrGgblTbpAQkkuW50PHnEVWojgS7UA8ROVJXfSvD HuxBSsQEan7rafodf6nQAt5vj3CMkn30uRXEJiLVVIhyI2HrKJpMmmKYLeCJjq2pMROC LCwV8MSJxvlx/mhNE/eVyjasOSEHGJH8KND+1wcMZLs5BcTSUDhpl1yDu4rv2C5GeHv7 lhkvm0rUCMAuKQXUD/IN7y8neUCvttFiCCFiGLDIyVwY8J0LHOP1U4JgnoKb467QerOY V8USqMk+c8cOB8xEK8bXpsEY3I30VA+smfZkqwttHXHw9oR56C3UQOkZXOn+mymIxc4d lynQ== X-Gm-Message-State: AFqh2ko+Vc8Oa/XClpHfXuWk+jsrO90Ivotn9BySOnMUYQpKARUZkPKK b4dBqXjZWuY1qjHZPDSJiVJVu1nwwJo= X-Google-Smtp-Source: AMrXdXur6oRo558EHTCVqmu2nmkUYNqNZaoP17m0xPtqeSBL8ltbKO3K5SoD9CmsnhBaHILyzV33vTOZCRs= X-Received: from yuzhao.bld.corp.google.com ([2620:15c:183:200:a589:30f2:2daa:4ab7]) (user=yuzhao job=sendgmr) by 2002:a0d:cbd7:0:b0:388:7d2:575d with SMTP id n206-20020a0dcbd7000000b0038807d2575dmr768501ywd.21.1671581566428; Tue, 20 Dec 2022 16:12:46 -0800 (PST) Date: Tue, 20 Dec 2022 17:12:08 -0700 In-Reply-To: <20221221001207.1376119-1-yuzhao@google.com> Message-Id: <20221221001207.1376119-9-yuzhao@google.com> Mime-Version: 1.0 References: <20221221001207.1376119-1-yuzhao@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Subject: [PATCH mm-unstable v2 8/8] mm: multi-gen LRU: simplify arch_has_hw_pte_young() check From: Yu Zhao To: Andrew Morton Cc: Johannes Weiner , Jonathan Corbet , Michael Larabel , Michal Hocko , Mike Rapoport , Roman Gushchin , Suren Baghdasaryan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mm@google.com, Yu Zhao X-Rspamd-Queue-Id: 25FF9C0015 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: hz75yrfwue1hrrrmqew6whhdf9kyo3q6 X-HE-Tag: 1671581566-996743 X-HE-Meta: U2FsdGVkX18k422k13UijIZpYYBCw9WdeUETJSF5WNlJ/MCxygx++bLgC4GogcRF6c9t3ZfsdfnTf2xW9sYeFC8+rQrWCdfG8hxSpaUp1snHrx8FdmE5GKSKO58QKGrz8nxvyF71YcnV7KPZbWrXaqBLMj7zFtvuKzIVZ4boq7DiAgzeWhWPnTY0MM4n6/etdVeNasq2za131mtALYFKHOKE6w0wfUbAPxys1x95mJy3tjJEc0Z+ChSd9ZGA6I0+gpm4DVTBHNQ+Oo4xcw+0B6QRhCGM7Ra6MyGKJH7fCRwJNxQAMsg8wVvzM2mWSKBFD26qPK59v0ZRkt2tIpaDZE416mU4dJX24X9IvbWIxVxCx33oyxVTJxBLiKqzhdxAmOc0uRtWOWxqKxqMZyhWcNogYVmHyetXQ+mB/CUVtzy+hXPJmxiBmitEI9IfUgNHdd2LI2DEldSyWmAP5DITwW059m7eEzOkKNPrKIPjHLV794839olwXCNpL1MnDdYHIY6o6Il7MofCYO7NDAhXm0PdnfQlsq/FjRzy5WLcs0SwTn0yRQColOZoMeaPuuWppD2X5+Ab/hGg3ubfqUbWcOK6cAgq6slgI3yskd8zADji9GN8hJtIJIY6LwWFU1CIAmOR2kcdJiIBE65baFBn9aWNW7AS6IN8fiOZnY/R/wJbZ95esOmCvA2p0xfNxq4Ji8X3mdn2JVN2dJOs0q9eSllr5pPn78ki31mhM27K1tN0sUvrVHkFRXVanbUD3MWO3gmfXIKRBIs03Nlbc6QM43fEXLdx4ZCkD+tpdYS36kpnl5MIIud5k+pocYhOxHkWE2Mr2FujSZFKHWy/cAk/h108CIRWqnGgfs+eZ3CeP7TBCXw0LRURHm4oWR2GI96EJkqNpVBN1eZyuYuWesskOVr7OWnYUr8cwGk/QhwDAIE/D44LMmK60Qssk65R6zpVPx+NbA4eRcs9Za5Kn/k 79nHnBcJ T7rVGQVN68zNOoK3+QoOVvLlQxdS/DjsU3aXAt7KPAzFtxpnm8xk+zyspN9u8ajz4VDLr0x49iPkus2s7wXQNe+Q+V48Z+3Xl02VYttKztNy5zJVNmkIq+TbVB2TABfCVqLzYqHbcH9ghqJ6memo4JnDSesnOrbo0gGxvBTAVY2PrRXv8+ibhTO/1LS8zBeFsDh35yccZS+zHGUMfBBcqmMK9PZkS+w2pqgwY4XkcAbKPUNBncrHNnRrmXNb7i1W7A4+J8z+k3p3Yo3CyKxNoLKstKsXqmJyl/bQyVwDyZZTzZ9wFwnu7dcxKhsAi2cQpCxzSBzbY0oJIpTqJYITb/34lv3QqSPhbGP9b/ePa4xxRll5BsbDJAbjCs1jG2ZSSVogdgKn3vC0K5PKf6d9FvfwPi1YYhUfq0yuH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Scanning page tables when hardware does not set the accessed bit has no real use cases. Signed-off-by: Yu Zhao Change-Id: I414310f1cf642d305a16045518517f09ce0eda23 --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 308c3c16d81d..88948f4c8d18 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4430,7 +4430,7 @@ static bool try_to_inc_max_seq(struct lruvec *lruvec, unsigned long max_seq, * handful of PTEs. Spreading the work out over a period of time usually * is less efficient, but it avoids bursty page faults. */ - if (!force_scan && !(arch_has_hw_pte_young() && get_cap(LRU_GEN_MM_WALK))) { + if (!arch_has_hw_pte_young() || !get_cap(LRU_GEN_MM_WALK)) { success = iterate_mm_list_nowalk(lruvec, max_seq); goto done; }