From patchwork Wed Dec 21 17:44:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 13079011 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554E0C4167B for ; Wed, 21 Dec 2022 17:45:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88B578E0002; Wed, 21 Dec 2022 12:45:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CA5C8E0007; Wed, 21 Dec 2022 12:45:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DD258E0002; Wed, 21 Dec 2022 12:45:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 37E828E0005 for ; Wed, 21 Dec 2022 12:45:01 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E2B361A0A9F for ; Wed, 21 Dec 2022 17:45:00 +0000 (UTC) X-FDA: 80267039160.06.7131D6E Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf13.hostedemail.com (Postfix) with ESMTP id 31F1D20006 for ; Wed, 21 Dec 2022 17:44:58 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="dE1TQ/p/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671644699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pmUb1QKe4F1LbUqf8OCHo3aefKMY5b7fvAAbpd6Jpw0=; b=1WDolA9dx6h8P66Fn4fivD/H2jKV5v1dHoaRIyfIpqSc8UWdHkacRc0WBPcjdoItCtkUoW 09J06EZHnswmxo/nxMRbAZIZhej9PLpKC24ALmziqgl9uoox19oVOXSwui/Tnea0x9y0nl d9bC1WzZIRUztjF12gF0mm0ONs9Do7A= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="dE1TQ/p/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671644699; a=rsa-sha256; cv=none; b=eeQTKg2Hxn+CxxpLqrbtYmXQGfqoxa61DwFY+KHYQtS+z7qp1JZMDlfT5RWdiLj+H8j3Q2 acf1S12Q4ItshiQ00RAA/yVVyb4DEFBIDyG+LBxwry7S01XOIjeFQnxMIt81WbWsXIKeWf 7Q9Wk06MdXRAOVlVaj4xlbuwqct9l7c= Received: by mail-lf1-f47.google.com with SMTP id b13so24612284lfo.3 for ; Wed, 21 Dec 2022 09:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pmUb1QKe4F1LbUqf8OCHo3aefKMY5b7fvAAbpd6Jpw0=; b=dE1TQ/p/b1Dr8RhHyq0jYkg3zkOqncrovjp/8HxZtG3m9L7xzBnGW7eg9+NiOPxCv7 o8GA7JTAQ3Vn6w0FQUY5e3NkrDgc7qbxjxWWQUV3oiorJYI0Gt0Ms85PHZJhUjfkhuIS RpGrZXO3SurjzdbAeWU6KVDK+A8OABNJkryL/ZPT4NQx8UnUXhdDyqqqaIspzxUFhg2x EogouuIw6eLlCUgt+Z/iNWQMx9wedxXK0I0VYCKeovMB9pwPTxrcyVkghouEQxNhLDqx kGjPFTQm61Ow8eqdUoE9iEAv6GH6+8MbX5RMTdXN15kdXRrc0kRLcdG+Q3KmQmPODr5z aVtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pmUb1QKe4F1LbUqf8OCHo3aefKMY5b7fvAAbpd6Jpw0=; b=noBjtxF3YRdGzDelaZbx5czhIFgnQV/B6OxviTWqnK0QqBLCtSiOJeOBmMSExteW/0 ltmQauhvWZnviRTrudFaLLz8YNZSB3hWWOYPaGCOlzpbWwEmdpy9dSiKTWApZK3WFhxp lzjo8dTq13o1RO2nfy8Z5PhVVfnqRYKfq7PlGQcrLYOrwammlQUrJsAIFVYAWOPkU8F2 hOO1hI9lIY47Al9g5S42mIbUauy9xx/abO7Tc4YUTq16pqu2aYvP6VCJ8n+o+LEfoexi aCpBZtkSd54jVd2JsKO6SbdCQANLZ6aSlu/UNjxRmOpuCHQHzh3sk+1l9HL0SgTHDSin NnGw== X-Gm-Message-State: AFqh2koH+RYCz6kNMixyPQOBiCnLh+DPLQkm9Fj85iFysiMFfwCTtlK3 qcNh7cY7FTPCLdi2FUMzs0U= X-Google-Smtp-Source: AMrXdXsVbYEx6UkqBYvVQrCBZN5fgFg8xukjZRZ5a0hZXacy6agCjFEwscMh58q9djlzMN1Aj40Jzg== X-Received: by 2002:a05:6512:3b20:b0:4a4:68b7:f863 with SMTP id f32-20020a0565123b2000b004a468b7f863mr1426959lfv.7.1671644697682; Wed, 21 Dec 2022 09:44:57 -0800 (PST) Received: from pc638.lan ([155.137.26.201]) by smtp.gmail.com with ESMTPSA id r18-20020ac252b2000000b004a91d1b3070sm1904915lfm.308.2022.12.21.09.44.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 09:44:57 -0800 (PST) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH v2 3/3] mm: vmalloc: Replace BUG_ON() by WARN_ON_ONCE() Date: Wed, 21 Dec 2022 18:44:54 +0100 Message-Id: <20221221174454.1085130-3-urezki@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221221174454.1085130-1-urezki@gmail.com> References: <20221221174454.1085130-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 31F1D20006 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 67efasxmgkdccx3fitegjfswuf94epwq X-HE-Tag: 1671644698-868869 X-HE-Meta: U2FsdGVkX19WI+iVn55co0zXATyyiSgJAXo2lqDSaF3zJLlEqzzsYwFMT6RJQAQaQndOQJKAV1t/DxFwPNYeYbCM7p0wEm2LPWyOhc1uLf2Uhtunq828OnApjMgwOIfZUebcMCKyzihJ31m6MkSfjd4B8yFbiDoGM1Om/lIfEfmypK3CrhvPH3Q5X3u4kYPD47S6fvgdhEoo8+NQxYb3aKULGfYMbXRJu3nS6HtwM/G98i0n+v0Bxa8H3Rbl/hTtqgGPJoRnk1cUkWK+PwgUZOqoLiu8JmHF25Lp9QZ5midHYaLYFZP5KFm39lgjZ62/NGViY6x/lIBBYq/4ali61UuJmic3ZcCVkvNSIvfq/fhki1BpPK9ze1NqHciRrR3MNbOgoUR0/NH+RveowwRMWXnzZvMQJD1HutSGZBG8h7hZ0mkBNAa+jwEeKGog/Rk1Fp0TgpkkNKTo3x8Q5B1me2Ejpdn1jawRHqKgte1oJjVON0FUR7J82+2i9UrMvfX+eCW0gc2T1/XI+EznTx/T3TNmRwXami4hZXW4nntTOLZGv8S6kr2TXRMz+LeWSQE2gOPa9aAQzJHy6pzcYy4Sq09wWl/QW9f/kecACxoBEE/NpeCxIL5Kw4wXiCegL53c0l/KhpYowzxVTlbQan1Ol7Uqs2ywetX6zMgeva2RvNKpRaOuQNDzUGF03Cw2BKfjlzkmMWbiRmylVzvBtoUA2OInSzWgKey58AiWc7UA5743RDIiFg4F1XunuhrqoWCKCP3TDkUm0PjEAEPhPi9sGv9AB56pSYCaPdyLScKkPoc4PljYvgp8J2u3W6VscQrOxE5mKVh0rkLvHoGWikAnGBzEp1nfHr6ZN/Qx1RJ/HwPnPROR4BUpIumcn5UBIwwMgelrN0/wZtlPBZo6LtheZsxuRa+a1326APzXN4mcL9sPE5Jp270SMbS/BkWdLcFS7gVYv3i1U3tSyusd3c9 Bp7axQmC LeIhQkamOLjsy2llhCA4NfypNPqvMySHmIhJ44EPAg7VUdFKtwmXpdmP5FggFZykv7eiiOBi4UZhBR0kWf9y/jRwF+44Yxb0/ZTb6wJ2ZkZWCrpgISZt1lty3uvNpyOaFiKAVNh5Gi6R3hz2VPa45TmFE5Xu5TeEdq0Y4jUISmgzQk5g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently a vm_unmap_ram() functions triggers a BUG() if an area is not found. Replace it by the WARN_ON_ONCE() error message and keep machine alive instead of stopping it. The worst case is a memory leaking. Signed-off-by: Uladzislau Rezki (Sony) Reviewed-by: Lorenzo Stoakes --- mm/vmalloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 17e688cc7357..221d8950e13c 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2252,7 +2252,9 @@ void vm_unmap_ram(const void *mem, unsigned int count) } va = find_unlink_vmap_area(addr); - BUG_ON(!va); + if (WARN_ON_ONCE(!va)) + return; + debug_check_no_locks_freed((void *)va->va_start, (va->va_end - va->va_start)); free_unmap_vmap_area(va);